All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: tlv320dac33: Add guarding parentheses to macros
@ 2011-09-29  4:09 Axel Lin
  2011-09-29  6:59 ` Péter Ujfalusi
  2011-09-29  9:53   ` Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2011-09-29  4:09 UTC (permalink / raw)
  To: linux-kernel; +Cc: Peter Ujfalusi, Liam Girdwood, Mark Brown, alsa-devel

Put parentheses around macro argument uses. This avoids pitfalls
for the programmer, where the argument expansion does not give the
expected result, for example:

SAMPLES_TO_US(substream->runtime->rate, dac33->uthr - DAC33_MODE7_MARGIN + 1);

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 sound/soc/codecs/tlv320dac33.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/tlv320dac33.c b/sound/soc/codecs/tlv320dac33.c
index 243d177..389b1c2 100644
--- a/sound/soc/codecs/tlv320dac33.c
+++ b/sound/soc/codecs/tlv320dac33.c
@@ -55,13 +55,13 @@
 #define BURST_BASEFREQ_HZ	49152000
 
 #define SAMPLES_TO_US(rate, samples) \
-	(1000000000 / ((rate * 1000) / samples))
+	(1000000000 / (((rate) * 1000) / (samples)))
 
 #define US_TO_SAMPLES(rate, us) \
-	(rate / (1000000 / (us < 1000000 ? us : 1000000)))
+	((rate) / (1000000 / ((us) < 1000000 ? (us) : 1000000)))
 
 #define UTHR_FROM_PERIOD_SIZE(samples, playrate, burstrate) \
-	((samples * 5000) / ((burstrate * 5000) / (burstrate - playrate)))
+	(((samples)*5000) / (((burstrate)*5000) / ((burstrate) - (playrate))))
 
 static void dac33_calculate_times(struct snd_pcm_substream *substream);
 static int dac33_prepare_chip(struct snd_pcm_substream *substream);
-- 
1.7.4.1




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: tlv320dac33: Add guarding parentheses to macros
  2011-09-29  4:09 [PATCH] ASoC: tlv320dac33: Add guarding parentheses to macros Axel Lin
@ 2011-09-29  6:59 ` Péter Ujfalusi
  2011-09-29  9:53   ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Péter Ujfalusi @ 2011-09-29  6:59 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Liam Girdwood, Mark Brown, alsa-devel

On Thursday 29 September 2011 12:09:57 Axel Lin wrote:
> Put parentheses around macro argument uses. This avoids pitfalls
> for the programmer, where the argument expansion does not give the
> expected result, for example:
> 
> SAMPLES_TO_US(substream->runtime->rate, dac33->uthr - DAC33_MODE7_MARGIN +
> 1);

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: tlv320dac33: Add guarding parentheses to macros
  2011-09-29  4:09 [PATCH] ASoC: tlv320dac33: Add guarding parentheses to macros Axel Lin
@ 2011-09-29  9:53   ` Mark Brown
  2011-09-29  9:53   ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-09-29  9:53 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Peter Ujfalusi, Liam Girdwood, alsa-devel

On Thu, Sep 29, 2011 at 12:09:57PM +0800, Axel Lin wrote:
> Put parentheses around macro argument uses. This avoids pitfalls
> for the programmer, where the argument expansion does not give the
> expected result, for example:

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: tlv320dac33: Add guarding parentheses to macros
@ 2011-09-29  9:53   ` Mark Brown
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-09-29  9:53 UTC (permalink / raw)
  To: Axel Lin; +Cc: Peter Ujfalusi, alsa-devel, linux-kernel, Liam Girdwood

On Thu, Sep 29, 2011 at 12:09:57PM +0800, Axel Lin wrote:
> Put parentheses around macro argument uses. This avoids pitfalls
> for the programmer, where the argument expansion does not give the
> expected result, for example:

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-09-29  9:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-29  4:09 [PATCH] ASoC: tlv320dac33: Add guarding parentheses to macros Axel Lin
2011-09-29  6:59 ` Péter Ujfalusi
2011-09-29  9:53 ` Mark Brown
2011-09-29  9:53   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.