All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: outreachy-kernel@googlegroups.com
Cc: Bhumika Goyal <bhumirks@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH 0/3] Staging: rdma: Remove wrapper functions
Date: Thu, 25 Feb 2016 15:19:09 +0100	[thread overview]
Message-ID: <3462200.DanSUfdRtD@wuerfel> (raw)
In-Reply-To: <cover.1456390351.git.bhumirks@gmail.com>

On Thursday 25 February 2016 17:25:55 Bhumika Goyal wrote:
> The functions add_rcvctrl, clear_rcvctrl, sdma_start_hw_clean_up can be 
> replaced with direct calls to the functions they wrapped. Thus remove the 
> wrapper functions and replace their calls with the functions they wrapped.
> Changes are done using coccinelle semantic patches.
>  
> Bhumika Goyal (3):
>   Staging: rdma: Remove wrapper function add_rcvctrl
>   Staging: rdma: Remove wrapper clear_rcvctrl
>   Staging: rdma: Remove wrapper sdma_start_hw_clean_up

These are all in a grey area. I'd personally suggest doing the third
patch only, but not the first two that remove what seems to be
a useful abstraction.

	Arnd


  parent reply	other threads:[~2016-02-25 14:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25 11:55 [PATCH 0/3] Staging: rdma: Remove wrapper functions Bhumika Goyal
2016-02-25 11:55 ` [PATCH 1/3] Staging: rdma: Remove wrapper function add_rcvctrl Bhumika Goyal
2016-02-25 11:55 ` [PATCH 2/3] Staging: rdma: Remove wrapper clear_rcvctrl Bhumika Goyal
2016-02-25 11:55 ` [PATCH 3/3] Staging: rdma: Remove wrapper sdma_start_hw_clean_up Bhumika Goyal
2016-02-25 12:49   ` [Outreachy kernel] " Julia Lawall
2016-02-25 14:19 ` Arnd Bergmann [this message]
2016-02-25 14:28   ` [Outreachy kernel] [PATCH 0/3] Staging: rdma: Remove wrapper functions Bhumika Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3462200.DanSUfdRtD@wuerfel \
    --to=arnd@arndb.de \
    --cc=bhumirks@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.