From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750885AbdE1QaJ (ORCPT ); Sun, 28 May 2017 12:30:09 -0400 Received: from david.siemens.de ([192.35.17.14]:59527 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750791AbdE1QaI (ORCPT ); Sun, 28 May 2017 12:30:08 -0400 Subject: Re: [PATCH] scripts/gdb: make lx-dmesg command work (reliably) To: Andy Shevchenko Cc: =?UTF-8?Q?Andr=c3=a9_Draszik?= , "linux-kernel@vger.kernel.org" , Kieran Bingham References: <20170526110454.1119-1-git@andred.net> <1c56ad8f-2128-3fe2-7a22-fb2074084a5e@siemens.com> From: Jan Kiszka Message-ID: <346a4a29-5e49-5ac2-24be-667c641b0e56@siemens.com> Date: Sun, 28 May 2017 18:29:58 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-05-27 16:01, Andy Shevchenko wrote: > On Fri, May 26, 2017 at 2:12 PM, Jan Kiszka wrote: >> On 2017-05-26 13:04, André Draszik wrote: > >>> + log_buf_addr = int(str(gdb.parse_and_eval("'printk.c'::log_buf")).split()[0], 16) >> >> Overlong line. Please stay pep8 compliant. > > What I heard from colleague of mine couple of years ago, they (their > team) moved to 100 characters in Python scripts because of somehow > stupid recommendations from last century. Well, it happens to be in line with the kernel preference for C code. We can discuss a different style when the kernel relaxes its own. ;) Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux