From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 20/25] bnxt: add support to get and clear
	VF specific stats
Date: Wed, 31 May 2017 18:15:12 +0200
Message-ID: <3474664.4106PkU1my@xps>
References: <CACZ4nhuCdAoJJtmi2joaHf9+4+MzVFz87S-XO_J-HRBGUdiEFg@mail.gmail.com>
 <CACZ4nhuAS9bE=gmNsgqWvf8_BBvBsKy2FU3Z-_CQnc-LnxRWfA@mail.gmail.com>
 <0936c7fb-e819-dcb4-1e09-d955f22cba97@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org,
 Stephen Hurd <stephen.hurd@broadcom.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CA5537CC7
 for <dev@dpdk.org>; Wed, 31 May 2017 18:15:13 +0200 (CEST)
In-Reply-To: <0936c7fb-e819-dcb4-1e09-d955f22cba97@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

31/05/2017 16:46, Ferruh Yigit:
> On 5/31/2017 3:27 PM, Ajit Khaparde wrote:
> > On Wed, May 31, 2017 at 4:57 AM, Ferruh Yigit <ferruh.yigit@intel.com
> > <mailto:ferruh.yigit@intel.com>>wrote:
> >=20
> >     On 5/31/2017 3:12 AM, Ajit Khaparde wrote:
> >     >
> >     > On Mon, May 29, 2017 at 12:43 PM, Ferruh Yigit <ferruh.yigit@inte=
l.com <mailto:ferruh.yigit@intel.com>
> >     > <mailto:ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>>>
> >     wrote:
> >     >
> >     >     > +int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t
> >     *count)
> >     >     > +{
> >     >     > +     struct rte_eth_dev *dev;
> >     >     > +     struct rte_eth_dev_info dev_info;
> >     >     > +     struct bnxt *bp;
> >     >     > +
> >     >     > +     dev =3D &rte_eth_devices[port];
> >     >     > +     rte_eth_dev_info_get(port, &dev_info);
> >     >     > +     bp =3D (struct bnxt *)dev->data->dev_private;
> >     >     > +
> >     >     > +     return bnxt_hwrm_func_qstats_tx_drop(bp, 0xffff, coun=
t);
> >     >     > +}
> >     >
> >     >     This function is not to get VF stats from PF. As far as I can
> >     see this
> >     >     just gets queue stats, does this really needs to be PMD
> >     specific API,
> >     >     isn't this something generic?
> >     >
> >     >
> >     > =E2=80=8BYes. That is right. It returns a count of number of pack=
ets which
> >     were
> >     > not transmitted
> >     > because it did not pass the MAC/VLAN spoof check.
> >     > It does not
> >     > necessarily mean "failure to transmit" and so I don't think it is
> >     right
> >     > to map it to oerrors.
> >     > So in the current form I don't see a way to make a generic
> >     function out
> >     > of it.=E2=80=8B
> >=20
> >     I see, this is implemented because there is no place in basic stats=
 to
> >     put tx_drop_pkts.
> >=20
> >     Can xstats be used to get this value? Can new .xstats_get_by_id help
> >     here?
> >=20
> > =E2=80=8BMay be we could. Do we have time for that?=E2=80=8B
>=20
> Agreed that this may require effort, but I believe we should not use PMD
> specific APIs as much as possible, and stick to ethdev abstraction layer.
>=20
> PMD specific API kills the portability, and only should be used to
> benefit from features that are available only for that PMD.
>=20
> This was my concern to start implementing more thing in PMD layer, like
> getting tx_drop stats..

Yes I agree the specific statistics should be added in xstats.