From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC6E8ECDFA1 for ; Tue, 25 Oct 2022 12:44:45 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E6C61530E; Tue, 25 Oct 2022 14:43:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E6C61530E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1666701884; bh=34VsYq4n2RDUur/4vw8PqAd9uQlmkAzoXWzgUKgfGPs=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GnG+m2xll2smKvWpB9sfy6dBej82EeMwLCIQB0hkeTYXnxKNqyuoOMlBeRMygt9qw TEhFzlRDa7K4D/+nkfwGWzdEQV89+iHHymkEm0PMo1aCj6cenBYKXyI8TCqwcOuFWI TxozOghcCXgsrwhwXmTA1e4s6IjYqt8S/6bi7Rb4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 84B7DF80431; Tue, 25 Oct 2022 14:43:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8289BF80448; Tue, 25 Oct 2022 14:43:51 +0200 (CEST) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 07328F80240 for ; Tue, 25 Oct 2022 14:43:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 07328F80240 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CGWd9EGm" Received: by mail-wr1-x430.google.com with SMTP id o4so12405479wrq.6 for ; Tue, 25 Oct 2022 05:43:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h4bB9DG6I4yQg1VaBFFskr0kCoybfjGK9a489xozqbQ=; b=CGWd9EGmlJFK+YEPgI0l2hwe3QK0ZhOT+JHvVsiZC12bo+c4Jl/FAYJrdHvAalOpGt tllbwPXcjRHsXQblFv5wBCsA+ty066EcfLUUp3vq6jrgpqnCqf5fS8/J1FkAml46w5yQ tGseitrCIP8oromfF0eRIfZdWQWi2HtjVV0Dkq9KDifUwNdXpfMbqoiGOSksX7lTAln9 bLuFQYXiUwWkd/i6dJqmss6GUSSdrz/4sDW9ZpmRhAlNVYZ+yjvTlyCsYz2IfUoCLaTa kjMSP2GYVCuZOnYOe03eK2yd8xVrU4sjiIjmnirDbhaLGlIfyZ2JIE6LdJzGBTV9bPVK +Fng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h4bB9DG6I4yQg1VaBFFskr0kCoybfjGK9a489xozqbQ=; b=FC72JMvScIiM7527GQvNOn7t3szK41GWCJWat69meH6zZhGdxqPEhr/Pi0X/oFaaYR 1RcblFLhThcIFX6N1qoIxVKiixFV6auKe+8fjglOSeQ7gAFCj5wdWQ9MwyB1uTqqerVE 1ZVQeXeqlbPSHm7ILDnZ+oxHojKpN20LSKJO+Wud0sXusBHnvBr+SoJ3Xx38GTfXtjdg Azl/qCR0r2KcCyDSskFVO2b2hpBjIgy0hx49kS/h4dV5CSgFqPPMCN5MfS3FLPoEpRda 11lEnuvleI7B1HUUQyk6LWikj7zp+umLNZFH/GkbxHMPmn6w42BmcYD8kgDqDr/OlMh5 9Iqg== X-Gm-Message-State: ACrzQf2atrrikED8VW5H86pB/W91aLq0Gacn7Rr8lZ4UQYgymQ7C8mhA PpfrzJMUeJvTiQXO2gEDYw4= X-Google-Smtp-Source: AMsMyM5SL1IRETz58Y983NAHYtT70ugOevrG0yz5LC3UXysNz92AImLC0KI/69prTy1jTOu7poogHw== X-Received: by 2002:adf:e985:0:b0:236:6a53:3a16 with SMTP id h5-20020adfe985000000b002366a533a16mr8737605wrm.501.1666701827348; Tue, 25 Oct 2022 05:43:47 -0700 (PDT) Received: from archbook.localnet (84-72-105-84.dclient.hispeed.ch. [84.72.105.84]) by smtp.gmail.com with ESMTPSA id bp4-20020a5d5a84000000b0022e57e66824sm3163700wrb.99.2022.10.25.05.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 05:43:46 -0700 (PDT) From: Nicolas Frattaroli To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli Subject: Re: [PATCH 4/4] ASoC: rockchip: i2s_tdm: Add support for RK3588 Date: Tue, 25 Oct 2022 14:43:45 +0200 Message-ID: <3478206.uukdV1xfrs@archbook> In-Reply-To: <20221025124132.399729-5-frattaroli.nicolas@gmail.com> References: <20221025124132.399729-1-frattaroli.nicolas@gmail.com> <20221025124132.399729-5-frattaroli.nicolas@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Dienstag, 25. Oktober 2022 14:41:32 CEST Nicolas Frattaroli wrote: > This adds support for the RK3588 SoC to the I2S/TDM driver. > --- > sound/soc/rockchip/rockchip_i2s_tdm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/rockchip_i2s_tdm.c > index 917f17107891..08b90ec5cc80 100644 > --- a/sound/soc/rockchip/rockchip_i2s_tdm.c > +++ b/sound/soc/rockchip/rockchip_i2s_tdm.c > @@ -1318,6 +1318,7 @@ static const struct of_device_id rockchip_i2s_tdm_match[] = { > { .compatible = "rockchip,rk1808-i2s-tdm", .data = &rk1808_i2s_soc_data }, > { .compatible = "rockchip,rk3308-i2s-tdm", .data = &rk3308_i2s_soc_data }, > { .compatible = "rockchip,rk3568-i2s-tdm", .data = &rk3568_i2s_soc_data }, > + { .compatible = "rockchip,rk3588-i2s-tdm" }, > { .compatible = "rockchip,rv1126-i2s-tdm", .data = &rv1126_i2s_soc_data }, > {}, > }; > @@ -1556,7 +1557,7 @@ static int rockchip_i2s_tdm_probe(struct platform_device *pdev) > i2s_tdm->dev = &pdev->dev; > > of_id = of_match_device(rockchip_i2s_tdm_match, &pdev->dev); > - if (!of_id || !of_id->data) > + if (!of_id) > return -EINVAL; > > spin_lock_init(&i2s_tdm->lock); > Oops, forgot the signoff on this one. For this purpose: Signed-off-by: Nicolas Frattaroli My apologies. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88547C38A2D for ; Tue, 25 Oct 2022 12:44:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vmhLFjAEdeyB+3MTfUi6en3BMcQruA5up+8bNhPhxJc=; b=HDJdmBofw/T4wG TwhJ3l/U/zLDwib7hsUiocjTRhrV0bG+Rd43qsdmmnK4U6E167VQNKF9V33l8yOZ/AG1gzsA9bv8t 4C+pGDMv8/Cwh/x6RAw7ykXrc7hfbEfRD/dX9iPwXTtx8nSeWryGI7KBlUIif1gkv3bi+0T5nXa4M BclgEpdMCno4SWqeHxaZ+0gQALQf0xY3P5+GNY74sxsMjc40H/b7WGWWW+xcJciJ+qgPqOgYzsHiI TjrQbQFe49agI0bO+ajLc+AiC0H2BK4NdM7E42V+OSNWmbQV/g7rAzL4j1cjjefLpWcQk0UbguSc/ dQzIDiQO2iOMvSrVsGUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onJHc-005FBF-2y; Tue, 25 Oct 2022 12:43:52 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onJHY-005F8R-IJ; Tue, 25 Oct 2022 12:43:49 +0000 Received: by mail-wr1-x42d.google.com with SMTP id bu30so20646344wrb.8; Tue, 25 Oct 2022 05:43:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h4bB9DG6I4yQg1VaBFFskr0kCoybfjGK9a489xozqbQ=; b=CGWd9EGmlJFK+YEPgI0l2hwe3QK0ZhOT+JHvVsiZC12bo+c4Jl/FAYJrdHvAalOpGt tllbwPXcjRHsXQblFv5wBCsA+ty066EcfLUUp3vq6jrgpqnCqf5fS8/J1FkAml46w5yQ tGseitrCIP8oromfF0eRIfZdWQWi2HtjVV0Dkq9KDifUwNdXpfMbqoiGOSksX7lTAln9 bLuFQYXiUwWkd/i6dJqmss6GUSSdrz/4sDW9ZpmRhAlNVYZ+yjvTlyCsYz2IfUoCLaTa kjMSP2GYVCuZOnYOe03eK2yd8xVrU4sjiIjmnirDbhaLGlIfyZ2JIE6LdJzGBTV9bPVK +Fng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h4bB9DG6I4yQg1VaBFFskr0kCoybfjGK9a489xozqbQ=; b=Su6sNx5csVuvPV0IIBA+tnVsa0Xd9daqFID2nM6n8SqYtcQh9m30kc0BG5/JhTLyPS sWbpRTgw/KeCBdVHF8rhMbwxKQaWNMubnvTMM6Ckiz+ldSQnnhm1YK2NlAYTvsvJfgOz 2GrQBgs95SxOEaJgz57p0vAAh2odsLbFHaV1bqqgAPxqULkoIvqCPLntUyuOnqyMZeWR Z+8wJHqSZzB071HVmcWo5OYMUt6LZMyD7gelmess19D7IXVTUrB4KW8WuSuTx61N4OXQ G7195cGXSCSKffBD+b86QSn+xsM8elxDL8etuduGOFljFBQwvmMBv/qHEK8j6Ok4Yipc uXaw== X-Gm-Message-State: ACrzQf0mw2xerHnY9Fp//RCtXwG1R1v4RrPAFm7UidWIt4dOm3Nr0n3h 9aXrqBLk32QO1uFbo/+3vY0= X-Google-Smtp-Source: AMsMyM5SL1IRETz58Y983NAHYtT70ugOevrG0yz5LC3UXysNz92AImLC0KI/69prTy1jTOu7poogHw== X-Received: by 2002:adf:e985:0:b0:236:6a53:3a16 with SMTP id h5-20020adfe985000000b002366a533a16mr8737605wrm.501.1666701827348; Tue, 25 Oct 2022 05:43:47 -0700 (PDT) Received: from archbook.localnet (84-72-105-84.dclient.hispeed.ch. [84.72.105.84]) by smtp.gmail.com with ESMTPSA id bp4-20020a5d5a84000000b0022e57e66824sm3163700wrb.99.2022.10.25.05.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 05:43:46 -0700 (PDT) From: Nicolas Frattaroli To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli Cc: linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] ASoC: rockchip: i2s_tdm: Add support for RK3588 Date: Tue, 25 Oct 2022 14:43:45 +0200 Message-ID: <3478206.uukdV1xfrs@archbook> In-Reply-To: <20221025124132.399729-5-frattaroli.nicolas@gmail.com> References: <20221025124132.399729-1-frattaroli.nicolas@gmail.com> <20221025124132.399729-5-frattaroli.nicolas@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221025_054348_651136_730D8CFB X-CRM114-Status: GOOD ( 18.43 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Dienstag, 25. Oktober 2022 14:41:32 CEST Nicolas Frattaroli wrote: > This adds support for the RK3588 SoC to the I2S/TDM driver. > --- > sound/soc/rockchip/rockchip_i2s_tdm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/rockchip_i2s_tdm.c > index 917f17107891..08b90ec5cc80 100644 > --- a/sound/soc/rockchip/rockchip_i2s_tdm.c > +++ b/sound/soc/rockchip/rockchip_i2s_tdm.c > @@ -1318,6 +1318,7 @@ static const struct of_device_id rockchip_i2s_tdm_match[] = { > { .compatible = "rockchip,rk1808-i2s-tdm", .data = &rk1808_i2s_soc_data }, > { .compatible = "rockchip,rk3308-i2s-tdm", .data = &rk3308_i2s_soc_data }, > { .compatible = "rockchip,rk3568-i2s-tdm", .data = &rk3568_i2s_soc_data }, > + { .compatible = "rockchip,rk3588-i2s-tdm" }, > { .compatible = "rockchip,rv1126-i2s-tdm", .data = &rv1126_i2s_soc_data }, > {}, > }; > @@ -1556,7 +1557,7 @@ static int rockchip_i2s_tdm_probe(struct platform_device *pdev) > i2s_tdm->dev = &pdev->dev; > > of_id = of_match_device(rockchip_i2s_tdm_match, &pdev->dev); > - if (!of_id || !of_id->data) > + if (!of_id) > return -EINVAL; > > spin_lock_init(&i2s_tdm->lock); > Oops, forgot the signoff on this one. For this purpose: Signed-off-by: Nicolas Frattaroli My apologies. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A38BC38A2D for ; Tue, 25 Oct 2022 12:45:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RQpAwEL295HHbSfmK9e8ma8eY1VhkESEdy7vxEhypQU=; b=5GyRhCEXbDuRst ZufAn38velvFmq7d16U0+Tj9/L2F1dZa5GIqq6b78e28PqswRdhmyz0nS/VuFRUHV0yMsKatVirXg Hq/ySgpujYM7+/1FKZq00nxYFEVWuq2h/M2A/mCB6lQt/bMcdiQcjN1V4BpDTxuu72twePyvNJcSH xS1IzJmPcXRtScWV5e47Rd9TlfVoZU0VyszbOOIMJGd8RxmEbDRZ4GkRdellIYOEHiQPBTHChxlWr vpWFyPZY7dmHWHF+GxM3wt02l8h96naOdV5fRkfJf+MyQcvxzGtfajMQcFFUzxF3uNcuNUKT74cY5 fs3c8k8703KEK3GuYQaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onJHm-005FEL-02; Tue, 25 Oct 2022 12:44:02 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onJHY-005F8R-IJ; Tue, 25 Oct 2022 12:43:49 +0000 Received: by mail-wr1-x42d.google.com with SMTP id bu30so20646344wrb.8; Tue, 25 Oct 2022 05:43:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h4bB9DG6I4yQg1VaBFFskr0kCoybfjGK9a489xozqbQ=; b=CGWd9EGmlJFK+YEPgI0l2hwe3QK0ZhOT+JHvVsiZC12bo+c4Jl/FAYJrdHvAalOpGt tllbwPXcjRHsXQblFv5wBCsA+ty066EcfLUUp3vq6jrgpqnCqf5fS8/J1FkAml46w5yQ tGseitrCIP8oromfF0eRIfZdWQWi2HtjVV0Dkq9KDifUwNdXpfMbqoiGOSksX7lTAln9 bLuFQYXiUwWkd/i6dJqmss6GUSSdrz/4sDW9ZpmRhAlNVYZ+yjvTlyCsYz2IfUoCLaTa kjMSP2GYVCuZOnYOe03eK2yd8xVrU4sjiIjmnirDbhaLGlIfyZ2JIE6LdJzGBTV9bPVK +Fng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h4bB9DG6I4yQg1VaBFFskr0kCoybfjGK9a489xozqbQ=; b=Su6sNx5csVuvPV0IIBA+tnVsa0Xd9daqFID2nM6n8SqYtcQh9m30kc0BG5/JhTLyPS sWbpRTgw/KeCBdVHF8rhMbwxKQaWNMubnvTMM6Ckiz+ldSQnnhm1YK2NlAYTvsvJfgOz 2GrQBgs95SxOEaJgz57p0vAAh2odsLbFHaV1bqqgAPxqULkoIvqCPLntUyuOnqyMZeWR Z+8wJHqSZzB071HVmcWo5OYMUt6LZMyD7gelmess19D7IXVTUrB4KW8WuSuTx61N4OXQ G7195cGXSCSKffBD+b86QSn+xsM8elxDL8etuduGOFljFBQwvmMBv/qHEK8j6Ok4Yipc uXaw== X-Gm-Message-State: ACrzQf0mw2xerHnY9Fp//RCtXwG1R1v4RrPAFm7UidWIt4dOm3Nr0n3h 9aXrqBLk32QO1uFbo/+3vY0= X-Google-Smtp-Source: AMsMyM5SL1IRETz58Y983NAHYtT70ugOevrG0yz5LC3UXysNz92AImLC0KI/69prTy1jTOu7poogHw== X-Received: by 2002:adf:e985:0:b0:236:6a53:3a16 with SMTP id h5-20020adfe985000000b002366a533a16mr8737605wrm.501.1666701827348; Tue, 25 Oct 2022 05:43:47 -0700 (PDT) Received: from archbook.localnet (84-72-105-84.dclient.hispeed.ch. [84.72.105.84]) by smtp.gmail.com with ESMTPSA id bp4-20020a5d5a84000000b0022e57e66824sm3163700wrb.99.2022.10.25.05.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 05:43:46 -0700 (PDT) From: Nicolas Frattaroli To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli Cc: linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] ASoC: rockchip: i2s_tdm: Add support for RK3588 Date: Tue, 25 Oct 2022 14:43:45 +0200 Message-ID: <3478206.uukdV1xfrs@archbook> In-Reply-To: <20221025124132.399729-5-frattaroli.nicolas@gmail.com> References: <20221025124132.399729-1-frattaroli.nicolas@gmail.com> <20221025124132.399729-5-frattaroli.nicolas@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221025_054348_651136_730D8CFB X-CRM114-Status: GOOD ( 18.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Dienstag, 25. Oktober 2022 14:41:32 CEST Nicolas Frattaroli wrote: > This adds support for the RK3588 SoC to the I2S/TDM driver. > --- > sound/soc/rockchip/rockchip_i2s_tdm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/rockchip_i2s_tdm.c > index 917f17107891..08b90ec5cc80 100644 > --- a/sound/soc/rockchip/rockchip_i2s_tdm.c > +++ b/sound/soc/rockchip/rockchip_i2s_tdm.c > @@ -1318,6 +1318,7 @@ static const struct of_device_id rockchip_i2s_tdm_match[] = { > { .compatible = "rockchip,rk1808-i2s-tdm", .data = &rk1808_i2s_soc_data }, > { .compatible = "rockchip,rk3308-i2s-tdm", .data = &rk3308_i2s_soc_data }, > { .compatible = "rockchip,rk3568-i2s-tdm", .data = &rk3568_i2s_soc_data }, > + { .compatible = "rockchip,rk3588-i2s-tdm" }, > { .compatible = "rockchip,rv1126-i2s-tdm", .data = &rv1126_i2s_soc_data }, > {}, > }; > @@ -1556,7 +1557,7 @@ static int rockchip_i2s_tdm_probe(struct platform_device *pdev) > i2s_tdm->dev = &pdev->dev; > > of_id = of_match_device(rockchip_i2s_tdm_match, &pdev->dev); > - if (!of_id || !of_id->data) > + if (!of_id) > return -EINVAL; > > spin_lock_init(&i2s_tdm->lock); > Oops, forgot the signoff on this one. For this purpose: Signed-off-by: Nicolas Frattaroli My apologies. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3DD0C38A2D for ; Tue, 25 Oct 2022 12:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232348AbiJYMpz (ORCPT ); Tue, 25 Oct 2022 08:45:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232332AbiJYMpe (ORCPT ); Tue, 25 Oct 2022 08:45:34 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EF9D18F0DB for ; Tue, 25 Oct 2022 05:43:51 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id l14so13394554wrw.2 for ; Tue, 25 Oct 2022 05:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h4bB9DG6I4yQg1VaBFFskr0kCoybfjGK9a489xozqbQ=; b=CGWd9EGmlJFK+YEPgI0l2hwe3QK0ZhOT+JHvVsiZC12bo+c4Jl/FAYJrdHvAalOpGt tllbwPXcjRHsXQblFv5wBCsA+ty066EcfLUUp3vq6jrgpqnCqf5fS8/J1FkAml46w5yQ tGseitrCIP8oromfF0eRIfZdWQWi2HtjVV0Dkq9KDifUwNdXpfMbqoiGOSksX7lTAln9 bLuFQYXiUwWkd/i6dJqmss6GUSSdrz/4sDW9ZpmRhAlNVYZ+yjvTlyCsYz2IfUoCLaTa kjMSP2GYVCuZOnYOe03eK2yd8xVrU4sjiIjmnirDbhaLGlIfyZ2JIE6LdJzGBTV9bPVK +Fng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h4bB9DG6I4yQg1VaBFFskr0kCoybfjGK9a489xozqbQ=; b=qu7p4PsLyy4PHWUbSHpFYyryg+3ZTwqYgc3aAmCrx6yBaVaQrLmbjnjcYS9aPoihUb Yl0gf98B7nH1b7R+fKAZR6SYIMtN3Bj/y0tNR1pyW/9091GdgRrwT0+ZzdYjYUl6PyKq dLv5ngWN+QNm/Jdt9Q8okhbntfJ+R3lWxGajB7KBOOJs4M3BubXgafsg7icLf7s5+hbb 9jdTxeRe3814FX3r9lAPQ6NouVDD5TBYqV/A992gWRAdTzWkrQ/XvmQyuMY397jmdf9/ W5PXfVtKB5WPU03BqL2noRkp/II7g5+5obRX9JEgM2g3iq67qW69wgHhSW6hAia7onq4 SHkA== X-Gm-Message-State: ACrzQf2nngEGY/6R03kT9iVrk8kbpnID7MgJnURE0UdIJw61CYZxYaij QleNDBOU1WOrOx5I3QfZps4= X-Google-Smtp-Source: AMsMyM5SL1IRETz58Y983NAHYtT70ugOevrG0yz5LC3UXysNz92AImLC0KI/69prTy1jTOu7poogHw== X-Received: by 2002:adf:e985:0:b0:236:6a53:3a16 with SMTP id h5-20020adfe985000000b002366a533a16mr8737605wrm.501.1666701827348; Tue, 25 Oct 2022 05:43:47 -0700 (PDT) Received: from archbook.localnet (84-72-105-84.dclient.hispeed.ch. [84.72.105.84]) by smtp.gmail.com with ESMTPSA id bp4-20020a5d5a84000000b0022e57e66824sm3163700wrb.99.2022.10.25.05.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 05:43:46 -0700 (PDT) From: Nicolas Frattaroli To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli Cc: linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] ASoC: rockchip: i2s_tdm: Add support for RK3588 Date: Tue, 25 Oct 2022 14:43:45 +0200 Message-ID: <3478206.uukdV1xfrs@archbook> In-Reply-To: <20221025124132.399729-5-frattaroli.nicolas@gmail.com> References: <20221025124132.399729-1-frattaroli.nicolas@gmail.com> <20221025124132.399729-5-frattaroli.nicolas@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Dienstag, 25. Oktober 2022 14:41:32 CEST Nicolas Frattaroli wrote: > This adds support for the RK3588 SoC to the I2S/TDM driver. > --- > sound/soc/rockchip/rockchip_i2s_tdm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/rockchip_i2s_tdm.c > index 917f17107891..08b90ec5cc80 100644 > --- a/sound/soc/rockchip/rockchip_i2s_tdm.c > +++ b/sound/soc/rockchip/rockchip_i2s_tdm.c > @@ -1318,6 +1318,7 @@ static const struct of_device_id rockchip_i2s_tdm_match[] = { > { .compatible = "rockchip,rk1808-i2s-tdm", .data = &rk1808_i2s_soc_data }, > { .compatible = "rockchip,rk3308-i2s-tdm", .data = &rk3308_i2s_soc_data }, > { .compatible = "rockchip,rk3568-i2s-tdm", .data = &rk3568_i2s_soc_data }, > + { .compatible = "rockchip,rk3588-i2s-tdm" }, > { .compatible = "rockchip,rv1126-i2s-tdm", .data = &rv1126_i2s_soc_data }, > {}, > }; > @@ -1556,7 +1557,7 @@ static int rockchip_i2s_tdm_probe(struct platform_device *pdev) > i2s_tdm->dev = &pdev->dev; > > of_id = of_match_device(rockchip_i2s_tdm_match, &pdev->dev); > - if (!of_id || !of_id->data) > + if (!of_id) > return -EINVAL; > > spin_lock_init(&i2s_tdm->lock); > Oops, forgot the signoff on this one. For this purpose: Signed-off-by: Nicolas Frattaroli My apologies.