All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
To: Shuotao Xu <shuotaoxu@microsoft.com>
Cc: "Mukul.Joshi@amd.com" <Mukul.Joshi@amd.com>,
	"Kuehling, Felix" <Felix.Kuehling@amd.com>,
	Peng Cheng <pengc@microsoft.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	Lei Qu <Lei.Qu@microsoft.com>, Ran Shu <Ran.Shu@microsoft.com>,
	Ziyue Yang <Ziyue.Yang@microsoft.com>
Subject: Re: [EXTERNAL] [PATCH 2/2] drm/amdkfd: Add PCIe Hotplug Support for AMDKFD
Date: Wed, 20 Apr 2022 11:44:03 -0400	[thread overview]
Message-ID: <34789d77-b8ee-1e4f-c5c2-f32f42f923dc@amd.com> (raw)
In-Reply-To: <549246A3-B326-47CC-92FD-608708E1876B@microsoft.com>

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

The only one in Radeon 7 I see is the same sysfs crash we already fixed 
so you can use the same fix. The MI 200 issue i haven't seen yet but I 
also haven't tested MI200 so never saw it before. Need to test when i 
get the time.

So try that fix with Radeon 7 again to see if you pass the tests (the 
warnings should all be minor issues).

Andrey


On 2022-04-20 05:24, Shuotao Xu wrote:
>>
>> That a problem, latest working baseline I tested and confirmed 
>> passing hotplug tests is this branch and commit 
>> https://gitlab.freedesktop.org/agd5f/linux/-/commit/86e12a53b73135806e101142e72f3f1c0e6fa8e6 
>> which is amd-staging-drm-next. 5.14 was the branch we ups-reamed the 
>> hotplug code but it had a lot of regressions over time due to new 
>> changes (that why I added the hotplug test to try and catch them 
>> early). It would be best to run this branch on mi-100 so we have a 
>> clean baseline and only after confirming  this particular branch from 
>> this commits passes libdrm tests only then start adding the KFD 
>> specific addons. Another option if you can't work with MI-100 and 
>> this branch is to try a different ASIC that does work with this 
>> branch (if possible).
>>
>> Andrey
>>
> OK I tried both this commit and the HEAD of and-staging-drm-next on 
> two GPUs( MI100 and Radeon VII) both did not pass hotplugout libdrm 
> test. I might be able to gain access to MI200, but I suspect it would 
> work.
>
> I copied the complete dmesgs as follows. I highlighted the OOPSES for you.
>
> Radeon VII:

[-- Attachment #2: Type: text/html, Size: 3373 bytes --]

  reply	other threads:[~2022-04-20 15:44 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  8:45 [PATCH 1/2] drm/amdkfd: Cleanup IO links during KFD device removal Shuotao Xu
2022-04-08  8:45 ` [PATCH 2/2] drm/amdkfd: Add PCIe Hotplug Support for AMDKFD Shuotao Xu
2022-04-08 15:28   ` Andrey Grodzovsky
2022-04-09  1:28     ` [EXTERNAL] " Shuotao Xu
2022-04-11 15:52       ` Andrey Grodzovsky
2022-04-13 16:03         ` Shuotao Xu
2022-04-13 17:31           ` Andrey Grodzovsky
2022-04-14 14:00             ` Shuotao Xu
2022-04-14 14:24               ` Shuotao Xu
2022-04-14 15:13               ` Andrey Grodzovsky
2022-04-15 10:12                 ` Shuotao Xu
2022-04-15 16:43                   ` Andrey Grodzovsky
2022-04-18 13:22                     ` Shuotao Xu
2022-04-18 15:23                       ` Andrey Grodzovsky
2022-04-19  7:41                         ` Shuotao Xu
2022-04-19 16:01                           ` Andrey Grodzovsky
2022-04-19 16:18                             ` Felix Kuehling
2022-04-20  9:24                             ` Shuotao Xu
2022-04-20 15:44                               ` Andrey Grodzovsky [this message]
2022-04-20 18:41                                 ` Andrey Grodzovsky
2022-04-27  9:20                                   ` Shuotao Xu
2022-04-27 16:04                                     ` Andrey Grodzovsky
2022-05-10 11:03                                       ` Shuotao Xu
2022-05-10 16:34                                         ` Andrey Grodzovsky
2022-05-10 20:31                                         ` Felix Kuehling
2022-05-11  3:35                                           ` Shuotao Xu
2022-05-11 13:49                                             ` Andrey Grodzovsky
2022-05-11 16:49                                               ` Felix Kuehling
2022-05-11 17:02                                                 ` Andrey Grodzovsky
2022-04-12  0:07 ` [PATCH 1/2] drm/amdkfd: Cleanup IO links during KFD device removal Felix Kuehling
2022-04-12  1:38   ` [EXTERNAL] " Shuotao Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34789d77-b8ee-1e4f-c5c2-f32f42f923dc@amd.com \
    --to=andrey.grodzovsky@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=Lei.Qu@microsoft.com \
    --cc=Mukul.Joshi@amd.com \
    --cc=Ran.Shu@microsoft.com \
    --cc=Ziyue.Yang@microsoft.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=pengc@microsoft.com \
    --cc=shuotaoxu@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.