All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] btrfs-progs: ctree.h: Deprecate unused limit flags
@ 2018-11-13  6:09 Qu Wenruo
  2018-11-13  6:09 ` [PATCH 2/2] btrfs-progs: gitignore: Ignore compressed man pages Qu Wenruo
  2018-11-13  9:53 ` [PATCH 1/2] btrfs-progs: ctree.h: Deprecate unused limit flags Nikolay Borisov
  0 siblings, 2 replies; 4+ messages in thread
From: Qu Wenruo @ 2018-11-13  6:09 UTC (permalink / raw)
  To: linux-btrfs

BTRFS_QGROUP_LIMIT_RSV_RFER/EXCL are never used by btrfs-progs.
And kernel only do the basic assignment but don't really make use of
them.

So deprecate these two flags in btrfs-progs.
Also, add some comment for all the used flags.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 ctree.h              | 12 ++++++------
 libbtrfsutil/btrfs.h | 12 ++++++------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/ctree.h b/ctree.h
index 5d9ba3c555f1..1bbc5a2e9dee 100644
--- a/ctree.h
+++ b/ctree.h
@@ -1038,12 +1038,12 @@ struct btrfs_qgroup_info_item {
 } __attribute__ ((__packed__));
 
 /* flags definition for qgroup limits */
-#define BTRFS_QGROUP_LIMIT_MAX_RFER	(1ULL << 0)
-#define BTRFS_QGROUP_LIMIT_MAX_EXCL	(1ULL << 1)
-#define BTRFS_QGROUP_LIMIT_RSV_RFER	(1ULL << 2)
-#define BTRFS_QGROUP_LIMIT_RSV_EXCL	(1ULL << 3)
-#define BTRFS_QGROUP_LIMIT_RFER_CMPR	(1ULL << 4)
-#define BTRFS_QGROUP_LIMIT_EXCL_CMPR	(1ULL << 5)
+#define BTRFS_QGROUP_LIMIT_MAX_RFER	(1ULL << 0) /* reference (rfer) limit */
+#define BTRFS_QGROUP_LIMIT_MAX_EXCL	(1ULL << 1) /* exclusive (excl) limit */
+#define __BTRFS_QGROUP_LIMIT_RSV_RFER	(1ULL << 2) /* deprecated */
+#define __BTRFS_QGROUP_LIMIT_RSV_EXCL	(1ULL << 3) /* deprecated */
+#define BTRFS_QGROUP_LIMIT_RFER_CMPR	(1ULL << 4) /* compressed rfer limit */
+#define BTRFS_QGROUP_LIMIT_EXCL_CMPR	(1ULL << 5) /* compressed excl limit */
 
 struct btrfs_qgroup_limit_item {
 	__le64 flags;
diff --git a/libbtrfsutil/btrfs.h b/libbtrfsutil/btrfs.h
index 1893c5a2172e..4e58a3cd167b 100644
--- a/libbtrfsutil/btrfs.h
+++ b/libbtrfsutil/btrfs.h
@@ -54,12 +54,12 @@ struct btrfs_ioctl_vol_args {
  * struct btrfs_qgroup_limit.flags
  * struct btrfs_qgroup_limit_item.flags
  */
-#define BTRFS_QGROUP_LIMIT_MAX_RFER	(1ULL << 0)
-#define BTRFS_QGROUP_LIMIT_MAX_EXCL	(1ULL << 1)
-#define BTRFS_QGROUP_LIMIT_RSV_RFER	(1ULL << 2)
-#define BTRFS_QGROUP_LIMIT_RSV_EXCL	(1ULL << 3)
-#define BTRFS_QGROUP_LIMIT_RFER_CMPR	(1ULL << 4)
-#define BTRFS_QGROUP_LIMIT_EXCL_CMPR	(1ULL << 5)
+#define BTRFS_QGROUP_LIMIT_MAX_RFER	(1ULL << 0) /* reference (rfer) limit */
+#define BTRFS_QGROUP_LIMIT_MAX_EXCL	(1ULL << 1) /* exclusive (excl) limit */
+#define __BTRFS_QGROUP_LIMIT_RSV_RFER	(1ULL << 2) /* deprecated */
+#define __BTRFS_QGROUP_LIMIT_RSV_EXCL	(1ULL << 3) /* deprecated */
+#define BTRFS_QGROUP_LIMIT_RFER_CMPR	(1ULL << 4) /* compressed rfer limit */
+#define BTRFS_QGROUP_LIMIT_EXCL_CMPR	(1ULL << 5) /* compressed excl limit */
 
 struct btrfs_qgroup_limit {
 	__u64	flags;
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 2/2] btrfs-progs: gitignore: Ignore compressed man pages
  2018-11-13  6:09 [PATCH 1/2] btrfs-progs: ctree.h: Deprecate unused limit flags Qu Wenruo
@ 2018-11-13  6:09 ` Qu Wenruo
  2018-11-13  6:57   ` Qu Wenruo
  2018-11-13  9:53 ` [PATCH 1/2] btrfs-progs: ctree.h: Deprecate unused limit flags Nikolay Borisov
  1 sibling, 1 reply; 4+ messages in thread
From: Qu Wenruo @ 2018-11-13  6:09 UTC (permalink / raw)
  To: linux-btrfs

Just to Make "git status" more clean.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 82620f3cf603..ae4dce545a7b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -67,6 +67,7 @@
 
 /Documentation/Makefile
 /Documentation/*.html
+/Documentation/*.gz
 /Documentation/btrfs-balance.8
 /Documentation/btrfs-check.8
 /Documentation/btrfs-convert.8
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] btrfs-progs: gitignore: Ignore compressed man pages
  2018-11-13  6:09 ` [PATCH 2/2] btrfs-progs: gitignore: Ignore compressed man pages Qu Wenruo
@ 2018-11-13  6:57   ` Qu Wenruo
  0 siblings, 0 replies; 4+ messages in thread
From: Qu Wenruo @ 2018-11-13  6:57 UTC (permalink / raw)
  To: Qu Wenruo, linux-btrfs


[-- Attachment #1.1: Type: text/plain, Size: 620 bytes --]



On 2018/11/13 下午2:09, Qu Wenruo wrote:
> Just to Make "git status" more clean.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Please discard this one patch, as now we don't build .gz man pages anymore.

> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 82620f3cf603..ae4dce545a7b 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -67,6 +67,7 @@
>  
>  /Documentation/Makefile
>  /Documentation/*.html
> +/Documentation/*.gz
>  /Documentation/btrfs-balance.8
>  /Documentation/btrfs-check.8
>  /Documentation/btrfs-convert.8
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] btrfs-progs: ctree.h: Deprecate unused limit flags
  2018-11-13  6:09 [PATCH 1/2] btrfs-progs: ctree.h: Deprecate unused limit flags Qu Wenruo
  2018-11-13  6:09 ` [PATCH 2/2] btrfs-progs: gitignore: Ignore compressed man pages Qu Wenruo
@ 2018-11-13  9:53 ` Nikolay Borisov
  1 sibling, 0 replies; 4+ messages in thread
From: Nikolay Borisov @ 2018-11-13  9:53 UTC (permalink / raw)
  To: Qu Wenruo, linux-btrfs



On 13.11.18 г. 8:09 ч., Qu Wenruo wrote:
> BTRFS_QGROUP_LIMIT_RSV_RFER/EXCL are never used by btrfs-progs.
> And kernel only do the basic assignment but don't really make use of
> them.
> 
> So deprecate these two flags in btrfs-progs.
> Also, add some comment for all the used flags.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
>  ctree.h              | 12 ++++++------
>  libbtrfsutil/btrfs.h | 12 ++++++------
>  2 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/ctree.h b/ctree.h
> index 5d9ba3c555f1..1bbc5a2e9dee 100644
> --- a/ctree.h
> +++ b/ctree.h
> @@ -1038,12 +1038,12 @@ struct btrfs_qgroup_info_item {
>  } __attribute__ ((__packed__));
>  
>  /* flags definition for qgroup limits */
> -#define BTRFS_QGROUP_LIMIT_MAX_RFER	(1ULL << 0)
> -#define BTRFS_QGROUP_LIMIT_MAX_EXCL	(1ULL << 1)
> -#define BTRFS_QGROUP_LIMIT_RSV_RFER	(1ULL << 2)
> -#define BTRFS_QGROUP_LIMIT_RSV_EXCL	(1ULL << 3)
> -#define BTRFS_QGROUP_LIMIT_RFER_CMPR	(1ULL << 4)
> -#define BTRFS_QGROUP_LIMIT_EXCL_CMPR	(1ULL << 5)
> +#define BTRFS_QGROUP_LIMIT_MAX_RFER	(1ULL << 0) /* reference (rfer) limit */
> +#define BTRFS_QGROUP_LIMIT_MAX_EXCL	(1ULL << 1) /* exclusive (excl) limit */
> +#define __BTRFS_QGROUP_LIMIT_RSV_RFER	(1ULL << 2) /* deprecated */
> +#define __BTRFS_QGROUP_LIMIT_RSV_EXCL	(1ULL << 3) /* deprecated */
> +#define BTRFS_QGROUP_LIMIT_RFER_CMPR	(1ULL << 4) /* compressed rfer limit */
> +#define BTRFS_QGROUP_LIMIT_EXCL_CMPR	(1ULL << 5) /* compressed excl limit */
>  
>  struct btrfs_qgroup_limit_item {
>  	__le64 flags;
> diff --git a/libbtrfsutil/btrfs.h b/libbtrfsutil/btrfs.h
> index 1893c5a2172e..4e58a3cd167b 100644
> --- a/libbtrfsutil/btrfs.h
> +++ b/libbtrfsutil/btrfs.h
> @@ -54,12 +54,12 @@ struct btrfs_ioctl_vol_args {
>   * struct btrfs_qgroup_limit.flags
>   * struct btrfs_qgroup_limit_item.flags
>   */
> -#define BTRFS_QGROUP_LIMIT_MAX_RFER	(1ULL << 0)
> -#define BTRFS_QGROUP_LIMIT_MAX_EXCL	(1ULL << 1)
> -#define BTRFS_QGROUP_LIMIT_RSV_RFER	(1ULL << 2)
> -#define BTRFS_QGROUP_LIMIT_RSV_EXCL	(1ULL << 3)
> -#define BTRFS_QGROUP_LIMIT_RFER_CMPR	(1ULL << 4)
> -#define BTRFS_QGROUP_LIMIT_EXCL_CMPR	(1ULL << 5)
> +#define BTRFS_QGROUP_LIMIT_MAX_RFER	(1ULL << 0) /* reference (rfer) limit */
> +#define BTRFS_QGROUP_LIMIT_MAX_EXCL	(1ULL << 1) /* exclusive (excl) limit */
> +#define __BTRFS_QGROUP_LIMIT_RSV_RFER	(1ULL << 2) /* deprecated */
> +#define __BTRFS_QGROUP_LIMIT_RSV_EXCL	(1ULL << 3) /* deprecated */

Same feedback as the kernel counterpart - just put the /* deprecated */
comment, let the kernel warning settle for a few releases (removing it
in the next one might be a bit optimistic) and then just remove it.

> +#define BTRFS_QGROUP_LIMIT_RFER_CMPR	(1ULL << 4) /* compressed rfer limit */
> +#define BTRFS_QGROUP_LIMIT_EXCL_CMPR	(1ULL << 5) /* compressed excl limit */
>  
>  struct btrfs_qgroup_limit {
>  	__u64	flags;
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-13  9:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-13  6:09 [PATCH 1/2] btrfs-progs: ctree.h: Deprecate unused limit flags Qu Wenruo
2018-11-13  6:09 ` [PATCH 2/2] btrfs-progs: gitignore: Ignore compressed man pages Qu Wenruo
2018-11-13  6:57   ` Qu Wenruo
2018-11-13  9:53 ` [PATCH 1/2] btrfs-progs: ctree.h: Deprecate unused limit flags Nikolay Borisov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.