From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v4 07/41] bus/dpaa: enable DPAA IOCTL portal
	driver
Date: Tue, 19 Sep 2017 19:47:18 +0530
Message-ID: <34825c0c-3d08-624e-d6a6-97846d4db4db@nxp.com>
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-8-shreyansh.jain@nxp.com>
 <144b891a-5457-5a3e-5c0d-33ef02cccc07@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0066.outbound.protection.outlook.com [104.47.32.66])
 by dpdk.org (Postfix) with ESMTP id AA2771B1A8
 for <dev@dpdk.org>; Tue, 19 Sep 2017 16:06:24 +0200 (CEST)
In-Reply-To: <144b891a-5457-5a3e-5c0d-33ef02cccc07@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Monday 18 September 2017 08:21 PM, Ferruh Yigit wrote:
> On 9/9/2017 12:20 PM, Shreyansh Jain wrote:
>> Userspace applications interact with DPAA blocks using this IOCTL driver.
>>
>> Signed-off-by: Geoff Thorpe <geoff.thorpe@nxp.com>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> 
> <...>
> 
>> +static int fd = -1;
>> +static pthread_mutex_t fd_init_lock = PTHREAD_MUTEX_INITIALIZER;
>> +
>> +static int check_fd(void)
>> +{
>> +	int ret;
>> +
>> +	if (fd >= 0)
>> +		return 0;
>> +	ret = pthread_mutex_lock(&fd_init_lock);
> 
> Do you need to link against pthred library for this":
> LDLIBS += -lpthread

We are already doing that in driver/bus/dpaa/Makefile.
Only issue is that I have introduced that two patches from this.
I will fix this.

> 
> <...>
> 
>> +/* The process device underlies process-wide user/kernel interactions, such as
>> + * mapping dma_mem memory and providing accompanying ioctl()s. (This isn't used
>> + * for portals, which use one UIO device each.).
>> + */
>> +#define PROCESS_PATH		"/dev/fsl-usdpaa"
> 
> Who is creating this file, who is responsible to responding ioctl()
> calls, there must a kernel module, right?

This is provided by Userspace DPAA (usdpaa) drivers in the QorIQ kernel. 
This is currently part of the NXP SDK 
(https://lsdk.github.io/components.html) for DPAA boards. 
(https://github.com/qoriq-open-source/linux). We are still in process of 
pushing it to upstream.

So, assumption is that DPAA DPDK driver will only work with this SDK 
until the Linux Kernel upstreaming completes. I guess I had documented 
this in dpaa.rst but if not, I will explicitly add this.

> 
> <...>
>