From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [PATCH] drivers: advertise kmod dependencies in
	pmdinfo
Date: Fri, 16 Sep 2016 09:49:22 +0000
Message-ID: <348A99DA5F5B7549AA880327E580B435890B8716@IRSMSX101.ger.corp.intel.com>
References: <1472217646-26219-1-git-send-email-olivier.matz@6wind.com>
 <1473949355-6787-1-git-send-email-olivier.matz@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>, "vido@cesnet.cz"
 <vido@cesnet.cz>, "stephen@networkplumber.org" <stephen@networkplumber.org>,
 "Trahe, Fiona" <fiona.trahe@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 55C0F58F3
 for <dev@dpdk.org>; Fri, 16 Sep 2016 11:49:29 +0200 (CEST)
In-Reply-To: <1473949355-6787-1-git-send-email-olivier.matz@6wind.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Oliver,

> -----Original Message-----
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> Sent: Thursday, September 15, 2016 3:23 PM
> To: dev@dpdk.org; nhorman@tuxdriver.com
> Cc: thomas.monjalon@6wind.com; vido@cesnet.cz; Trahe, Fiona
> <fiona.trahe@intel.com>; stephen@networkplumber.org
> Subject: [PATCH] drivers: advertise kmod dependencies in pmdinfo
>=20
> Add a new macro DRIVER_REGISTER_KMOD_DEP() that allows a driver to
> declare the list of kernel modules required to run properly.
>=20
> Today, most PCI drivers require uio/vfio.
>=20
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>=20
> rfc -> v1:
> - the kmod information can be per-device using a modalias-like
>   pattern
> - change syntax to use '&' and '|' instead of ',' and ':'
> - remove useless prerequisites in kmod lis: no need to
>   specify both uio and uio_pci_generic, only the latter is
>   required
> - update kmod list in szedata2 driver
> - remove kmod list in qat driver: it requires more than just loading
>   a kmod, which is described in documentation
>=20
The per-device info is a nice addition to this feature.=20
Though for the reasons already described the qat driver dependencies are be=
tter=20
handled through documentation and scripts.

Acked-by: Fiona Trahe <fiona.trahe@intel.com>