From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Trahe, Fiona" Subject: Re: [PATCH v2 1/2] drivers: add common folder Date: Tue, 20 Mar 2018 19:25:11 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358935DB6B@IRSMSX101.ger.corp.intel.com> References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com> <20180320160624.GB18022@ltp-pvn> <20180320170120.GA4260@bricha3-MOBL.ger.corp.intel.com> <2404641.e51pahgxmm@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "santosh.shukla@caviumnetworks.com" , "Burakov, Anatoly" , "lironh@marvell.com" , "shreyansh.jain@nxp.com" , "hemant.agrawal@nxp.com" , "dev@dpdk.org" , "Trahe, Fiona" To: Thomas Monjalon , "Richardson, Bruce" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 36A034C8F for ; Tue, 20 Mar 2018 20:25:15 +0100 (CET) In-Reply-To: <2404641.e51pahgxmm@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, March 20, 2018 5:28 PM > To: Richardson, Bruce > Cc: Pavan Nikhilesh ; jerin.jacob@cavium= networks.com; > santosh.shukla@caviumnetworks.com; Burakov, Anatoly ; > lironh@marvell.com; Trahe, Fiona ; shreyansh.jain@= nxp.com; > hemant.agrawal@nxp.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder >=20 > 20/03/2018 18:01, Bruce Richardson: > > On Tue, Mar 20, 2018 at 09:36:25PM +0530, Pavan Nikhilesh wrote: > > > Hi Thomas, > > > > > > On Tue, Mar 20, 2018 at 04:45:47PM +0100, Thomas Monjalon wrote: > > > > 20/03/2018 15:40, Pavan Nikhilesh: > > > > > Add driver/common folder and skeleton makefile for adding commonl= y > > > > > used functions across mempool, event and net devices. > > > > > > > > I am not sure there is a real benefit of introducing such new > > > > directory. Is it only solving the choice of where you add files us= ed > > > > by several drivers? Is drivers/bus/X/ the directory of choice for > > > > platform shared files? > > > > > > drivers/bus doesn't seem to be a appropriate abstraction common API's > > > used across multiple PMD's. > > > > > > This change is in regards with the discussion on ml: > > > http://dpdk.org/ml/archives/dev/2018-March/092822.html > > > > > > drivers/common seems to be a popular opinion but maybe we could use > > > something like drivers/SoC or if you have something in mind please > > > suggest. > > > > > I think drivers/common is a better solution as it's not just platform b= uses > > or SoC's that this occurs with. Even PCI devices can export multiple > > functions, such as in the QAT case, which leads to the case where you h= ave > > shared code between different driver classes. I don't think the PCI bus > > driver is a good place to put QAT shared code. :-) >=20 > If drivers X and Y share some code, it is possible to link files from > X directory in Y library. >=20 > If we want a more explicit and separate directory for shared code, > what would be the name of the sub-directories? > drivers/common/qat? > drivers/common/octeontx? > drivers/common/marvell? > drivers/common/mellanox? >=20 [Fiona] Yes. We plan to add drivers/common/qat.