From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Trahe, Fiona" Subject: Re: [PATCH] compressdev: implement API Date: Fri, 23 Mar 2018 18:08:49 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43589360349@IRSMSX101.ger.corp.intel.com> References: <1517595924-25963-1-git-send-email-fiona.trahe@intel.com> <1997769.o2qW9LT7Ur@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "ahmed.mansour@nxp.com" , "Shally.Verma@cavium.com" , "De Lara Guarch, Pablo" , "fiona.trahe@gmail.com" To: Thomas Monjalon Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id C4A3EA494 for ; Fri, 23 Mar 2018 19:08:53 +0100 (CET) In-Reply-To: <1997769.o2qW9LT7Ur@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Tomas, Sorry for the delay in replying to this > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Sunday, February 4, 2018 2:25 PM > To: Trahe, Fiona > Cc: dev@dpdk.org; ahmed.mansour@nxp.com; Shally.Verma@cavium.com; De Lara= Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API >=20 > 02/02/2018 19:25, Fiona Trahe: > > config/common_base | 6 + > > doc/api/doxy-api-index.md | 1 + > > doc/api/doxy-api.conf | 1 + > > lib/Makefile | 3 + > > lib/librte_compressdev/Makefile | 29 + > > lib/librte_compressdev/rte_comp.h | 503 ++++++++++++ >=20 > Why rte_comp.h instead of the more consistent rte_compress.h? [Fiona] I did originally... but ran into difficulty with horribly names li= ke RTE_COMPRESS_COMPRESS RTE_COMPRESS_DECOMPRESS rte_compress_compress_xform rte_compress_decompress_xform So compress is both the module prefix and the name of one of the actions. I could have used compressdev - but names were very long. So decided to opt for using=20 _compressdev_ in names to do with the device and _comp_ in names to do with the compression service Also I could have used compdev instead of compressdev,=20 but I felt compress should be in the lib name >=20 > > lib/librte_compressdev/rte_compressdev.c | 902 +++++++++++++= ++++++++ > > lib/librte_compressdev/rte_compressdev.h | 757 +++++++++++++= ++++ > > lib/librte_compressdev/rte_compressdev_pmd.c | 163 ++++ > > lib/librte_compressdev/rte_compressdev_pmd.h | 439 ++++++++++ > > lib/librte_compressdev/rte_compressdev_version.map | 47 ++ > > lib/librte_eal/common/include/rte_log.h | 1 + > > mk/rte.app.mk | 1 + > > 13 files changed, 2853 insertions(+) >=20 > Please update MAINTAINERS file and release notes. >=20 > Maybe it is worth splitting this patch in few shorter parts? [Fiona] will do >=20 >=20 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -535,6 +535,12 @@ CONFIG_RTE_LIBRTE_PMD_MRVL_CRYPTO=3Dn > > CONFIG_RTE_LIBRTE_PMD_MRVL_CRYPTO_DEBUG=3Dn > > > > # > > +# Compile generic compression device library > > +# > > +CONFIG_RTE_LIBRTE_COMPRESSDEV=3Dy > > +CONFIG_RTE_COMPRESS_MAX_DEVS=3D64 > > + > > +# > > # Compile generic security library > > # > > CONFIG_RTE_LIBRTE_SECURITY=3Dy > > diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md > > index d77f205..07b8e75 100644 > > --- a/doc/api/doxy-api-index.md > > +++ b/doc/api/doxy-api-index.md > > @@ -43,6 +43,7 @@ The public API headers are grouped by topics: > > [rte_tm] (@ref rte_tm.h), > > [rte_mtr] (@ref rte_mtr.h), > > [bbdev] (@ref rte_bbdev.h), > > + [compressdev] (@ref rte_compressdev.h), > > [cryptodev] (@ref rte_cryptodev.h), > > [security] (@ref rte_security.h), > > [eventdev] (@ref rte_eventdev.h), >=20 > Please move it between security and eventdev in these lists. ok