From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [PATCH v2 2/6] lib/cryptodev: add asym op support in
	cryptodev
Date: Tue, 8 May 2018 14:43:57 +0000
Message-ID: <348A99DA5F5B7549AA880327E580B4358947CD2B@IRSMSX103.ger.corp.intel.com>
References: <1522927489-23668-1-git-send-email-shally.verma@caviumnetworks.com>
 <1522927489-23668-3-git-send-email-shally.verma@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Doherty, Declan" <declan.doherty@intel.com>,
 "pathreya@caviumnetworks.com" <pathreya@caviumnetworks.com>,
 "ssahu@caviumnetworks.com" <ssahu@caviumnetworks.com>,
 "agupta@caviumnetworks.com" <agupta@caviumnetworks.com>, "dev@dpdk.org"
 <dev@dpdk.org>, Sunila Sahu <sunila.sahu@caviumnetworks.com>, Ashish Gupta
 <ashish.gupta@caviumnetworks.com>
To: Shally Verma <shally.verma@caviumnetworks.com>, "De Lara Guarch, Pablo"
 <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 15BA2AABF
 for <dev@dpdk.org>; Tue,  8 May 2018 16:44:01 +0200 (CEST)
In-Reply-To: <1522927489-23668-3-git-send-email-shally.verma@caviumnetworks.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Shally,


> -----Original Message-----
> From: Shally Verma [mailto:shally.verma@caviumnetworks.com]
> Sent: Thursday, April 5, 2018 12:25 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona <fiona.trahe=
@intel.com>;
> pathreya@caviumnetworks.com; ssahu@caviumnetworks.com; agupta@caviumnetwo=
rks.com;
> dev@dpdk.org; Sunila Sahu <sunila.sahu@caviumnetworks.com>; Ashish Gupta
> <ashish.gupta@caviumnetworks.com>
> Subject: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev
>=20
>  struct rte_cryptodev_sym_session *
>  rte_cryptodev_sym_session_create(struct rte_mempool *mp)
>  {
>  	struct rte_cryptodev_sym_session *sess;
>=20
>  	/* Allocate a session structure from the session pool */
> -	if (rte_mempool_get(mp, (void **)&sess)) {
> +	if (rte_mempool_get(mp, (void *)&sess)) {
[Fiona] Are you introducing a bug here?
The fn expects a void **
Also this will need rebasing - the latest code has an extra byte.