From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [PATCH 2/3] app/compress-perf:
	add	performance	measurement
Date: Wed, 17 Oct 2018 14:33:36 +0000
Message-ID: <348A99DA5F5B7549AA880327E580B4358964F1CB@IRSMSX101.ger.corp.intel.com>
References: <1538400427-20164-1-git-send-email-tomaszx.jozwiak@intel.com>
 <1538400427-20164-3-git-send-email-tomaszx.jozwiak@intel.com>
 <SN6PR07MB5152534B0DA16E2A7BBBA37BF0E20@SN6PR07MB5152.namprd07.prod.outlook.com>
 <F5C6929789601049BEB7272E267355986D167C@IRSMSX106.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Jozwiak, TomaszX" <tomaszx.jozwiak@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "Trahe, Fiona"
 <fiona.trahe@intel.com>
To: "Daly, Lee" <lee.daly@intel.com>, "Verma, Shally" <Shally.Verma@cavium.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 4D8AA7D4E
 for <dev@dpdk.org>; Wed, 17 Oct 2018 16:33:40 +0200 (CEST)
In-Reply-To: <F5C6929789601049BEB7272E267355986D167C@IRSMSX106.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Shally, Lee,

> -----Original Message-----
> From: Daly, Lee
> Sent: Monday, October 15, 2018 8:10 AM
> To: Verma, Shally <Shally.Verma@cavium.com>
> Cc: Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>; dev@dpdk.org; Trahe, Fi=
ona
> <fiona.trahe@intel.com>; akhil.goyal@nxp.com
> Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance me=
asurement
>=20
> Thanks for your input Shally see comments below.
>=20
>=20
> I will be reviewing these changes while Tomasz is out this week.
>=20
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Verma, Shally
> > Sent: Friday, October 12, 2018 11:16 AM
> > To: Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>; dev@dpdk.org; Trahe,
> > Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com; De Lara Guarch, Pab=
lo
> > <pablo.de.lara.guarch@intel.com>
> > Cc: De@dpdk.org; Lara@dpdk.org; Guarch@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance
> > measurement
> >
///

> >Also, why do we need --max-num-
> > sgl-segs as an input option from user? Shouldn't input_sz and seg_sz
> > internally decide on num-segs?
> > Or is it added to serve some other different purpose?
> Will have to get back to you on this one, seems illogical to get this inp=
ut from user,
> But I will have to do further investigation to find if there was a differ=
ent purpose.

[Fiona] Some PMDs have a limit on how many links can be in an sgl chain, e.=
g. in QAT case the=20
PMD allocates a pool of internal structures of a suitable size during devic=
e initialisation, this is not=20
a hard limit but can be configured in .config to give the user control over=
 the memory resources allocated.
This perf-tool max-num-sgl-segs is so the user can pick a value <=3D whatev=
er the PMD's max is.