From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6197EECE58E for ; Thu, 17 Oct 2019 09:27:27 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id E2BBE20869 for ; Thu, 17 Oct 2019 09:27:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2BBE20869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 119621E8EF; Thu, 17 Oct 2019 11:27:26 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 995C61E8E3 for ; Thu, 17 Oct 2019 11:27:24 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2019 02:27:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,307,1566889200"; d="scan'208";a="226100730" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga002.fm.intel.com with ESMTP; 17 Oct 2019 02:27:21 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.76]) by IRSMSX106.ger.corp.intel.com ([169.254.8.185]) with mapi id 14.03.0439.000; Thu, 17 Oct 2019 10:27:20 +0100 From: "Trahe, Fiona" To: Akhil Goyal , "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "Trahe, Fiona" Thread-Topic: [PATCH v2 0/5] Add session-less, RSA, RSA-CRT to QAT Thread-Index: AQHVgBuHoOSPDxg+Vk69VwSsknnrNqdbdAEAgAMlkVA= Date: Thu, 17 Oct 2019 09:27:20 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435A21757A8@IRSMSX101.ger.corp.intel.com> References: <20191011100339.12912-1-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjQwODY2M2YtYzFjZi00MDc3LTk1YjAtYzZhZGZmYjY5ZmU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoia3hJdXZVRE5CSmxFaHJxeFBPb29HQzVKaTRlZUZcL3ZISXdhemFsMUxTRmFBb21LTE5JQkNNbFJNZHNXSW9SSG4ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/5] Add session-less, RSA, RSA-CRT to QAT X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Arek will add RSA signature tests with padding-none option. I will review and ack after this Fiona > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Tuesday, October 15, 2019 11:23 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org; Tra= he, Fiona > > Subject: RE: [PATCH v2 0/5] Add session-less, RSA, RSA-CRT to QAT >=20 > Hi Arek, > > > > This patchset adds session-less option, RSA algorithm, RSA-CRT algorith= m > > to Intel QuickAssist Technology PMD. > > > > This patchset depends on the > > [v5] cryptodev: extend api of asymmetric crypto by session-less [1] > > > > [1] > > http://patchwork.dpdk.org/patch/60882/ > > > Could you please rebase this patch so that compilation can be tested by C= I. > The dependent patch is merged. > Also please update the patch titles as below. >=20 > @fiona.trahe@intel.com: could you please review this series and provide A= ck >=20 > > v2: > > - fixed alg size problem in crt > > - fixed rsa capabilities > > - added rsa test cases > > > > Arek Kusztal (5): > > crypto/qat: add sessionless implementation to asym pmd > crypto/qat: support asymmetric sessionless ops >=20 > > crypto/qat: add rsa implementation to asym pmd > crypto/qat: support RSA > > crypto/qat: add rsa crt implementation to asym pmd > crypto/qat: support RSA CRT > > test/crypto: add sessionless to asymmetric mod exp > test/crypto: support sessionless in asymmetric cases > > test/crypto: add rsa tests to qat > test/crypto: add RSA cases in QAT >=20 > Also please add more meaningful patch description. >=20 > > > > app/test/test_cryptodev_asym.c | 182 ++++-- > > app/test/test_cryptodev_rsa_test_vectors.h | 213 +++++++ > > doc/guides/cryptodevs/features/qat.ini | 4 + > > doc/guides/rel_notes/release_19_11.rst | 8 + > > .../qat/qat_adf/qat_pke_functionality_arrays.h | 27 + > > drivers/crypto/qat/qat_asym.c | 616 +++++++++++++= +++----- > > drivers/crypto/qat/qat_asym.h | 29 +- > > drivers/crypto/qat/qat_asym_capabilities.h | 21 + > > drivers/crypto/qat/qat_asym_pmd.c | 5 +- > > 9 files changed, 925 insertions(+), 180 deletions(-) > > > > -- > > 2.1.0