From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76C86C433EF for ; Wed, 15 Sep 2021 02:16:05 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85AD36113E for ; Wed, 15 Sep 2021 02:16:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 85AD36113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CECA88081B; Wed, 15 Sep 2021 04:16:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="DQ9uNuWR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0B2CF81280; Wed, 15 Sep 2021 04:15:59 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0611.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe05::611]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 638C081A26 for ; Wed, 15 Sep 2021 04:15:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Su6jIvaVN2xZh9y2pEEw/VrFQllt9z1k+g8R5NClx6gKq+INef7WwkSMpy1rjktTfa3qjLJhBqMT28wHeVaPjyNNfuXhgiphw3UQdXxd9o+3Bl3h5thJCQoSVs6DkCOB+u0wD0kU2gRcuOHlUk6kAm7ud5RHlgvq8MaDQnadpiyqAsy+uJpJAgh94QgFIpO6ckIP1dRLodD5przwFbq4iHj4Ca1hE5RvdPiqYsaLw1IShi+dC5+dNAI0XIKJOGFKkEqCWVQuJC1nZV9TmZZzKIzA7NMVg7HVQ/BNmcdaarjs/8sopbZW6WIusEUBGytY6sAK7aUYBeyows38cl/g0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=afp2PPygPFolMzmsvjbYKyWsLlZ49fSOQkt0NE1JgP8=; b=cTwphHhOgdnYx8ZvGZFMkblI3ZcCnzcATjfQtWekhmupJ5MzwS8cce4xckH5lTxcAy8Hq2ckqhKkG8cXj48rANnKiguRAhSDAseusSppjA8wzmhrIFJKeCZ+ckgLH/EiuqFZx5hxtE/bOJSkRWTMZ1Y1nuK5cl804Y4xYSWjuvAtYNAaj3SIKXqw3Tq47ucwFv8LHkoPR36MS5EvncgR1UHnzSloBA4XC9wohuKm4npJeOAy0Q4ZMDoCLfiY8rK1PnQ2BsW2+ESmA1foZH1Y5N31lSKHyxl7lPj5x3WIZkubCGPWPFtyH98RXcZqu0EGaECyey9eWMaQok6rwCqAug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afp2PPygPFolMzmsvjbYKyWsLlZ49fSOQkt0NE1JgP8=; b=DQ9uNuWR8Is3nFQfqk0wK2jB9/H+FXtdA8dXhYxlbZMQBkcCQoIcNE6rS0ytvpatpB9n9kGsugHF0/w3eiwNcODz5GO7tSJ1teXGYCasLg9TICSgk3D3pSx78tbZjdQoitnvaMPMIklbDMpy78AYvtTOUAhiubWhJOthcMhWS1U= Authentication-Results: chromium.org; dkim=none (message not signed) header.d=none;chromium.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB6PR0401MB2374.eurprd04.prod.outlook.com (2603:10a6:4:4c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 15 Sep 2021 02:15:53 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::4868:6843:a39f:aa53]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::4868:6843:a39f:aa53%4]) with mapi id 15.20.4500.018; Wed, 15 Sep 2021 02:15:53 +0000 Subject: Re: [PATCH] apalis/colibri_imx6: move setting bootcmd to defconfig To: Oleksandr Suvorov , u-boot@lists.denx.de Cc: Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Heiko Schocher , Igor Opaniuk , Patrick Delaunay , Simon Glass References: <20210912223903.1.4857bf4fef106f3725701315a22f2ff4b05af12a@changeid> From: "Peng Fan (OSS)" Message-ID: <34907bf1-8552-b679-c364-a6f2981bb316@oss.nxp.com> Date: Wed, 15 Sep 2021 10:15:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210912223903.1.4857bf4fef106f3725701315a22f2ff4b05af12a@changeid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR06CA0184.apcprd06.prod.outlook.com (2603:1096:4:1::16) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.193.99.168] (119.31.174.71) by SG2PR06CA0184.apcprd06.prod.outlook.com (2603:1096:4:1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 15 Sep 2021 02:15:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 57dc25b0-db3b-4427-74ac-08d977eebe4a X-MS-TrafficTypeDiagnostic: DB6PR0401MB2374: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1284; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c1jatLcFpgtcTvgZwy/kYJsIp5OAM4+/DDiQr+AekiUvGtkD12CC2eiQl43c9cUWr05bl5t0oVG2yfL0Xhi82C+F8Nm/YMsO2EoHDrXjfcA4q1NQXRkS283Bi26RvVLmDzB4cP32OM+5hj3+oGgRHypGTWjHaOiytnPmBbwqBpQxVGXvHOwTM61g7+1JJOJoPzcnXViShWPEp4GoWGOJ7maIO/5Hl3A60Yvpd2pGFH7LqEdOQw0adMb/uuSIxpyGq6JVJ/ocjd2lSlk5Hzi48DywOwN7sSmlaLBX9rTXNGZI0+GwzaI4koJrt8OY+/C3LJWnnlNjw15fvsTiIK9ecS4lwzGoXU/UYc1iIl113T+zIr7lFQSAfKc9Bfv/JI2My7vve1Fai4oexsNNEi6+6jKw4iw5KQjmlpyK4+GqNhubTC7H5XJZR7Ly8rwS5zNp2I66g7id1Z1iNchX/ButMjgrkBtt72cyw6pPlZAgINfm4cwV1vLMXzTOSw7TU6DMkira+lJEPnCUnQiGv+i5dUfUK31s3QVg73S4S/L5PDA6i3sKsozH6rcM50oR3lYqm6unofUyZZJEGp28mG0Td/iZpAy+bu0GxqHoo5kAebA91LPUf/a35LahN8zx104yt82vqnvOEFZDqcKE0vPR4auUOS05CKreINjh2dYFfpR/ZE9h/M0oEXR2EG7tllgr/rUDyaTTyTXOtdsNDbTXCG/nUYWVa/h2UWcyTJ81HW067NXxR13UIJ6gTyiwva+hQqi9UvgXoYTsOtgVKKqYhg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(39860400002)(366004)(136003)(26005)(186003)(52116002)(66556008)(53546011)(2906002)(31696002)(8676002)(66476007)(83380400001)(478600001)(86362001)(8936002)(6666004)(38350700002)(31686004)(38100700002)(6486002)(54906003)(16576012)(66946007)(5660300002)(4326008)(956004)(316002)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWtDUzl3RlE5dFFwUVRQa0l4L2Ruc2dCd090eUJkeTBkdjhHalNUTEdlWjZT?= =?utf-8?B?aTZSWWVOcFMvamVtc2Jxdm51NDZVWEdlMzVTWFplRTBZbzgyVngzSWVKT2lt?= =?utf-8?B?MGtjUlV3SG1EQlI4ZWpaeC8waExJaHZKaE5pZGFYR1ZKcS94Z0hUemxJM1hH?= =?utf-8?B?Zk0zaTBlMUp0TDcrZ21DQ1MzRUlXbTJ1dGwxZE53Vm1VOHdHZ2ZhdHBWTnUy?= =?utf-8?B?WjJSUmZ2MVhRQ3pqZTVnNjFqRmtSQzNwb0NKRHdwdVVadGlNZ3R2Szg2d2lw?= =?utf-8?B?Mm9ON2U0Mlhrdm9GT0JZTDN6L3loWENod3c4S2lDeDRJRVRhNzdVYkZqa1hN?= =?utf-8?B?eG9qREk4MEovRG5NaWlmakxhRDM0cndqSmdyNGlDc2wrQm5ENDlwMFNYYVgy?= =?utf-8?B?aFQycnZpSlgyWlJlbnMwdVF6UHdPSnNuc0M1ZE1Ka2VZeGdZRTlsQUtNQlZB?= =?utf-8?B?NTlzdUFxelNvU1k2a1RRSUZYcXFsMTlaT2hCb0NwLzBpN3pkaEtIRFhxa2dz?= =?utf-8?B?NnoxdHpMTEJ4TmtybWNpeC9KYVVIUmV6NFhxUnZKS1Z0bkF3QmVEdis3NDF6?= =?utf-8?B?WERNZmVsUFlnZlJiRW1sdnVVRkViYXpDa0U0YlNDZjhsdDBVVVc3anQ3QlpF?= =?utf-8?B?M0pTNjM2VC9DMVV3MXJzRDNVQndWeFZmVkNMaEZjbWR6QmVmRlp3eTExdUxT?= =?utf-8?B?c1JhTGdYTHF5S0lZZk05RnZxTkphdjNSRXdubXdodXVaSlV6TTJMT1psWTIx?= =?utf-8?B?anRkMWErRU81czdjdFN4cDBtaHNMaFoxeVlLT051eVo0VHplbG9uUW5qeWtV?= =?utf-8?B?c0taS2dkVkU2Y2RTcVZEdForYlZ2YW9UdXdJdFlTQ3BzaUZoMXhYbUE0cFpm?= =?utf-8?B?a0JpMHNIOTRDRzZTbldNYmtidW1aakdlRC82cEZhVFJmSStzZUJqNEUwV1lj?= =?utf-8?B?eUJ6TnhnNjRVU1hBSjJQNlo5cGhWMWkxYWZBSy9VYm5Xa2tscE1zNW9WbFJH?= =?utf-8?B?WXp5RVd0N2RFRU9KNG4xWURpZllBRVNPNjBHYmE2U3Irc0xrUnhZeGNWSzBJ?= =?utf-8?B?WVpoUzh4ZnVhM01ORVlGeVBaazdDZ2xRZm1vRVFXejNrbm82WDRFcE1JZkF4?= =?utf-8?B?cXFBSEo3UW5CT1FlRHFuMWJUM1VEY2V4NkRUalZ4OTczbDRpeWFsb25DSHJM?= =?utf-8?B?dzFET250ZU8zS3E0ZHc1S25YWTZ2QzFvbVhaaHZZMkF3SlQwR05ERGlIWEpt?= =?utf-8?B?YTBVQ0hadDdqWTV4OVBoeXlOOGprU2pDMlVOaEpZT09mRTZadHRTUkU3ZExT?= =?utf-8?B?R2N5cElaTGdyMi9XanVhT0JpQzBPZGZxSlpTNkJDblpNZkRFUUJ4b1JRT3FP?= =?utf-8?B?em5tNkZYODR0MEFoZFdkSVJ1bXY2ZUplMGZjNmlqUFR0NU1MQ3pMb2VmeGFy?= =?utf-8?B?TCtvdDNPei8vUUFFUU5Ud3phN1kyVDNUY2s5czFVWEtGWFRvMjFDdjVJMHVq?= =?utf-8?B?R1ZJQTNVWWZmdFhEbjdyN0hJdStEM1YwV1IzRHNmWnhyWHY3alh2SjVnOXRM?= =?utf-8?B?UTYxVGJMRlRwZFZWVnBlQ1o1c0JZcVVySFlpdVJkMUJ0S2NqbUh1TFpOUXdE?= =?utf-8?B?ZE1rcFpsZDhMdFFndW9DQ0wySHBNZkJRS1VtR0lyNzkrd2REamxyWXdIZ2l6?= =?utf-8?B?N3NGWFFUb0tScUdueGQ1YkVuMm4rbXFuR21ESmh3d3JYYmxBWFdteXQxdW41?= =?utf-8?B?bXJhMytLcU9MRW9nYzA2d2N0blZtL0xrUWdOK0xSanhQVmhCSHhuaWJqcXRl?= =?utf-8?B?aXNpOU1lakZwQTk5V2tkQT09?= X-MS-Exchange-Transport-Forked: True X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57dc25b0-db3b-4427-74ac-08d977eebe4a X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 02:15:53.2416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BY5/gsWj73nFDx29jOBji3eZB8rfjnWwV3TqbyTYYa6do8eMUz7G/yELxVaf0eM8xbaunqufP551fgl/cLYU6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2374 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 2021/9/13 3:39, Oleksandr Suvorov wrote: > Move setting the default boot command to the > apalis/colibri_imx6_defconfig. It allows replacing the command > without code modification. > > Signed-off-by: Oleksandr Suvorov > --- > > configs/apalis_imx6_defconfig | 1 + > configs/colibri_imx6_defconfig | 1 + > include/configs/apalis_imx6.h | 4 ---- > include/configs/colibri_imx6.h | 4 ---- > 4 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/configs/apalis_imx6_defconfig b/configs/apalis_imx6_defconfig > index a0e85ba23a4..a2e0f8e3936 100644 > --- a/configs/apalis_imx6_defconfig > +++ b/configs/apalis_imx6_defconfig > @@ -23,6 +23,7 @@ CONFIG_DISTRO_DEFAULTS=y > CONFIG_FIT=y > CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" > CONFIG_BOOTDELAY=1 > +CONFIG_BOOTCOMMAND="run distro_bootcmd;usb start;setenv stdout serial,vidconsole;setenv stdin serial,usbkbd" > # CONFIG_DISPLAY_BOARDINFO is not set > CONFIG_DISPLAY_BOARDINFO_LATE=y > CONFIG_BOARD_EARLY_INIT_F=y > diff --git a/configs/colibri_imx6_defconfig b/configs/colibri_imx6_defconfig > index 47b1cfb1917..bee4e7edd63 100644 > --- a/configs/colibri_imx6_defconfig > +++ b/configs/colibri_imx6_defconfig > @@ -22,6 +22,7 @@ CONFIG_DISTRO_DEFAULTS=y > CONFIG_FIT=y > CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" > CONFIG_BOOTDELAY=1 > +CONFIG_BOOTCOMMAND="run distro_bootcmd;usb start;setenv stdout serial,vidconsole;setenv stdin serial,usbkbd" > # CONFIG_DISPLAY_BOARDINFO is not set > CONFIG_DISPLAY_BOARDINFO_LATE=y > CONFIG_BOARD_EARLY_INIT_F=y > diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h > index 12de0105c6c..ade479cb943 100644 > --- a/include/configs/apalis_imx6.h > +++ b/include/configs/apalis_imx6.h > @@ -133,10 +133,6 @@ > #endif > #define CONFIG_EXTRA_ENV_SETTINGS \ > BOOTENV \ > - "bootcmd=run distro_bootcmd ; " \ > - "usb start ; " \ > - "setenv stdout serial,vidconsole; " \ > - "setenv stdin serial,usbkbd\0" \ > "boot_file=zImage\0" \ > "console=ttymxc0\0" \ > "defargs=enable_wait_mode=off vmalloc=400M\0" \ > diff --git a/include/configs/colibri_imx6.h b/include/configs/colibri_imx6.h > index 804a144a03e..f91d6b49ea8 100644 > --- a/include/configs/colibri_imx6.h > +++ b/include/configs/colibri_imx6.h > @@ -115,10 +115,6 @@ > #define FDT_FILE "imx6dl-colibri-eval-v3.dtb" > #define CONFIG_EXTRA_ENV_SETTINGS \ > BOOTENV \ > - "bootcmd=run distro_bootcmd; " \ > - "usb start ; " \ > - "setenv stdout serial,vidconsole; " \ > - "setenv stdin serial,usbkbd\0" \ > "boot_file=zImage\0" \ > "console=ttymxc0\0" \ > "defargs=enable_wait_mode=off galcore.contiguousSize=50331648\0" \ > Reviewed-by: Peng Fan