From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944AbcGUTzx (ORCPT ); Thu, 21 Jul 2016 15:55:53 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:62757 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077AbcGUTzv (ORCPT ); Thu, 21 Jul 2016 15:55:51 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Paul Gortmaker , gabriel.fernandez@st.com, Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , LKML , patrice.chotard@st.com, Russell King , Rob Herring , Maxime Coquelin , alexandre.torgue@st.com Subject: Re: [PATCH v2 3/4] drivers: reset: Add STM32 reset driver Date: Thu, 21 Jul 2016 21:55:01 +0200 Message-ID: <34955897.5sjo821nJx@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1469092768-17489-1-git-send-email-gabriel.fernandez@st.com> <1469092768-17489-4-git-send-email-gabriel.fernandez@st.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:WnvfqByO89yL4UxxyOkBYG1rxnZL59z5jvTNcv84RLA8AebiYNb e4gG1jXc+R2FSKeIsDijiuM/y5g7WnmW39UXtvNmRzFjC7m/PBENSy3MgwiPDURHqWTohBa sqPeBb4OSFUDHmo60QxTRdMkhgAiUht1+LZuU+E1vnUiUaQNjB/i0D/ZKS3e2etRdkYW9Dr ikPwtEyWccAXH8qQ8XyeA== X-UI-Out-Filterresults: notjunk:1;V01:K0:qK5IEi3Ytf4=:CFQfZaKrNYz3zFDVPTe7zG 8xAH4NIGokcZCkU/GdQ41MqfBMZEFp5T4X/QstiHG45HdeblQ53UzjZHj/iwR58MdIkTXhISj c71OsXinluhKkBBZIXENv+D4fK+lQCIKiyz30zUlCYFCDYGba59ntB8G5OQGgilWvPpzoiDyY +3tZVg2RThb5PExc2VNlO5oDwKIGdgCtnXpmFT1zWy83CT5DIaZ/pKilMCuImcpD6+Ty2yoTT idnRbTcpK4pnU2OSY6Dx2jYD3Wfq+W+DZOYGT2/aaJqzesLUZgP/WoFG6OljGWjvfE9GgY1Lo ZEK1Ohf9aYMFXVGCsBH4QhU4cz42HC5Z1gH9lPCU4KG6EspGfqCKLDpD9U5UaeEn+Tuy2tf7T 1vcooTOsoN5y12aym1qkGsNuHvWRtcb0BmYzh2V3Se0hvV/QkVtGFLuO7lW9FTJ28EDPq8uBA 8lv8y+gJenMgOLe7m0P9B4NQLfhqL5XMjaOThh6Fvh69MdQUm0r+zKpOMwWd0ksXhhU+VWCTr VdzQIxD92htrG5loCaoh2L8sVkU0TF2B2J+qBwAeR4gUohaj5hOTTLVzrw4GG5eIGQyvhi2vC nP0NCNKCg8DleF4TqCEkw9fsL3cFuah+22T0bkEV0AtxAD+ONSkZK43dSpWDfKp/yFUNFKaip hAJvuOXVC5LfF7k4sQKEGAP8Ly8SfF70NCAFNAF5dmQ79wHCnZjnx4xV4PDk2vb6ETmyMHdZH 7dMdg1d+l73YRY+A Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, July 21, 2016 3:48:09 PM CEST Paul Gortmaker wrote: > > diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile > > index 5d65a93..64ebb0c 100644 > > --- a/drivers/reset/Makefile > > +++ b/drivers/reset/Makefile > > @@ -4,6 +4,7 @@ obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o > > obj-$(CONFIG_ARCH_BERLIN) += reset-berlin.o > > obj-$(CONFIG_MACH_PISTACHIO) += reset-pistachio.o > > obj-$(CONFIG_ARCH_MESON) += reset-meson.o > > +obj-$(CONFIG_ARCH_STM32) += reset-stm32.o > > In my tree, this Kconfig ARCH_STM32 is a bool, so... > > > obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o > > obj-$(CONFIG_ARCH_STI) += sti/ > > obj-$(CONFIG_ARCH_HISI) += hisilicon/ > > diff --git a/drivers/reset/reset-stm32.c b/drivers/reset/reset-stm32.c > > new file mode 100644 > > index 0000000..993af2a > > --- /dev/null > > +++ b/drivers/reset/reset-stm32.c > > @@ -0,0 +1,113 @@ > > +/* > > + * Copyright (C) Maxime Coquelin 2015 > > + * Author: Maxime Coquelin _ > > + * License terms: GNU General Public License (GPL), version 2 > > + * > > + * Heavily based on sunxi driver from Maxime Ripard. > > + */ > > + > > +#include > > +#include > > +#include > > ...we probably don't need module.h here or any of the other > MODULE_ tags/macros either. Use the builtin for the > register and all should be good. I wonder if we should have separate symbols for each reset driver instead. Those could be allowed to be tristate, and could also be enabled for compile testing on other architectures. I actually made a patch for that a while ago, to simplify the dependencies around reset drivers. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 21 Jul 2016 21:55:01 +0200 Subject: [PATCH v2 3/4] drivers: reset: Add STM32 reset driver In-Reply-To: References: <1469092768-17489-1-git-send-email-gabriel.fernandez@st.com> <1469092768-17489-4-git-send-email-gabriel.fernandez@st.com> Message-ID: <34955897.5sjo821nJx@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday, July 21, 2016 3:48:09 PM CEST Paul Gortmaker wrote: > > diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile > > index 5d65a93..64ebb0c 100644 > > --- a/drivers/reset/Makefile > > +++ b/drivers/reset/Makefile > > @@ -4,6 +4,7 @@ obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o > > obj-$(CONFIG_ARCH_BERLIN) += reset-berlin.o > > obj-$(CONFIG_MACH_PISTACHIO) += reset-pistachio.o > > obj-$(CONFIG_ARCH_MESON) += reset-meson.o > > +obj-$(CONFIG_ARCH_STM32) += reset-stm32.o > > In my tree, this Kconfig ARCH_STM32 is a bool, so... > > > obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o > > obj-$(CONFIG_ARCH_STI) += sti/ > > obj-$(CONFIG_ARCH_HISI) += hisilicon/ > > diff --git a/drivers/reset/reset-stm32.c b/drivers/reset/reset-stm32.c > > new file mode 100644 > > index 0000000..993af2a > > --- /dev/null > > +++ b/drivers/reset/reset-stm32.c > > @@ -0,0 +1,113 @@ > > +/* > > + * Copyright (C) Maxime Coquelin 2015 > > + * Author: Maxime Coquelin _ > > + * License terms: GNU General Public License (GPL), version 2 > > + * > > + * Heavily based on sunxi driver from Maxime Ripard. > > + */ > > + > > +#include > > +#include > > +#include > > ...we probably don't need module.h here or any of the other > MODULE_ tags/macros either. Use the builtin for the > register and all should be good. I wonder if we should have separate symbols for each reset driver instead. Those could be allowed to be tristate, and could also be enabled for compile testing on other architectures. I actually made a patch for that a while ago, to simplify the dependencies around reset drivers. Arnd