From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C13FCC433F5 for ; Mon, 18 Oct 2021 11:59:10 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEB9F60F59 for ; Mon, 18 Oct 2021 11:59:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CEB9F60F59 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 37CBA833F4; Mon, 18 Oct 2021 13:59:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634558348; bh=6R5yHIwtgQ1tW+sum1TM0wcoOc3dRYZV778/m7diaDI=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JTJF1raxvwxf5klpxTjXRhY4sEfT0bf8YfUkhhR4DbM39Fs8AuVTXsrVY3Vly7xSE ipzlJRmiNp8vakA+mscxtgxx0JfwGuS7zBSRz3TPOa+OhcZYr8WFQidcCiXNhie104 9IGI14ky65eRY4V/nlorloLUbKraJuHZbwkiYLPAVjcOF7VD+mYy8bCssIBccPLIAF JjGfKWCNFopULRbw9+AHMjMrG3CodLiGv76tJYZoDuJRIF2yp+eBnrm2dZD3Dn/vCF dX9JjejgeP0CGZOQUF+ma3qivlK5XY9vFTGRIRh0OJ2o4emOR9Obj62lUeC7Q4Dm2L ERPhGArF6khig== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C543B833F4 for ; Mon, 18 Oct 2021 13:59:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634558346; bh=6R5yHIwtgQ1tW+sum1TM0wcoOc3dRYZV778/m7diaDI=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=qvRnHl0wBhe0AGrZHFxVtufB5JE3h55tlT9Wm6vv4IOe4wQQAQSIF+ynC6WjRR/Nr cN0YbDPLdPl7j9rvZe/RsCDYwnBBuW5yhJzK5GPGrBUVkcnE6Id1nn+VjJiBgkYTk0 Lg9VPzsxzAwIujt3rJ8VZcsjam9ERMllxGnl+NKZEl6/ANmncum1eEg/8G1p84nm8a V4LDz1MCXrSxuh1jN6Y3gDFABDIlYLrgwSiLHIEkTWoOX6QlFfAvPNIZA+5p6G04pX B3XG0HdpI78dPFSvm5/BcSfZMfdbnY1SnF3mik7fnGTtV9GhiRiT5rpbiTNyfmHI0D S5K0nigB3m1QQ== Received: by janitor.denx.de (Postfix, from userid 108) id 3B7D7A02B9; Mon, 18 Oct 2021 13:59:06 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id DC9A7A0091; Mon, 18 Oct 2021 13:58:57 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 8BC801E0F1B; Mon, 18 Oct 2021 13:58:57 +0200 (CEST) To: Simon Glass cc: U-Boot Mailing List , Heinrich Schuchardt , Tom Rini , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: References: <20211014182257.468649-1-sjg@chromium.org> <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3341802.1634308345@gemini.denx.de> Comments: In-reply-to Simon Glass message dated "Fri, 15 Oct 2021 09:15:00 -0600." Date: Mon, 18 Oct 2021 13:58:57 +0200 Message-ID: <3496103.1634558337@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Simon, In message you wrote: > > > I really think your fixed filename proposal does not work well in > > reality. The file name should be Kconfig configurable. See [1] > > for details. > > > > [1] https://lists.denx.de/pipermail/u-boot/2021-October/462668.html > > Yes I saw that but I forgot to look at it. I think it makes sense - we > do that with devicetree, for example. > > Is that the only thing holding you back? Basically yes - the only other concerns I have is about this += construct which makes the '+' character an illegal character for environment variable names, but only when used at the end of the variable. This is anything but nice or consistent. Iwonder what happens with notations like these: foo+=bar -> "bar" gets appended to current value of "foo" But what for: foo\+=bar or foo+ = bar ? And please see also my comments about changing the autostart functionality for the user. > I haven't seen any positive comments to this series yet... Maybe many long-term users of U-Boot don't see the current situation as such a big problem? I have no idea. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Real Programmers always confuse Christmas and Halloween because OCT 31 == DEC 25 ! - Andrew Rutherford (andrewr@ucs.adelaide.edu.au)