All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Eiderman <shmuel.eiderman@oracle.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: kwolf@redhat.com, qemu-block@nongnu.org, arbel.moshe@oracle.com,
	seabios@seabios.org, qemu-devel@nongnu.org, mreitz@redhat.com,
	kevin@koconnor.net, liran.alon@oracle.com,
	karl.heubaum@oracle.com
Subject: Re: [Qemu-devel] [QEMU] [PATCH v2 7/8] bootdevice: FW_CFG interface for LCHS values
Date: Mon, 17 Jun 2019 13:08:30 +0300	[thread overview]
Message-ID: <34BC5303-962D-49BD-BA3F-56D1CD7E58CC@oracle.com> (raw)
In-Reply-To: <20190617083842.xlicosythr2gtnvh@sirius.home.kraxel.org>

Ok,

I’ll resubmit this patch series in v3, as well as v2 for SeaBIOS soon enough.

* Change “bootdevices” to “bios-geometry”, and remove the struct size
* Add cpu_to_le32 fix as Laszlo suggested or big endian hosts
* Fix last qtest commit - automatic docker tester for some reason does not have qemu-img set

Sam

> On 17 Jun 2019, at 11:38, Gerd Hoffmann <kraxel@redhat.com> wrote:
> 
>  Hi,
> 
>> Keep it extendible for a low price of ABI + “bootdevices” name.
>> Or go strict and rename to “bios-geometries”?
> 
> The name should reflect what is in there, so "bios-geometries" looks
> better to me.  I'd also keep it strict, unless we have at least a vague
> idea what might be a useful future extension.  I don't have any.
> 
> cheers,
>  Gerd
> 



  reply	other threads:[~2019-06-17 10:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 11:59 [Qemu-devel] [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface Sam Eiderman
2019-06-12 11:59 ` [Qemu-devel] [QEMU] [PATCH v2 1/8] block: Refactor macros - fix tabbing Sam Eiderman
2019-06-12 11:59 ` [Qemu-devel] [QEMU] [PATCH v2 2/8] block: Support providing LCHS from user Sam Eiderman
2019-06-12 11:59 ` [Qemu-devel] [QEMU] [PATCH v2 3/8] bootdevice: Add interface to gather LCHS Sam Eiderman
2019-06-12 11:59 ` [Qemu-devel] [QEMU] [PATCH v2 4/8] scsi: Propagate unrealize() callback to scsi-hd Sam Eiderman
2019-06-12 11:59 ` [Qemu-devel] [QEMU] [PATCH v2 5/8] bootdevice: Gather LCHS from all relevant devices Sam Eiderman
2019-06-12 11:59 ` [Qemu-devel] [QEMU] [PATCH v2 6/8] bootdevice: Refactor get_boot_devices_list Sam Eiderman
2019-06-12 11:59 ` [Qemu-devel] [QEMU] [PATCH v2 7/8] bootdevice: FW_CFG interface for LCHS values Sam Eiderman
2019-06-17  7:20   ` Gerd Hoffmann
2019-06-17  7:36     ` Sam Eiderman
2019-06-17  8:38       ` Gerd Hoffmann
2019-06-17 10:08         ` Sam Eiderman [this message]
2019-06-17 14:48       ` Kevin O'Connor
2019-06-17 15:13         ` Sam Eiderman
2019-06-12 11:59 ` [Qemu-devel] [QEMU] [PATCH v2 8/8] hd-geo-test: Add tests for lchs override Sam Eiderman
2019-06-12 12:33 ` [Qemu-devel] [SeaBIOS] [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface no-reply
2019-06-12 13:06 ` [Qemu-devel] " Gerd Hoffmann
2019-06-12 13:30   ` Sam Eiderman
2019-06-12 19:18     ` Gerd Hoffmann
2019-06-13  7:41       ` Sam Eiderman
2019-06-13  7:44         ` Sam Eiderman
2019-06-13  9:38         ` Gerd Hoffmann
2019-06-13 11:45           ` Sam Eiderman
2019-06-14  4:43             ` Gerd Hoffmann
2019-06-14  9:37               ` Sam Eiderman
2019-06-17  6:50                 ` Gerd Hoffmann
2019-06-17  7:59                   ` Sam Eiderman
2019-06-12 13:51 ` [Qemu-devel] [SeaBIOS] " no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34BC5303-962D-49BD-BA3F-56D1CD7E58CC@oracle.com \
    --to=shmuel.eiderman@oracle.com \
    --cc=arbel.moshe@oracle.com \
    --cc=karl.heubaum@oracle.com \
    --cc=kevin@koconnor.net \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=liran.alon@oracle.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.