From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753109AbdKMPRr (ORCPT ); Mon, 13 Nov 2017 10:17:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52540 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751605AbdKMPRq (ORCPT ); Mon, 13 Nov 2017 10:17:46 -0500 Subject: Re: [PATCH] x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static To: Gimcuan Hui , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171103185246.5999-1-gimcuan@gmail.com> From: Paolo Bonzini Message-ID: <34b5d42d-781f-4a2b-19a7-268eeffb87e4@redhat.com> Date: Mon, 13 Nov 2017 16:17:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171103185246.5999-1-gimcuan@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 13 Nov 2017 15:17:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2017 19:52, Gimcuan Hui wrote: > The kvm_mmu_clear_all_pte_masks interface is only used by kvm_mmu_module_init > locally, and does not need to be called by other module, make it static. > > This patch cleans up sparse warning: > symbol 'kvm_mmu_clear_all_pte_masks' was not declared. Should it be static? > > Signed-off-by: Gimcuan Hui > --- > arch/x86/kvm/mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index 7a69cf053711..6b247d64926e 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -367,7 +367,7 @@ void kvm_mmu_set_mask_ptes(u64 user_mask, u64 accessed_mask, > } > EXPORT_SYMBOL_GPL(kvm_mmu_set_mask_ptes); > > -void kvm_mmu_clear_all_pte_masks(void) > +static void kvm_mmu_clear_all_pte_masks(void) > { > shadow_user_mask = 0; > shadow_accessed_mask = 0; > Queued, thanks. Paolo