From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E1E6C4321D for ; Thu, 23 Aug 2018 18:07:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B4662147A for ; Thu, 23 Aug 2018 18:07:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B4662147A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727072AbeHWVh7 (ORCPT ); Thu, 23 Aug 2018 17:37:59 -0400 Received: from gateway30.websitewelcome.com ([192.185.192.34]:17275 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726819AbeHWVh7 (ORCPT ); Thu, 23 Aug 2018 17:37:59 -0400 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 4F82E1DC78 for ; Thu, 23 Aug 2018 12:42:53 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id stcrfcbvMPvAdstd4fb2L8; Thu, 23 Aug 2018 12:42:52 -0500 X-Authority-Reason: nr=8 Received: from [189.250.40.214] (port=57188 helo=[192.168.1.71]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1fstcq-003IQW-Sa; Thu, 23 Aug 2018 12:42:29 -0500 Subject: Re: [PATCH] usb: iowarrior: replace kmalloc with kmalloc_array To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook References: <20180823173125.GA24762@embeddedor.com> From: "Gustavo A. R. Silva" Openpgp: preference=signencrypt Autocrypt: addr=gustavo@embeddedor.com; keydata= xsFNBFssHAwBEADIy3ZoPq3z5UpsUknd2v+IQud4TMJnJLTeXgTf4biSDSrXn73JQgsISBwG 2Pm4wnOyEgYUyJd5tRWcIbsURAgei918mck3tugT7AQiTUN3/5aAzqe/4ApDUC+uWNkpNnSV tjOx1hBpla0ifywy4bvFobwSh5/I3qohxDx+c1obd8Bp/B/iaOtnq0inli/8rlvKO9hp6Z4e DXL3PlD0QsLSc27AkwzLEc/D3ZaqBq7ItvT9Pyg0z3Q+2dtLF00f9+663HVC2EUgP25J3xDd 496SIeYDTkEgbJ7WYR0HYm9uirSET3lDqOVh1xPqoy+U9zTtuA9NQHVGk+hPcoazSqEtLGBk YE2mm2wzX5q2uoyptseSNceJ+HE9L+z1KlWW63HhddgtRGhbP8pj42bKaUSrrfDUsicfeJf6 m1iJRu0SXYVlMruGUB1PvZQ3O7TsVfAGCv85pFipdgk8KQnlRFkYhUjLft0u7CL1rDGZWDDr NaNj54q2CX9zuSxBn9XDXvGKyzKEZ4NY1Jfw+TAMPCp4buawuOsjONi2X0DfivFY+ZsjAIcx qQMglPtKk/wBs7q2lvJ+pHpgvLhLZyGqzAvKM1sVtRJ5j+ARKA0w4pYs5a5ufqcfT7dN6TBk LXZeD9xlVic93Ju08JSUx2ozlcfxq+BVNyA+dtv7elXUZ2DrYwARAQABzSxHdXN0YXZvIEEu IFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPsLBfQQTAQgAJwUCWywcDAIbIwUJ CWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRBHBbTLRwbbMZ6tEACk0hmmZ2FWL1Xi l/bPqDGFhzzexrdkXSfTTZjBV3a+4hIOe+jl6Rci/CvRicNW4H9yJHKBrqwwWm9fvKqOBAg9 obq753jydVmLwlXO7xjcfyfcMWyx9QdYLERTeQfDAfRqxir3xMeOiZwgQ6dzX3JjOXs6jHBP cgry90aWbaMpQRRhaAKeAS14EEe9TSIly5JepaHoVdASuxklvOC0VB0OwNblVSR2S5i5hSsh ewbOJtwSlonsYEj4EW1noQNSxnN/vKuvUNegMe+LTtnbbocFQ7dGMsT3kbYNIyIsp42B5eCu JXnyKLih7rSGBtPgJ540CjoPBkw2mCfhj2p5fElRJn1tcX2McsjzLFY5jK9RYFDavez5w3lx JFgFkla6sQHcrxH62gTkb9sUtNfXKucAfjjCMJ0iuQIHRbMYCa9v2YEymc0k0RvYr43GkA3N PJYd/vf9vU7VtZXaY4a/dz1d9dwIpyQARFQpSyvt++R74S78eY/+lX8wEznQdmRQ27kq7BJS R20KI/8knhUNUJR3epJu2YFT/JwHbRYC4BoIqWl+uNvDf+lUlI/D1wP+lCBSGr2LTkQRoU8U 64iK28BmjJh2K3WHmInC1hbUucWT7Swz/+6+FCuHzap/cjuzRN04Z3Fdj084oeUNpP6+b9yW e5YnLxF8ctRAp7K4yVlvA87BTQRbLBwMARAAsHCE31Ffrm6uig1BQplxMV8WnRBiZqbbsVJB H1AAh8tq2ULl7udfQo1bsPLGGQboJSVN9rckQQNahvHAIK8ZGfU4Qj8+CER+fYPp/MDZj+t0 DbnWSOrG7z9HIZo6PR9z4JZza3Hn/35jFggaqBtuydHwwBANZ7A6DVY+W0COEU4of7CAahQo 5NwYiwS0lGisLTqks5R0Vh+QpvDVfuaF6I8LUgQR/cSgLkR//V1uCEQYzhsoiJ3zc1HSRyOP otJTApqGBq80X0aCVj1LOiOF4rrdvQnj6iIlXQssdb+WhSYHeuJj1wD0ZlC7ds5zovXh+FfF l5qH5RFY/qVn3mNIVxeO987WSF0jh+T5ZlvUNdhedGndRmwFTxq2Li6GNMaolgnpO/CPcFpD jKxY/HBUSmaE9rNdAa1fCd4RsKLlhXda+IWpJZMHlmIKY8dlUybP+2qDzP2lY7kdFgPZRU+e zS/pzC/YTzAvCWM3tDgwoSl17vnZCr8wn2/1rKkcLvTDgiJLPCevqpTb6KFtZosQ02EGMuHQ I6Zk91jbx96nrdsSdBLGH3hbvLvjZm3C+fNlVb9uvWbdznObqcJxSH3SGOZ7kCHuVmXUcqoz ol6ioMHMb+InrHPP16aVDTBTPEGwgxXI38f7SUEn+NpbizWdLNz2hc907DvoPm6HEGCanpcA EQEAAcLBZQQYAQgADwUCWywcDAIbDAUJCWYBgAAKCRBHBbTLRwbbMdsZEACUjmsJx2CAY+QS UMebQRFjKavwXB/xE7fTt2ahuhHT8qQ/lWuRQedg4baInw9nhoPE+VenOzhGeGlsJ0Ys52sd XvUjUocKgUQq6ekOHbcw919nO5L9J2ejMf/VC/quN3r3xijgRtmuuwZjmmi8ct24TpGeoBK4 WrZGh/1hAYw4ieARvKvgjXRstcEqM5thUNkOOIheud/VpY+48QcccPKbngy//zNJWKbRbeVn imua0OpqRXhCrEVm/xomeOvl1WK1BVO7z8DjSdEBGzbV76sPDJb/fw+y+VWrkEiddD/9CSfg fBNOb1p1jVnT2mFgGneIWbU0zdDGhleI9UoQTr0e0b/7TU+Jo6TqwosP9nbk5hXw6uR5k5PF 8ieyHVq3qatJ9K1jPkBr8YWtI5uNwJJjTKIA1jHlj8McROroxMdI6qZ/wZ1ImuylpJuJwCDC ORYf5kW61fcrHEDlIvGc371OOvw6ejF8ksX5+L2zwh43l/pKkSVGFpxtMV6d6J3eqwTafL86 YJWH93PN+ZUh6i6Rd2U/i8jH5WvzR57UeWxE4P8bQc0hNGrUsHQH6bpHV2lbuhDdqo+cM9eh GZEO3+gCDFmKrjspZjkJbB5Gadzvts5fcWGOXEvuT8uQSvl+vEL0g6vczsyPBtqoBLa9SNrS VtSixD1uOgytAP7RWS474w== Message-ID: <34b8a5c3-d71a-3aba-c2ae-2b0a2798361c@embeddedor.com> Date: Thu, 23 Aug 2018 12:42:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180823173125.GA24762@embeddedor.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.40.214 X-Source-L: No X-Exim-ID: 1fstcq-003IQW-Sa X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.71]) [189.250.40.214]:57188 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 7 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Please, drop this. I'll align GFP_KERNEL and send v2. Thanks -- Gustavo On 8/23/18 12:31 PM, Gustavo A. R. Silva wrote: > A common flaw in the kernel is integer overflow during memory allocation > size calculations. In an effort to reduce the frequency of these bugs, > kmalloc_array was implemented, which allocates memory for an array, > while at the same time detects integer overflow. > > This patch replaces cases of: > > kmalloc(a * b, gfp) > > with: > kmalloc_array(a * b, gfp) > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/usb/misc/iowarrior.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c > index c2991b8..7a22400 100644 > --- a/drivers/usb/misc/iowarrior.c > +++ b/drivers/usb/misc/iowarrior.c > @@ -808,7 +808,7 @@ static int iowarrior_probe(struct usb_interface *interface, > dev->int_in_endpoint->bInterval); > /* create an internal buffer for interrupt data from the device */ > dev->read_queue = > - kmalloc(((dev->report_size + 1) * MAX_INTERRUPT_BUFFER), > + kmalloc_array(dev->report_size + 1, MAX_INTERRUPT_BUFFER, > GFP_KERNEL); > if (!dev->read_queue) > goto error; > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: iowarrior: replace kmalloc with kmalloc_array From: "Gustavo A. R. Silva" Message-Id: <34b8a5c3-d71a-3aba-c2ae-2b0a2798361c@embeddedor.com> Date: Thu, 23 Aug 2018 12:42:27 -0500 To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook List-ID: SGksCgpQbGVhc2UsIGRyb3AgdGhpcy4KCkknbGwgYWxpZ24gR0ZQX0tFUk5FTCBhbmQgc2VuZCB2 Mi4KClRoYW5rcwotLS0KR3VzdGF2bwoKT24gOC8yMy8xOCAxMjozMSBQTSwgR3VzdGF2byBBLiBS LiBTaWx2YSB3cm90ZToKPiBBIGNvbW1vbiBmbGF3IGluIHRoZSBrZXJuZWwgaXMgaW50ZWdlciBv dmVyZmxvdyBkdXJpbmcgbWVtb3J5IGFsbG9jYXRpb24KPiBzaXplIGNhbGN1bGF0aW9ucy4gSW4g YW4gZWZmb3J0IHRvIHJlZHVjZSB0aGUgZnJlcXVlbmN5IG9mIHRoZXNlIGJ1Z3MsCj4ga21hbGxv Y19hcnJheSB3YXMgaW1wbGVtZW50ZWQsIHdoaWNoIGFsbG9jYXRlcyBtZW1vcnkgZm9yIGFuIGFy cmF5LAo+IHdoaWxlIGF0IHRoZSBzYW1lIHRpbWUgZGV0ZWN0cyBpbnRlZ2VyIG92ZXJmbG93Lgo+ IAo+IFRoaXMgcGF0Y2ggcmVwbGFjZXMgY2FzZXMgb2Y6Cj4gCj4ga21hbGxvYyhhICogYiwgZ2Zw KQo+IAo+IHdpdGg6Cj4gCWttYWxsb2NfYXJyYXkoYSAqIGIsIGdmcCkKPiAKPiBTaWduZWQtb2Zm LWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPgo+IC0tLQo+ ICBkcml2ZXJzL3VzYi9taXNjL2lvd2Fycmlvci5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwg MSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91 c2IvbWlzYy9pb3dhcnJpb3IuYyBiL2RyaXZlcnMvdXNiL21pc2MvaW93YXJyaW9yLmMKPiBpbmRl eCBjMjk5MWI4Li43YTIyNDAwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdXNiL21pc2MvaW93YXJy aW9yLmMKPiArKysgYi9kcml2ZXJzL3VzYi9taXNjL2lvd2Fycmlvci5jCj4gQEAgLTgwOCw3ICs4 MDgsNyBAQCBzdGF0aWMgaW50IGlvd2Fycmlvcl9wcm9iZShzdHJ1Y3QgdXNiX2ludGVyZmFjZSAq aW50ZXJmYWNlLAo+ICAJCQkgZGV2LT5pbnRfaW5fZW5kcG9pbnQtPmJJbnRlcnZhbCk7Cj4gIAkv KiBjcmVhdGUgYW4gaW50ZXJuYWwgYnVmZmVyIGZvciBpbnRlcnJ1cHQgZGF0YSBmcm9tIHRoZSBk ZXZpY2UgKi8KPiAgCWRldi0+cmVhZF9xdWV1ZSA9Cj4gLQkgICAga21hbGxvYygoKGRldi0+cmVw b3J0X3NpemUgKyAxKSAqIE1BWF9JTlRFUlJVUFRfQlVGRkVSKSwKPiArCSAgICBrbWFsbG9jX2Fy cmF5KGRldi0+cmVwb3J0X3NpemUgKyAxLCBNQVhfSU5URVJSVVBUX0JVRkZFUiwKPiAgCQkgICAg R0ZQX0tFUk5FTCk7Cj4gIAlpZiAoIWRldi0+cmVhZF9xdWV1ZSkKPiAgCQlnb3RvIGVycm9yOwo+ Cg==