All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [PATCH RFC v2] m68k: remove get_fs()/set_fs()
Date: Sat, 10 Jul 2021 07:52:47 +1200	[thread overview]
Message-ID: <34ba1bc1-9e15-3d14-55ec-a5b4ca118e63@gmail.com> (raw)
In-Reply-To: <d3f23781-1968-d936-2a1a-6d964dbcb860@gmail.com>

Am 10.07.2021 um 07:25 schrieb Michael Schmitz:
> Hi Geert,
>
> Am 09.07.2021 um 23:20 schrieb Geert Uytterhoeven:
>> Hi Michael,
>>
>> On Fri, Jul 9, 2021 at 11:00 AM Michael Schmitz <schmitzmic@gmail.com>
>> wrote:
>>> Am 09.07.2021 um 20:53 schrieb Christoph Hellwig:
>>>> On Fri, Jul 09, 2021 at 08:34:07PM +1200, Michael Schmitz wrote:
>>>>> Just booting to a login prompt: Quite a few with 8 bytes, some with
>>>>> 4 bytes
>>>>> (those from the keyboard driver), the rest is 16, 24, 36 and 92
>>>>> bytes (a
>>>
>>> Over 400x 8 bytes, 20x 4 bytes on a count with the larger one
>>> suppressed.
>>>
>>>>
>>>> The 4/8 byte ones can usually be switched to just use get/put_user
>>>> easily.
>>>
>>> Need to log the call sites then ... that should be fun. Something to do
>>> tomorrow :-)
>>
>> WARN_ON_ONCE() is your friend.
>
> Sure - here's the result:
>
> WARNING: CPU: 0 PID: 1 at ./arch/m68k/include/asm/uaccess.h:395
> raw_copy_to_user.constprop.27+0x26/0x42

That one got called from sys_llseek+0x5c/0x86

Cheers,

	Michael


> WARNING: CPU: 0 PID: 819 at ./arch/m68k/include/asm/uaccess.h:395
> do_pipe2+0x4a/0xbc
> WARNING: CPU: 0 PID: 838 at ./arch/m68k/include/asm/uaccess.h:395
> __put_old_timespec32+0x36/0x58
> WARNING: CPU: 0 PID: 854 at ./arch/m68k/include/asm/uaccess.h:303
> vt_do_kdsk_ioctl+0x38/0x28a
> WARNING: CPU: 0 PID: 950 at ./arch/m68k/include/asm/uaccess.h:395
> tty_ioctl+0x27a/0x6c4
>
> uaccess.h:303 is __constant_copy_from_user.
>
> Cheers,
>
>     Michael
>
>
>> Gr{oetje,eeting}s,
>>
>>                         Geert
>>

  reply	other threads:[~2021-07-09 19:52 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08  1:48 [PATCH RFC v2] m68k: remove get_fs()/set_fs() Michael Schmitz
2021-07-08  2:51 ` Linus Torvalds
2021-07-08  3:01   ` Linus Torvalds
2021-07-08  3:37     ` Michael Schmitz
2021-07-08  4:31     ` Christoph Hellwig
2021-07-08  4:33       ` Michael Schmitz
2021-07-08  4:58         ` Christoph Hellwig
2021-07-08  5:48           ` Michael Schmitz
2021-07-08 12:57             ` Christoph Hellwig
2021-07-08 18:20               ` Linus Torvalds
2021-07-09  0:05                 ` Michael Schmitz
2021-07-08 19:28               ` Michael Schmitz
2021-07-09  0:31                 ` Michael Schmitz
2021-07-09  4:22                   ` Christoph Hellwig
2021-07-09  5:47                     ` Michael Schmitz
2021-07-09  7:29                     ` Geert Uytterhoeven
2021-07-09  8:34                       ` Michael Schmitz
2021-07-09  8:53                         ` Christoph Hellwig
2021-07-09  9:00                           ` Michael Schmitz
2021-07-09 11:20                             ` Geert Uytterhoeven
2021-07-09 19:25                               ` Michael Schmitz
2021-07-09 19:52                                 ` Michael Schmitz [this message]
2021-07-09 20:03                                   ` Linus Torvalds
2021-07-09 20:13                                     ` Linus Torvalds
2021-07-09 19:53                                 ` Linus Torvalds
2021-07-09 21:08                                   ` Michael Schmitz
2021-07-09 21:18                                     ` Linus Torvalds
2021-07-10  2:30                                       ` Michael Schmitz
2021-07-09 11:35                           ` Geert Uytterhoeven
2021-07-08  7:36     ` Andreas Schwab
2021-07-08  4:28   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34ba1bc1-9e15-3d14-55ec-a5b4ca118e63@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=hch@lst.de \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.