All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Douglas Anderson <dianders@chromium.org>,
	Kieran Bingham <kbingham@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: kgdb-bugreport@lists.sourceforge.net,
	Jason Wessel <jason.wessel@windriver.com>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Stephen Boyd <swboyd@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/gdb: Handle split debug
Date: Wed, 31 Jul 2019 16:24:28 +0200	[thread overview]
Message-ID: <34bbd6b5-2e37-159a-b75b-36a6be11c506@siemens.com> (raw)
In-Reply-To: <20190730234052.148744-1-dianders@chromium.org>

On 31.07.19 01:40, Douglas Anderson wrote:
> Some systems (like Chrome OS) may use "split debug" for kernel
> modules.  That means that the debug symbols are in a different file
> than the main elf file.  Let's handle that by also searching for debug
> symbols that end in ".ko.debug".

Is this split-up depending on additional kernel patches, is this already
possible with mainline, or is this purely a packaging topic? Wondering because
of testability in case it's downstream-only.

Jan

> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
> 
>  scripts/gdb/linux/symbols.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
> index 2f5b95f09fa0..34e40e96dee2 100644
> --- a/scripts/gdb/linux/symbols.py
> +++ b/scripts/gdb/linux/symbols.py
> @@ -77,12 +77,12 @@ lx-symbols command."""
>              gdb.write("scanning for modules in {0}\n".format(path))
>              for root, dirs, files in os.walk(path):
>                  for name in files:
> -                    if name.endswith(".ko"):
> +                    if name.endswith(".ko") or name.endswith(".ko.debug"):
>                          self.module_files.append(root + "/" + name)
>          self.module_files_updated = True
>  
>      def _get_module_file(self, module_name):
> -        module_pattern = ".*/{0}\.ko$".format(
> +        module_pattern = ".*/{0}\.ko(?:.debug)?$".format(
>              module_name.replace("_", r"[_\-]"))
>          for name in self.module_files:
>              if re.match(module_pattern, name) and os.path.exists(name):
> 

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

  parent reply	other threads:[~2019-07-31 14:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 23:40 Douglas Anderson
2019-07-31 14:17 ` Stephen Boyd
2019-07-31 14:24 ` Jan Kiszka [this message]
2019-07-31 15:44   ` Doug Anderson
2019-07-31 16:23     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34bbd6b5-2e37-159a-b75b-36a6be11c506@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=akpm@linux-foundation.org \
    --cc=daniel.thompson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=jason.wessel@windriver.com \
    --cc=kbingham@kernel.org \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=swboyd@chromium.org \
    --subject='Re: [PATCH] scripts/gdb: Handle split debug' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.