From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F8CCC4338F for ; Wed, 4 Aug 2021 10:51:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03D8C60EE5 for ; Wed, 4 Aug 2021 10:51:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237602AbhHDKvW (ORCPT ); Wed, 4 Aug 2021 06:51:22 -0400 Received: from foss.arm.com ([217.140.110.172]:59130 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236736AbhHDKvT (ORCPT ); Wed, 4 Aug 2021 06:51:19 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1000813A1; Wed, 4 Aug 2021 03:51:07 -0700 (PDT) Received: from [10.57.10.145] (unknown [10.57.10.145]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E6FF3F719; Wed, 4 Aug 2021 03:51:04 -0700 (PDT) Subject: Re: [PATCH v2] cpufreq: arm_scmi: Fix error path when allocation failed To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, cristian.marussi@arm.com, rjw@rjwysocki.net, viresh.kumar@linaro.org, nicola.mazzucato@arm.com, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org References: <20210803090744.12143-1-lukasz.luba@arm.com> <20210803224145.zyr36sliwa7a67xf@bogus> From: Lukasz Luba Message-ID: <34c0a16b-4f82-8c78-9e29-63d462ea68b8@arm.com> Date: Wed, 4 Aug 2021 11:51:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20210803224145.zyr36sliwa7a67xf@bogus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/3/21 11:41 PM, Sudeep Holla wrote: > On Tue, Aug 03, 2021 at 10:07:44AM +0100, Lukasz Luba wrote: >> Stop the initialization when cpumask allocation failed and return an >> error. >> > > Good catch! > > Reviewed-by: Sudeep Holla > Thank you for the review! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59E7BC4338F for ; Wed, 4 Aug 2021 10:52:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 207D160F38 for ; Wed, 4 Aug 2021 10:52:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 207D160F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/FLL9ab7mcovqUhu3vTeelHWFXt5fxHUPbxLOAbyk2w=; b=a+k0S1Aw2SIf0FJyZyY4xXAoRk 4eDGFMh4kzdh8j0dkFfihjDBjCLV8d6DMm2QVQMKniddf9fklsdypFX+daePJ9v5LKUJwG9g4Dc98 UJCM7IxpnNSP3/RWld2/PGfh8ZHWDl9qjxiKm/d0maGUsY4ueHPwzEcCrWBCdyxWWX6W8dFczWQ/P CvP1TzQjeQk6EeNy09UKZsMRdccCo1XZMvDexNgJ5uQVuV74USJhUC6EPukGIGK7AkTEWUX8qGqu2 kBdwxrRuWn2FoGR2bBz2EXmjUo5rDsOd7mlZUghUbEqZMH5UPWD9h5X9Hp3hv8Cwlj9ROloiGHcPJ EYTCqDXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBEUX-005n15-Lm; Wed, 04 Aug 2021 10:51:17 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBEUT-005mzs-KB for linux-arm-kernel@lists.infradead.org; Wed, 04 Aug 2021 10:51:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1000813A1; Wed, 4 Aug 2021 03:51:07 -0700 (PDT) Received: from [10.57.10.145] (unknown [10.57.10.145]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E6FF3F719; Wed, 4 Aug 2021 03:51:04 -0700 (PDT) Subject: Re: [PATCH v2] cpufreq: arm_scmi: Fix error path when allocation failed To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, cristian.marussi@arm.com, rjw@rjwysocki.net, viresh.kumar@linaro.org, nicola.mazzucato@arm.com, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org References: <20210803090744.12143-1-lukasz.luba@arm.com> <20210803224145.zyr36sliwa7a67xf@bogus> From: Lukasz Luba Message-ID: <34c0a16b-4f82-8c78-9e29-63d462ea68b8@arm.com> Date: Wed, 4 Aug 2021 11:51:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20210803224145.zyr36sliwa7a67xf@bogus> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_035113_788151_1704D1E7 X-CRM114-Status: GOOD ( 10.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/3/21 11:41 PM, Sudeep Holla wrote: > On Tue, Aug 03, 2021 at 10:07:44AM +0100, Lukasz Luba wrote: >> Stop the initialization when cpumask allocation failed and return an >> error. >> > > Good catch! > > Reviewed-by: Sudeep Holla > Thank you for the review! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel