All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Six <mario.six@gdsys.cc>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/19] spi: mpc8xxx: Rename camel-case variables
Date: Tue, 10 Apr 2018 13:01:32 +0200	[thread overview]
Message-ID: <34c2e7a12eb3580abcadba63f9586d264b6d0389.1523355172.git.mario.six@gdsys.cc> (raw)
In-Reply-To: <cover.1523355172.git.mario.six@gdsys.cc>

There are three variables that have camel-case names, which is not the
preferred naming style.

Give those variables more compliant names instead.

Signed-off-by: Mario Six <mario.six@gdsys.cc>
---
 drivers/spi/mpc8xxx_spi.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c
index 2f6afaf7ac..3ac9f2f8e8 100644
--- a/drivers/spi/mpc8xxx_spi.c
+++ b/drivers/spi/mpc8xxx_spi.c
@@ -78,9 +78,9 @@ int spi_xfer(struct spi_slave *slave, uint bitlen, const void *dout, void *din,
 {
 	volatile spi8xxx_t *spi = &((immap_t *) (CONFIG_SYS_IMMR))->spi;
 	uint tmpdout, tmpdin, event;
-	int numBlks = DIV_ROUND_UP(bitlen, 32);
-	int tm, isRead = 0;
-	uchar charSize = 32;
+	int num_blks = DIV_ROUND_UP(bitlen, 32);
+	int tm, is_read = 0;
+	uchar char_size = 32;
 
 	debug("spi_xfer: slave %u:%u dout %08X din %08X bitlen %u\n",
 	      slave->bus, slave->cs, *(uint *) dout, *(uint *) din, bitlen);
@@ -92,12 +92,12 @@ int spi_xfer(struct spi_slave *slave, uint bitlen, const void *dout, void *din,
 	spi->event = 0xffffffff;
 
 	/* Handle data in 32-bit chunks */
-	while (numBlks--) {
+	while (num_blks--) {
 		tmpdout = 0;
-		charSize = (bitlen >= 32 ? 32 : bitlen);
+		char_size = (bitlen >= 32 ? 32 : bitlen);
 
 		/* Shift data so it's msb-justified */
-		tmpdout = *(u32 *) dout >> (32 - charSize);
+		tmpdout = *(u32 *) dout >> (32 - char_size);
 
 		/* The LEN field of the SPMODE register is set as follows:
 		 *
@@ -135,15 +135,15 @@ int spi_xfer(struct spi_slave *slave, uint bitlen, const void *dout, void *din,
 		 * or time out (1 second = 1000 ms)
 		 * The NE event must be read and cleared first
 		 */
-		for (tm = 0, isRead = 0; tm < SPI_TIMEOUT; ++tm) {
+		for (tm = 0, is_read = 0; tm < SPI_TIMEOUT; ++tm) {
 			event = spi->event;
 			if (event & SPI_EV_NE) {
 				tmpdin = spi->rx;
 				spi->event |= SPI_EV_NE;
-				isRead = 1;
+				is_read = 1;
 
-				*(u32 *) din = (tmpdin << (32 - charSize));
-				if (charSize == 32) {
+				*(u32 *) din = (tmpdin << (32 - char_size));
+				if (char_size == 32) {
 					/* Advance output buffer by 32 bits */
 					din += 4;
 				}
@@ -154,7 +154,7 @@ int spi_xfer(struct spi_slave *slave, uint bitlen, const void *dout, void *din,
 			 * in the future put an arbitrary delay after writing
 			 * the device.  Arbitrary delays suck, though...
 			 */
-			if (isRead && (event & SPI_EV_NF))
+			if (is_read && (event & SPI_EV_NF))
 				break;
 		}
 		if (tm >= SPI_TIMEOUT)
-- 
2.11.0

  parent reply	other threads:[~2018-04-10 11:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10 11:01 [U-Boot] [PATCH 00/19] spi: mpc8xxx: DM conversion Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 01/19] spi: mpc8xxx: Use short type names Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 02/19] spi: mpc8xxx: Fix comments Mario Six
2018-04-10 11:01 ` Mario Six [this message]
2018-04-10 11:01 ` [U-Boot] [PATCH 04/19] spi: mpc8xxx: Fix space after cast Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 05/19] spi: mpc8xxx: Fix function names in strings Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 06/19] spi: mpc8xxx: Replace defines with enums Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 07/19] spi: mpc8xxx: Use IO accessors Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 08/19] spi: mpc8xxx: Simplify if Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 09/19] spi: mpc8xxx: Get rid of is_read Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 10/19] spi: mpc8xxx: Simplify logic a bit Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 11/19] spi: mpc8xxx: Reduce scope of loop variables Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 12/19] spi: mpc8xxx: Make code more readable Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 13/19] spi: mpc8xxx: Rename variable Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 14/19] spi: mpc8xxx: Document LEN setting better Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 15/19] spi: mpc8xxx: Re-order transfer setup Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 16/19] spi: mpc8xxx: Fix if check Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 17/19] spi: mpc8xxx: Use get_timer Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 18/19] spi: mpc8xxx: Prepare DM conversion Mario Six
2018-04-10 11:01 ` [U-Boot] [PATCH 19/19] spi: mpc8xxx: Add DM support Mario Six
2018-04-19 11:32   ` Jagan Teki
2018-04-19 11:45     ` Mario Six
2018-04-19 11:48       ` Jagan Teki
2018-04-19 11:51         ` Mario Six

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34c2e7a12eb3580abcadba63f9586d264b6d0389.1523355172.git.mario.six@gdsys.cc \
    --to=mario.six@gdsys.cc \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.