On 09/05/2017 06:05 AM, Thomas Huth wrote: > On 01.09.2017 20:03, Eric Blake wrote: >> As a general rule, we prefer avoiding implicit global state >> because it makes code harder to safely copy and paste without >> thinking about the global state. It turns out that with the >> recent changes to libqos, fw_cfg-test was not even using >> global_qtest any more. Avoid a pointless strdup while at it. >> >> Signed-off-by: Eric Blake >> --- >> tests/fw_cfg-test.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> > > Why don't you merge this with patch 14/29? Sure. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org