libfsimage path/file name changes

libfsimage path/file name changes

[Jan Beulich]

Ian,

back in October you've added quite a number of "xen" prefixes to
various pieces there. Now that I've finally had time to connect this
change of yours with PV domain creation failures that I've since
been observing (not a bug in any way, merely resulting from the
fact that I'm running everything straight from the build tree) I
started wondering whether the environment variable inspected
by common/fsimage_plugin.c:load_plugins() shouldn't then also
gain a "XEN" prefix.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Ping: libfsimage path/file name changes

[Jan Beulich]

Ian,

>>> On 28.01.19 at 08:55, <JBeulich@suse.com> wrote:
> back in October you've added quite a number of "xen" prefixes to
> various pieces there. Now that I've finally had time to connect this
> change of yours with PV domain creation failures that I've since
> been observing (not a bug in any way, merely resulting from the
> fact that I'm running everything straight from the build tree) I
> started wondering whether the environment variable inspected
> by common/fsimage_plugin.c:load_plugins() shouldn't then also
> gain a "XEN" prefix.

I think this wants a resolution one way or the other for 4.12, i.e.
either we stick to what is there also after 4.12, or we do the
additional change for the same release as where all your other
changes have been made.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: Ping: libfsimage path/file name changes

[Ian Jackson]

Jan Beulich writes ("Ping: libfsimage path/file name changes"):
> On 28.01.19 at 08:55, <JBeulich@suse.com> wrote:
> > back in October you've added quite a number of "xen" prefixes to
> > various pieces there. Now that I've finally had time to connect this
> > change of yours with PV domain creation failures that I've since
> > been observing (not a bug in any way, merely resulting from the
> > fact that I'm running everything straight from the build tree) I
> > started wondering whether the environment variable inspected
> > by common/fsimage_plugin.c:load_plugins() shouldn't then also
> > gain a "XEN" prefix.
> 
> I think this wants a resolution one way or the other for 4.12, i.e.
> either we stick to what is there also after 4.12, or we do the
> additional change for the same release as where all your other
> changes have been made.

Yes, IMO it should.  I will send a patch.

Also I have had reports of trouble with pygrub in the Debian Xen
packages, which I need to investigate and this may generate a further
patch or two.

Juergen, would that be OK with you in principle ?  (I will ask again
for a formal release ack on concrete patch(es).)

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: Ping: libfsimage path/file name changes

[Juergen Gross]

On 06/02/2019 17:13, Ian Jackson wrote:
> Jan Beulich writes ("Ping: libfsimage path/file name changes"):
>> On 28.01.19 at 08:55, <JBeulich@suse.com> wrote:
>>> back in October you've added quite a number of "xen" prefixes to
>>> various pieces there. Now that I've finally had time to connect this
>>> change of yours with PV domain creation failures that I've since
>>> been observing (not a bug in any way, merely resulting from the
>>> fact that I'm running everything straight from the build tree) I
>>> started wondering whether the environment variable inspected
>>> by common/fsimage_plugin.c:load_plugins() shouldn't then also
>>> gain a "XEN" prefix.
>>
>> I think this wants a resolution one way or the other for 4.12, i.e.
>> either we stick to what is there also after 4.12, or we do the
>> additional change for the same release as where all your other
>> changes have been made.
> 
> Yes, IMO it should.  I will send a patch.
> 
> Also I have had reports of trouble with pygrub in the Debian Xen
> packages, which I need to investigate and this may generate a further
> patch or two.
> 
> Juergen, would that be OK with you in principle ?  (I will ask again
> for a formal release ack on concrete patch(es).)

In principle bug fixes are fine, of course. Still depends on the time
they are sent and how risky they are.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH] tools/libfsimage: Add `XEN' to environment variable name

[Ian Jackson]

This library, which is private to Xen and was properly namespaced in
  1a814711881beb17f073f5f57e27e5bd4da1b956
  tools/libfsimage: Add `xen' to .h names and principal .so name
honours an environment variable to override the directory where
shared objects (ie filesystem plugins) are to be loaded from.

Rename that variable from FSIMAGE_FSDIR to XEN_FSIMAGE_FSDIR, to give
it a proper namespace prefix.

Nothing in xen.git sets this variable.  The three hits for the string
`FSIMAGE_FSDIR' are this getenv, and two references to a compile-time
manifest constant which provides the default value (the -D which sets
it, and the place it is used).

I have also checked the current Debian Xen package in buster and the
variable is not set there either.

CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Juergen Gross <jgross@suse.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: George Dunlap <george.dunlap@citrix.com>
CC: Anthony Perard <anthony.perard@citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 tools/libfsimage/common/fsimage_plugin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libfsimage/common/fsimage_plugin.c b/tools/libfsimage/common/fsimage_plugin.c
index 44ebcf3142..de1412b423 100644
--- a/tools/libfsimage/common/fsimage_plugin.c
+++ b/tools/libfsimage/common/fsimage_plugin.c
@@ -121,7 +121,7 @@ fail:
 
 static int load_plugins(void)
 {
-	const char *fsdir = getenv("FSIMAGE_FSDIR");
+	const char *fsdir = getenv("XEN_FSIMAGE_FSDIR");
 	struct dirent *dp = NULL;
 	DIR *dir = NULL;
 	char *tmp = NULL;
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH for-4.12] tools/libfsimage: Add `XEN' to environment variable name

[Ian Jackson]

Ian Jackson writes ("[PATCH] tools/libfsimage: Add `XEN' to environment variable name"):
> This library, which is private to Xen and was properly namespaced in
>   1a814711881beb17f073f5f57e27e5bd4da1b956
>   tools/libfsimage: Add `xen' to .h names and principal .so name
> honours an environment variable to override the directory where
> shared objects (ie filesystem plugins) are to be loaded from.
> 
> Rename that variable from FSIMAGE_FSDIR to XEN_FSIMAGE_FSDIR, to give
> it a proper namespace prefix.
> 
> Nothing in xen.git sets this variable.  The three hits for the string
> `FSIMAGE_FSDIR' are this getenv, and two references to a compile-time
> manifest constant which provides the default value (the -D which sets
> it, and the place it is used).
> 
> I have also checked the current Debian Xen package in buster and the
> variable is not set there either.

Replying to add the for-4.12 tag.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] tools/libfsimage: Add `XEN' to environment variable name

[Anthony PERARD]

On Tue, Mar 05, 2019 at 03:37:30PM +0000, Ian Jackson wrote:
> This library, which is private to Xen and was properly namespaced in
>   1a814711881beb17f073f5f57e27e5bd4da1b956
>   tools/libfsimage: Add `xen' to .h names and principal .so name
> honours an environment variable to override the directory where
> shared objects (ie filesystem plugins) are to be loaded from.
> 
> Rename that variable from FSIMAGE_FSDIR to XEN_FSIMAGE_FSDIR, to give
> it a proper namespace prefix.
> 
> Nothing in xen.git sets this variable.  The three hits for the string
> `FSIMAGE_FSDIR' are this getenv, and two references to a compile-time
> manifest constant which provides the default value (the -D which sets
> it, and the place it is used).
> 
> I have also checked the current Debian Xen package in buster and the
> variable is not set there either.

I have checked the CentOS pkg, and we don't set that variable either.
so:
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] tools/libfsimage: Add `XEN' to environment variable name

[Wei Liu]

On Tue, Mar 05, 2019 at 03:37:30PM +0000, Ian Jackson wrote:
> This library, which is private to Xen and was properly namespaced in
>   1a814711881beb17f073f5f57e27e5bd4da1b956
>   tools/libfsimage: Add `xen' to .h names and principal .so name
> honours an environment variable to override the directory where
> shared objects (ie filesystem plugins) are to be loaded from.
> 
> Rename that variable from FSIMAGE_FSDIR to XEN_FSIMAGE_FSDIR, to give
> it a proper namespace prefix.
> 
> Nothing in xen.git sets this variable.  The three hits for the string
> `FSIMAGE_FSDIR' are this getenv, and two references to a compile-time
> manifest constant which provides the default value (the -D which sets
> it, and the place it is used).
> 
> I have also checked the current Debian Xen package in buster and the
> variable is not set there either.
> 
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Juergen Gross <jgross@suse.com>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: George Dunlap <george.dunlap@citrix.com>
> CC: Anthony Perard <anthony.perard@citrix.com>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] tools/libfsimage: Add `XEN' to environment variable name

[Juergen Gross]

On 05/03/2019 16:37, Ian Jackson wrote:
> This library, which is private to Xen and was properly namespaced in
>   1a814711881beb17f073f5f57e27e5bd4da1b956
>   tools/libfsimage: Add `xen' to .h names and principal .so name
> honours an environment variable to override the directory where
> shared objects (ie filesystem plugins) are to be loaded from.
> 
> Rename that variable from FSIMAGE_FSDIR to XEN_FSIMAGE_FSDIR, to give
> it a proper namespace prefix.
> 
> Nothing in xen.git sets this variable.  The three hits for the string
> `FSIMAGE_FSDIR' are this getenv, and two references to a compile-time
> manifest constant which provides the default value (the -D which sets
> it, and the place it is used).
> 
> I have also checked the current Debian Xen package in buster and the
> variable is not set there either.
> 
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Juergen Gross <jgross@suse.com>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: George Dunlap <george.dunlap@citrix.com>
> CC: Anthony Perard <anthony.perard@citrix.com>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] tools/libfsimage: Add `XEN' to environment variable name

[Ian Jackson]

Juergen Gross writes ("Re: [PATCH] tools/libfsimage: Add `XEN' to environment variable name"):
> Release-acked-by: Juergen Gross <jgross@suse.com>

Thanks all, pushed.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel