From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5DAFC43334 for ; Mon, 20 Jun 2022 07:19:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B292C802EF; Mon, 20 Jun 2022 09:19:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="KZz3m2qu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BF31180166; Mon, 20 Jun 2022 09:19:06 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2075.outbound.protection.outlook.com [40.107.237.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 22D7B8058A for ; Mon, 20 Jun 2022 09:19:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nY9g8jty0qERqz/aONVxHhPQ55tQ+AZCQnhy3SdQEZmJpZxaWK4y9nQ1NpLSY2bopuDvv2uNkT+We5v2WhgBD0PnHduCReZ9Cnr8C5RmGXamMCWYMHmPyfc4AqqyeM4H5dS52VfNrOxywrw9rDdeJT/JFZW/X3bAPvRpOB7Ay9TTUVX2m2GiwaF28NxbxgSfqpnw2luLfkSY9L8qQFPqAjgU+su2invsUatkqKGwZxkrpcw82wijl3mrDfLQ4gUsOgfnTShaNoWqPoHHD7aTjVevpRLYqakS07R8GrOu2YNvl2e/QT0JixfN8OYok4zLiu7L442OAdHfSOx8HlmnEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OZwl6Zqm1rrt4zxDRHtn5+gNkrNwT/jMZOpjtmPZwso=; b=N6q80zKpj1NNH6AWCxQFScytgoM9Jl4hr08cJb1rAzbvspZCYn8zxeE2/78PTz4s/zip/yODwwgKxsBk2C1PO0H4ite5Vm+qspZEZ5qptnRDL9bX/6B2853LSCSEyQuMFIqzuzZ7ag6RkwzvL3V0v6G5KdkpO52r4d4HNRxxXcOqczKEYywk10LPw6H9ozYhcRbVQtNC2UEwIBSTpHPqhQBesY7890hWLPpFzfryBoX3NEbbYz+fK9plRdch/aaOimHqoU/80rSnAKxO1UWutrXlVI9sKmIUV2HlaTvM0X3PoNGBPCtlmdDyddtzB1ev9sCVM6NNZ6K0UDDJ76Uqsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=weidmueller.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OZwl6Zqm1rrt4zxDRHtn5+gNkrNwT/jMZOpjtmPZwso=; b=KZz3m2qudbYePTExhnEKFTcYdTjYSjEheos0wkhXsG4yvzQANJZxJ+UuCLQfqkfN4zKA95v/9i5swwTI1LJtl+wmp/OHMIKcX9rTCTQqShY0v6WvGMFbTN0Ghd9UIzTIdhpNen+cP3OhXNx88i0pNyfgjIjZQZHfLDGWMH39oaQ= Received: from DS7PR05CA0016.namprd05.prod.outlook.com (2603:10b6:5:3b9::21) by CH2PR12MB3671.namprd12.prod.outlook.com (2603:10b6:610:23::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Mon, 20 Jun 2022 07:18:58 +0000 Received: from DM6NAM11FT040.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b9:cafe::11) by DS7PR05CA0016.outlook.office365.com (2603:10b6:5:3b9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.13 via Frontend Transport; Mon, 20 Jun 2022 07:18:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT040.mail.protection.outlook.com (10.13.173.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5353.14 via Frontend Transport; Mon, 20 Jun 2022 07:18:58 +0000 Received: from [10.254.241.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 20 Jun 2022 02:18:56 -0500 Message-ID: <34e16b11-8e27-7557-aae3-795d49a4fc68@amd.com> Date: Mon, 20 Jun 2022 09:18:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 09/10] tools: zynqmp_psu_init_minimize: Add serdes_illcalib forward declaration Content-Language: en-US To: Stefan Herbrechtsmeier , CC: Stefan Herbrechtsmeier References: <20220608162054.25641-1-stefan.herbrechtsmeier-oss@weidmueller.com> <20220608162054.25641-10-stefan.herbrechtsmeier-oss@weidmueller.com> <56a77cbf-fee7-0439-ad3a-becb7c01a405@amd.com> <82df145c-fba9-a941-3f22-c9cb6afaeae7@weidmueller.com> From: Michal Simek In-Reply-To: <82df145c-fba9-a941-3f22-c9cb6afaeae7@weidmueller.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cc6ec661-54aa-476c-a3a0-08da528d24c2 X-MS-TrafficTypeDiagnostic: CH2PR12MB3671:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GkkBWCrWfQ0KZXApdAtVHxeMtkFsdHl+DN9q1Pl7EiarCWWnicM8BO39a5Omz4ne0oZgOMeHK5WZOYyo3B3Bjh9BtDDF+ey6eG2kFGQiowa9zvr/G1egp80E5gERV+UeFOtplM2nHXUDLsR/1eYRIw5s6KhmOQp0huz6Xwdfcjhcv25kDdMafTMTarUFABfgpxkrvIwcaoCXihkvbj+yc1QbYylJ3gMZwsV/6GA9MVxjmFOc4DES4g7xyrNkctSNlo3Y1j/aDqPhEHOy+CLhRCsq7zfx04++un34B/z5UdVNKQ8/Mfc70EfsyjJ8NUqFXnwvelL6pfxd4oCITuTeWeBJ8HWJVkyGhzvVqAJuRoJpyGuiapr41c/hp0VTFWFywpvXqTdr/NmIVGXFbNz2YavIjrTFd648pRRUmxzBY+lsVTfC06oQL2x+Dqg32VVSJheRwRTmR/BaugL+kGuzkgly+g7uWmdU05zzDrz85LcMfgYv4lRpF5Exv3EkuJHBdfTogylQYdWkeBH6I8cxvrM5iIrjCHJM3PCl0rQ5jEdhO2SrFLCI84dxflXjI8ayktfDzp8SzlE5gyo88G9sDlpHd+NfOk6vCe0bi5preLGH2SPKDRnmkcEdezNo7u1xhH68y4Oh97LoeNj0AlraB9ucOMA4gxd/MSaEgvemXo13plb6oykJ0f8MTchiupxQFHbQf0FpSOXi13WrlXubLxbgeYTovKVqGbjUUh/D06mua0GOCJpcaKHM8EE7jqlvjHMWrFDEyO1ZK3ZHIGTABg== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230016)(4636009)(396003)(39860400002)(376002)(136003)(346002)(40470700004)(36840700001)(46966006)(36756003)(8676002)(70206006)(70586007)(31686004)(4326008)(40480700001)(2906002)(426003)(186003)(110136005)(16526019)(336012)(478600001)(316002)(47076005)(8936002)(16576012)(40460700003)(31696002)(41300700001)(2616005)(53546011)(82310400005)(44832011)(36860700001)(26005)(5660300002)(86362001)(82740400003)(356005)(81166007)(6666004)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 07:18:58.6011 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cc6ec661-54aa-476c-a3a0-08da528d24c2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT040.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3671 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 6/20/22 09:07, Stefan Herbrechtsmeier wrote: > Am 16.06.2022 um 17:13 schrieb Michal Simek: >> On 6/8/22 18:20, Stefan Herbrechtsmeier wrote: >>> [CAUTION: External Email] >>> >>> From: Stefan Herbrechtsmeier >>> >>> A forward declaration for the serdes_illcalib function. >>> >>> Signed-off-by: Stefan Herbrechtsmeier >>> --- >>> >>>   tools/zynqmp_psu_init_minimize.sh | 5 +++++ >>>   1 file changed, 5 insertions(+) >>> >>> diff --git a/tools/zynqmp_psu_init_minimize.sh >>> b/tools/zynqmp_psu_init_minimize.sh >>> index 31fbeac327..8411065e13 100755 >>> --- a/tools/zynqmp_psu_init_minimize.sh >>> +++ b/tools/zynqmp_psu_init_minimize.sh >>> @@ -108,6 +108,11 @@ cat << EOF >${TMP} >>>   #include >>>   #include >>> >>> +static int serdes_illcalib(u32 lane3_protocol, u32 lane3_rate, >>> +                          u32 lane2_protocol, u32 lane2_rate, >>> +                          u32 lane1_protocol, u32 lane1_rate, >>> +                          u32 lane0_protocol, u32 lane0_rate); >>> + >> >> Better to resort that functions to avoid these additional lines. > > Do you propose to move the serdes_illcalib and serdes_illcalib_pcie_gen1 > functions via sed? swapping that functions should be enough. Whatever tool which does this job is fine. > > The psu_init_gpl.c for e-a2197-00-revA, zcu208-revA and zcu216-revA already use > a forward declaration. Would it be okay to add the forward declaration if the > function is used inside the source file? Better to just fix this. Can you please send the patch? Thanks, Michal