All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>
To: Alberto Garcia <berto@igalia.com>, Markus Armbruster <armbru@redhat.com>
Cc: Pradeep Jagadeesh <pradeepkiruvale@gmail.com>,
	jani kokkonen <jani.kokkonen@huawei.com>,
	greg kurz <groug@kaod.org>,
	qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure
Date: Tue, 8 Aug 2017 14:30:43 +0200	[thread overview]
Message-ID: <34e45421-0b22-15b4-deb7-980f26e5ca23@huawei.com> (raw)
In-Reply-To: <w511soml2kh.fsf@maestria.local.igalia.com>

On 8/8/2017 1:30 PM, Alberto Garcia wrote:
> On Mon 07 Aug 2017 04:48:38 PM CEST, Markus Armbruster wrote:
>>>> Awkward question for a v7, but here goes anyway: why is IOThrottle
>>>> worth its very own .json file?
>>> I feel this is a common throttle structure that is used by block
>>> devices as well as fsdev, so moved to a separate file.
>> I'm not sure that's a good idea.  Kevin, Berto, what do you think?
>
> Mmm... I don't have a very strong opinion, but if there's no actual need
> to move it to a separate file I'd prefer to leave it where it is.
The segregation is the solid reason. Because throttling is a feature 
that is used by fsdev, block may many more in future. I do not see 
moving it back to block does it make any sense?

Regards,
Pradeep

>
> Berto
>

  reply	other threads:[~2017-08-08 12:32 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-04 15:30 [Qemu-devel] [PATCH v7 0/6] fsdev: qmp interface for io throttling Pradeep Jagadeesh
2017-07-04 15:30 ` [Qemu-devel] [PATCH v7 1/6] throttle: factor out duplicate code Pradeep Jagadeesh
2017-07-10 14:33   ` Greg Kurz
2017-07-10 14:41   ` Eric Blake
2017-08-07  9:44     ` Pradeep Jagadeesh
2017-07-04 15:30 ` [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure Pradeep Jagadeesh
2017-07-06 17:55   ` Markus Armbruster
2017-08-07  9:59     ` Pradeep Jagadeesh
2017-08-07 14:48       ` Markus Armbruster
2017-08-08 11:30         ` Alberto Garcia
2017-08-08 12:30           ` Pradeep Jagadeesh [this message]
2017-08-08 14:33             ` Alberto Garcia
2017-08-08 15:18               ` Markus Armbruster
2017-08-10 14:06                 ` Pradeep Jagadeesh
2017-08-10 15:14                   ` Eric Blake
2017-08-10 16:25                     ` Markus Armbruster
2017-08-16 16:13                       ` Markus Armbruster
2017-08-16 17:13                         ` Eric Blake
2017-08-16 18:11                           ` Markus Armbruster
     [not found]                             ` <CAJ2SuLnH9dvfWs1XX-Pd+GE9s0kZP_3LkMs_Crt9QTkz48NsyA@mail.gmail.com>
     [not found]                               ` <CAJ2SuL=F3oAA6KbURSQRaqNS_DPSZ7tGOjgEcgNkfzdXxw7tTQ@mail.gmail.com>
2017-08-19  1:16                                 ` Pradeep Kiruvale
2017-07-04 15:31 ` [Qemu-devel] [PATCH v7 3/6] throttle: move out function to reuse the code Pradeep Jagadeesh
2017-07-04 15:31 ` [Qemu-devel] [PATCH v7 4/6] hmp: create a throttle initialization function for code reusability Pradeep Jagadeesh
2017-07-04 15:31 ` [Qemu-devel] [PATCH v7 5/6] fsdev: hmp interface for throttling Pradeep Jagadeesh
2017-07-05 10:45   ` Dr. David Alan Gilbert
2017-07-06 18:15   ` Markus Armbruster
2017-08-07  9:57     ` Pradeep Jagadeesh
2017-07-04 15:31 ` [Qemu-devel] [PATCH v7 6/6] fsdev: QMP " Pradeep Jagadeesh
2017-07-06 18:47   ` Markus Armbruster
2017-07-07 14:50     ` Pradeep Jagadeesh
2017-08-07  9:35     ` Pradeep Jagadeesh
2017-08-07 14:54       ` Markus Armbruster
2017-07-07  6:14 ` [Qemu-devel] [PATCH v7 0/6] fsdev: qmp interface for io throttling Markus Armbruster
2017-07-07  6:24   ` Markus Armbruster
2017-07-07 13:16   ` Pradeep Jagadeesh
2017-08-07  7:52   ` Pradeep Jagadeesh
2017-08-07 14:55     ` Markus Armbruster
2017-07-14 12:22 ` Manos Pitsidianakis
2017-07-14 13:15   ` Pradeep Jagadeesh
2017-07-14 14:26     ` Manos Pitsidianakis
2017-07-14 15:27       ` Pradeep Jagadeesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34e45421-0b22-15b4-deb7-980f26e5ca23@huawei.com \
    --to=pradeep.jagadeesh@huawei.com \
    --cc=armbru@redhat.com \
    --cc=berto@igalia.com \
    --cc=groug@kaod.org \
    --cc=jani.kokkonen@huawei.com \
    --cc=kwolf@redhat.com \
    --cc=pradeepkiruvale@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.