From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E09C433F5 for ; Tue, 7 Sep 2021 08:11:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3674660C51 for ; Tue, 7 Sep 2021 08:11:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240530AbhIGIMc (ORCPT ); Tue, 7 Sep 2021 04:12:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239792AbhIGIMb (ORCPT ); Tue, 7 Sep 2021 04:12:31 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C213EC061575 for ; Tue, 7 Sep 2021 01:11:25 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNWCM-0005c2-JH; Tue, 07 Sep 2021 10:11:18 +0200 Message-ID: <34ee3657e859a0abaca5021d2afd38f320dd8e69.camel@pengutronix.de> Subject: Re: [PATCH v3 09/18] dt-bindings: power: imx8mm: add defines for VPU blk-ctrl domains From: Lucas Stach To: Frieder Schrempf , Shawn Guo Cc: Rob Herring , Fabio Estevam , NXP Linux Team , Adam Ford , Marek Vasut , Tim Harvey , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, patchwork-lst@pengutronix.de Date: Tue, 07 Sep 2021 10:11:16 +0200 In-Reply-To: References: <20210906184333.1855426-1-l.stach@pengutronix.de> <20210906184333.1855426-10-l.stach@pengutronix.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Dienstag, dem 07.09.2021 um 09:06 +0200 schrieb Frieder Schrempf: > On 06.09.21 20:43, Lucas Stach wrote: > > This adds the defines for the power domains provided by the VPU > > blk-ctrl. > > > > Signed-off-by: Lucas Stach > > --- > > include/dt-bindings/power/imx8mm-power.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/include/dt-bindings/power/imx8mm-power.h b/include/dt-bindings/power/imx8mm-power.h > > index fc9c2e16aadc..38b0a56fd7d0 100644 > > --- a/include/dt-bindings/power/imx8mm-power.h > > +++ b/include/dt-bindings/power/imx8mm-power.h > > @@ -19,4 +19,8 @@ > > #define IMX8MM_POWER_DOMAIN_DISPMIX 10 > > #define IMX8MM_POWER_DOMAIN_MIPI 11 > > > > +#define IMX8MM_VPUBLK_PD_G1 0 > > +#define IMX8MM_VPUBLK_PD_G2 1 > > +#define IMX8MM_VPUBLK_PD_H1 2 > > I wonder how these defines should be named. Here you have a > IMX8MM_*BLK_PD_*, but for the DISP BLK-CTRL you only have IMX8MM_*BLK_* > (without the PD). > > Also in Peng's last approach for this we already have defines for this > [1] that have been acked by Rob and might be useful as a reference or > you could even pick up Peng's patch and by that carry over the existing > R-b/A-b tags. > > Though, in general I like the shorter versions you provided better. Good point, we should try to be consistent here. I don't want those names to be overly long, but it should be clear that those are power domain specifiers. IMO the best option is the *BLK_PD* naming, as used in the VPUMIX binding. Regards, Lucas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 282CBC433EF for ; Tue, 7 Sep 2021 08:13:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2CA560F21 for ; Tue, 7 Sep 2021 08:13:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E2CA560F21 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PGQaO7ZaebUS7V6AM77mACSaTi4L/2ZJTlYpr8ncu/I=; b=1VF5DvimYFVep1 733V7evBVoWNfdbffA1ONi0a8F3Q5MAsVr6TW7f8xB3tlEY2nuF1ww8q6dcAR2njtOFtTRIDsUpV4 FIIb2Cg/a2s3ldzUK3994dw+sbFk7bYnG6nMRWej2zNBOzPxfpx0li+3NKVLPaiVit67zJjHP3Qxv BkTjVOOKk4WAPi0Gi8Qxr090ZERsRkauCCIEbszjiSG0ZuiSLimqfZczBPJGfwoGnLwze/Vxb8Ep6 2fyn8thBcK7sWiyAi1YC7TY7h0GesNmXmaDaY2Wfyk9mAIfvVVNqXJJVeppyGDjKsFER+laNw2tNS uh/pUBzktMuLcOgsnENA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNWCX-002pcD-Ay; Tue, 07 Sep 2021 08:11:29 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNWCT-002pax-Vz for linux-arm-kernel@lists.infradead.org; Tue, 07 Sep 2021 08:11:27 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNWCM-0005c2-JH; Tue, 07 Sep 2021 10:11:18 +0200 Message-ID: <34ee3657e859a0abaca5021d2afd38f320dd8e69.camel@pengutronix.de> Subject: Re: [PATCH v3 09/18] dt-bindings: power: imx8mm: add defines for VPU blk-ctrl domains From: Lucas Stach To: Frieder Schrempf , Shawn Guo Cc: Rob Herring , Fabio Estevam , NXP Linux Team , Adam Ford , Marek Vasut , Tim Harvey , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, patchwork-lst@pengutronix.de Date: Tue, 07 Sep 2021 10:11:16 +0200 In-Reply-To: References: <20210906184333.1855426-1-l.stach@pengutronix.de> <20210906184333.1855426-10-l.stach@pengutronix.de> User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_011126_097918_554D0E6B X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, dem 07.09.2021 um 09:06 +0200 schrieb Frieder Schrempf: > On 06.09.21 20:43, Lucas Stach wrote: > > This adds the defines for the power domains provided by the VPU > > blk-ctrl. > > > > Signed-off-by: Lucas Stach > > --- > > include/dt-bindings/power/imx8mm-power.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/include/dt-bindings/power/imx8mm-power.h b/include/dt-bindings/power/imx8mm-power.h > > index fc9c2e16aadc..38b0a56fd7d0 100644 > > --- a/include/dt-bindings/power/imx8mm-power.h > > +++ b/include/dt-bindings/power/imx8mm-power.h > > @@ -19,4 +19,8 @@ > > #define IMX8MM_POWER_DOMAIN_DISPMIX 10 > > #define IMX8MM_POWER_DOMAIN_MIPI 11 > > > > +#define IMX8MM_VPUBLK_PD_G1 0 > > +#define IMX8MM_VPUBLK_PD_G2 1 > > +#define IMX8MM_VPUBLK_PD_H1 2 > > I wonder how these defines should be named. Here you have a > IMX8MM_*BLK_PD_*, but for the DISP BLK-CTRL you only have IMX8MM_*BLK_* > (without the PD). > > Also in Peng's last approach for this we already have defines for this > [1] that have been acked by Rob and might be useful as a reference or > you could even pick up Peng's patch and by that carry over the existing > R-b/A-b tags. > > Though, in general I like the shorter versions you provided better. Good point, we should try to be consistent here. I don't want those names to be overly long, but it should be clear that those are power domain specifiers. IMO the best option is the *BLK_PD* naming, as used in the VPUMIX binding. Regards, Lucas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel