From: Quentin Monnet <quentin@isovalent.com>
To: Jakub Wilk <jwilk@jwilk.net>,
bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: linux-man@vger.kernel.org, Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: [PATCH v2] bpf: Fix reStructuredText markup
Date: Thu, 23 Apr 2020 10:07:29 +0100 [thread overview]
Message-ID: <34f41c96-86c0-2ca9-3be9-75c59f803bc3@isovalent.com> (raw)
In-Reply-To: <20200422082324.2030-1-jwilk@jwilk.net>
2020-04-22 10:23 UTC+0200 ~ Jakub Wilk <jwilk@jwilk.net>
> Fixes:
>
> $ scripts/bpf_helpers_doc.py > bpf-helpers.rst
> $ rst2man bpf-helpers.rst > bpf-helpers.7
> bpf-helpers.rst:1105: (WARNING/2) Inline strong start-string without end-string.
>
> Signed-off-by: Jakub Wilk <jwilk@jwilk.net>
> ---
> v2: "flags" should be italic, not bold
>
> include/uapi/linux/bpf.h | 2 +-
> tools/include/uapi/linux/bpf.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index 2e29a671d67e..7bbf1b65be10 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -1642,7 +1642,7 @@ union bpf_attr {
> * ifindex, but doesn't require a map to do so.
> * Return
> * **XDP_REDIRECT** on success, or the value of the two lower bits
> - * of the **flags* argument on error.
> + * of the *flags* argument on error.
> *
> * int bpf_sk_redirect_map(struct sk_buff *skb, struct bpf_map *map, u32 key, u64 flags)
> * Description
> diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
> index 2e29a671d67e..7bbf1b65be10 100644
> --- a/tools/include/uapi/linux/bpf.h
> +++ b/tools/include/uapi/linux/bpf.h
> @@ -1642,7 +1642,7 @@ union bpf_attr {
> * ifindex, but doesn't require a map to do so.
> * Return
> * **XDP_REDIRECT** on success, or the value of the two lower bits
> - * of the **flags* argument on error.
> + * of the *flags* argument on error.
> *
> * int bpf_sk_redirect_map(struct sk_buff *skb, struct bpf_map *map, u32 key, u64 flags)
> * Description
>
I was about to send the same :). Thanks!
Reviewed-by: Quentin Monnet <quentin@isovalent.com>
next prev parent reply other threads:[~2020-04-23 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 14:47 [PATCH] bpf: Fix reStructuredText markup Jakub Wilk
2020-04-22 8:23 ` [PATCH v2] " Jakub Wilk
2020-04-23 9:07 ` Quentin Monnet [this message]
2020-04-25 0:09 ` [PATCH] " Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34f41c96-86c0-2ca9-3be9-75c59f803bc3@isovalent.com \
--to=quentin@isovalent.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jwilk@jwilk.net \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.