All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] mtest01: fix max_pids formula
@ 2017-05-03 12:00 Jan Stancek
  2017-05-03 12:44 ` Cyril Hrubis
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Stancek @ 2017-05-03 12:00 UTC (permalink / raw)
  To: ltp

Values returned by sysinfo() are in multiple of mem_unit bytes.

Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
 testcases/kernel/mem/mtest01/mtest01.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testcases/kernel/mem/mtest01/mtest01.c b/testcases/kernel/mem/mtest01/mtest01.c
index f3fba044c529..6225d7d7b671 100644
--- a/testcases/kernel/mem/mtest01/mtest01.c
+++ b/testcases/kernel/mem/mtest01/mtest01.c
@@ -152,7 +152,8 @@ int main(int argc, char *argv[])
 	total_free = sstats.freeram + sstats.freeswap;
 	/* Total Free Pre-Test RAM */
 	pre_mem = sstats.mem_unit * total_free;
-	max_pids = total_ram / (unsigned long)FIVE_HUNDRED_MB + 10;
+	max_pids = total_ram * sstats.mem_unit
+		/ (unsigned long)FIVE_HUNDRED_MB + 10;
 
 	if ((pid_list = malloc(max_pids * sizeof(pid_t))) == NULL)
 		tst_brkm(TBROK | TERRNO, NULL, "malloc failed.");
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [LTP] [PATCH] mtest01: fix max_pids formula
  2017-05-03 12:00 [LTP] [PATCH] mtest01: fix max_pids formula Jan Stancek
@ 2017-05-03 12:44 ` Cyril Hrubis
  2017-05-03 12:51   ` Jan Stancek
  0 siblings, 1 reply; 3+ messages in thread
From: Cyril Hrubis @ 2017-05-03 12:44 UTC (permalink / raw)
  To: ltp

Hi!
> Values returned by sysinfo() are in multiple of mem_unit bytes.
> 
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> ---
>  testcases/kernel/mem/mtest01/mtest01.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/mem/mtest01/mtest01.c b/testcases/kernel/mem/mtest01/mtest01.c
> index f3fba044c529..6225d7d7b671 100644
> --- a/testcases/kernel/mem/mtest01/mtest01.c
> +++ b/testcases/kernel/mem/mtest01/mtest01.c
> @@ -152,7 +152,8 @@ int main(int argc, char *argv[])
>  	total_free = sstats.freeram + sstats.freeswap;
>  	/* Total Free Pre-Test RAM */
>  	pre_mem = sstats.mem_unit * total_free;
> -	max_pids = total_ram / (unsigned long)FIVE_HUNDRED_MB + 10;
> +	max_pids = total_ram * sstats.mem_unit
> +		/ (unsigned long)FIVE_HUNDRED_MB + 10;

Looks OK.

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [LTP] [PATCH] mtest01: fix max_pids formula
  2017-05-03 12:44 ` Cyril Hrubis
@ 2017-05-03 12:51   ` Jan Stancek
  0 siblings, 0 replies; 3+ messages in thread
From: Jan Stancek @ 2017-05-03 12:51 UTC (permalink / raw)
  To: ltp



----- Original Message -----
> Hi!
> > Values returned by sysinfo() are in multiple of mem_unit bytes.
> > 
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
> > ---
> >  testcases/kernel/mem/mtest01/mtest01.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/testcases/kernel/mem/mtest01/mtest01.c
> > b/testcases/kernel/mem/mtest01/mtest01.c
> > index f3fba044c529..6225d7d7b671 100644
> > --- a/testcases/kernel/mem/mtest01/mtest01.c
> > +++ b/testcases/kernel/mem/mtest01/mtest01.c
> > @@ -152,7 +152,8 @@ int main(int argc, char *argv[])
> >  	total_free = sstats.freeram + sstats.freeswap;
> >  	/* Total Free Pre-Test RAM */
> >  	pre_mem = sstats.mem_unit * total_free;
> > -	max_pids = total_ram / (unsigned long)FIVE_HUNDRED_MB + 10;
> > +	max_pids = total_ram * sstats.mem_unit
> > +		/ (unsigned long)FIVE_HUNDRED_MB + 10;
> 
> Looks OK.

Pushed.

Regards,
Jan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-03 12:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-03 12:00 [LTP] [PATCH] mtest01: fix max_pids formula Jan Stancek
2017-05-03 12:44 ` Cyril Hrubis
2017-05-03 12:51   ` Jan Stancek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.