From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C16C00144 for ; Mon, 1 Aug 2022 14:26:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231416AbiHAO0X (ORCPT ); Mon, 1 Aug 2022 10:26:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232547AbiHAO0S (ORCPT ); Mon, 1 Aug 2022 10:26:18 -0400 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 390EE27B19 for ; Mon, 1 Aug 2022 07:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jdl0neQFEwslAPL0Xr+d7m5DRmkVE7MWA6Ch3NRMkb4=; b=iISIOWfbioAAFSye3WBrO9ap/Y ZUPH7SsN3oZC7xpZKD2Hd0W80y7T5bmzOYFGjzWPT3/ybMwnbHPYtCEJzAtIL8kNUNt7LQAHBgCNa Q47r+sZik4DH34TskHKz7od1UUQ+F7maadNzg2PwEtOS4507aZBbTZWDijJYkUiwb6SpPBCWOgbZr 7wsimOh/koYFJS68b7S0AXVkU8hzfpwXwefMYNF35B+dBMx/PRgJHWXLGicONMA4nJqpwh2tLyOtp HrwQe529N1CN7lrBBJzalMpVRgYmdk5Sln6Pgn8WwS4xQIox88pRyYhdroV9OR3+pUd7EyrVU/8ps g77urFbg==; Received: from [187.56.70.103] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1oIWMi-00DqPK-AP; Mon, 01 Aug 2022 16:25:52 +0200 Message-ID: <3509f2c9-2ab9-c1f5-8c27-ab8be771360d@igalia.com> Date: Mon, 1 Aug 2022 11:25:34 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH -next] panic: Add register_panic_notifier and unregister_panic_notifier Content-Language: en-US To: "xuqiang (M)" , "pmladek@suse.com" , "akpm@linux-foundation.org" , "elver@google.com" , "mcgrof@kernel.org" , "tangmeng@uniontech.com" , "yangtiezhu@loongson.cn" , "john.ogness@linutronix.de" , "bigeasy@linutronix.de" Cc: "linux-kernel@vger.kernel.org" , "Guohanjun (Hanjun Guo)" , "weiyongjun (A)" References: <20220801100509.62282-1-xuqiang36@huawei.com> <2d4fa03a-f460-d995-88e8-7f0e58e557bd@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/08/2022 10:58, xuqiang (M) wrote: > 在 2022/8/1 20:12, Guilherme G. Piccoli 写道: >> On 01/08/2022 07:05, Xu Qiang wrote: >>> Add two methods to manipulate panic_notifier_list and export them. >>> Subsequently, panic_notifier_list is changed to static variable. >>> >>> Signed-off-by: Xu Qiang >> Hi Xu Qiang, first of all, thanks for your patch! >> I'd like to mention 2 things about it: >> >> (a) As-is, there's no much use for it - I mean, you're adding a helper >> but you didn't change the uses of such notifier list addition (and there >> are plenty of them). Are you intend to change it, or just use the new >> API in new calls? > After this patch comes in, I will replace all the old interfaces with > the new ones. >> >> (b) Even more important: we are working in a panic notifier refactor >> [0], and that'll add new lists. I'm still working on that, plan to >> submit (relatively) soon. Maybe worth to wait it, if this one is not urgent? > I can wait for your patch to be incorporated before submitting it. Great, thanks Xu! I'll include you in the CC list of the V2 =)