From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S946335AbcJaUMt (ORCPT ); Mon, 31 Oct 2016 16:12:49 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:35520 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S946256AbcJaUMr (ORCPT ); Mon, 31 Oct 2016 16:12:47 -0400 Subject: Re: [PATCH v1 1/3] dt-bindings: Document Broadcom OTP controller driver To: Rob Herring References: <1477336324-10543-1-git-send-email-jonathan.richardson@broadcom.com> <1477336324-10543-2-git-send-email-jonathan.richardson@broadcom.com> <20161031013848.4vi2544tb5cs65nk@rob-hp-laptop> Cc: Srinivas Kandagatla , Maxime Ripard , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Mark Rutland , Scott Branden , Ray Jui , bcm-kernel-feedback-list@broadcom.com, Jonathan Richardson , Scott Branden , Oza Pawandeep From: Jonathan Richardson Message-ID: <350b2f50-29dd-6a96-62af-b5c973322298@broadcom.com> Date: Mon, 31 Oct 2016 13:12:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161031013848.4vi2544tb5cs65nk@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-10-30 06:38 PM, Rob Herring wrote: > On Mon, Oct 24, 2016 at 12:12:02PM -0700, Jonathan Richardson wrote: >> From: Jonathan Richardson >> >> Reviewed-by: Ray Jui >> Tested-by: Jonathan Richardson >> Signed-off-by: Scott Branden >> Signed-off-by: Oza Pawandeep >> Signed-off-by: Jonathan Richardson >> --- >> Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt >> >> diff --git a/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt b/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt >> new file mode 100644 >> index 0000000..6462e12 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt >> @@ -0,0 +1,17 @@ >> +Broadcom OTP memory controller >> + >> +Required Properties: >> +- compatible: "brcm,ocotp" for the first generation Broadcom OTPC which is used >> + in Cygnus and supports 32 bit read/write. Use "brcm,ocotp-v2" for the second >> + generation Broadcom OTPC which is used in SoC's such as Stingray and supports >> + 64-bit read/write. > > These should be SoC specific. While I'd guess this block is simple > enough, having the SoC can define what all the bits are. Yes, there is a > binding to define those, but you may not use that. Hi Rob. This block isn't SoC specific. It is used on multiple SoC's. There are older SoC's using v1 that we may upstream drivers for in the future. v1 isn't specific to cygnus/iproc and v2 isn't specific to stingray. > > >> +- reg: Base address of the OTP controller. >> +- brcm,ocotp-size: Amount of memory available, in 32 bit words >> + >> +Example: >> + >> +otp: otp@0301c800 { >> + compatible = "brcm,ocotp"; >> + reg = <0x0301c800 0x2c>; >> + brcm,ocotp-size = <2048>; >> +}; >> -- >> 1.9.1 >> From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Richardson Subject: Re: [PATCH v1 1/3] dt-bindings: Document Broadcom OTP controller driver Date: Mon, 31 Oct 2016 13:12:43 -0700 Message-ID: <350b2f50-29dd-6a96-62af-b5c973322298@broadcom.com> References: <1477336324-10543-1-git-send-email-jonathan.richardson@broadcom.com> <1477336324-10543-2-git-send-email-jonathan.richardson@broadcom.com> <20161031013848.4vi2544tb5cs65nk@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161031013848.4vi2544tb5cs65nk@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Srinivas Kandagatla , Maxime Ripard , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Rutland , Scott Branden , Ray Jui , bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Jonathan Richardson , Scott Branden , Oza Pawandeep List-Id: devicetree@vger.kernel.org On 16-10-30 06:38 PM, Rob Herring wrote: > On Mon, Oct 24, 2016 at 12:12:02PM -0700, Jonathan Richardson wrote: >> From: Jonathan Richardson >> >> Reviewed-by: Ray Jui >> Tested-by: Jonathan Richardson >> Signed-off-by: Scott Branden >> Signed-off-by: Oza Pawandeep >> Signed-off-by: Jonathan Richardson >> --- >> Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt >> >> diff --git a/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt b/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt >> new file mode 100644 >> index 0000000..6462e12 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt >> @@ -0,0 +1,17 @@ >> +Broadcom OTP memory controller >> + >> +Required Properties: >> +- compatible: "brcm,ocotp" for the first generation Broadcom OTPC which is used >> + in Cygnus and supports 32 bit read/write. Use "brcm,ocotp-v2" for the second >> + generation Broadcom OTPC which is used in SoC's such as Stingray and supports >> + 64-bit read/write. > > These should be SoC specific. While I'd guess this block is simple > enough, having the SoC can define what all the bits are. Yes, there is a > binding to define those, but you may not use that. Hi Rob. This block isn't SoC specific. It is used on multiple SoC's. There are older SoC's using v1 that we may upstream drivers for in the future. v1 isn't specific to cygnus/iproc and v2 isn't specific to stingray. > > >> +- reg: Base address of the OTP controller. >> +- brcm,ocotp-size: Amount of memory available, in 32 bit words >> + >> +Example: >> + >> +otp: otp@0301c800 { >> + compatible = "brcm,ocotp"; >> + reg = <0x0301c800 0x2c>; >> + brcm,ocotp-size = <2048>; >> +}; >> -- >> 1.9.1 >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: jonathan.richardson@broadcom.com (Jonathan Richardson) Date: Mon, 31 Oct 2016 13:12:43 -0700 Subject: [PATCH v1 1/3] dt-bindings: Document Broadcom OTP controller driver In-Reply-To: <20161031013848.4vi2544tb5cs65nk@rob-hp-laptop> References: <1477336324-10543-1-git-send-email-jonathan.richardson@broadcom.com> <1477336324-10543-2-git-send-email-jonathan.richardson@broadcom.com> <20161031013848.4vi2544tb5cs65nk@rob-hp-laptop> Message-ID: <350b2f50-29dd-6a96-62af-b5c973322298@broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 16-10-30 06:38 PM, Rob Herring wrote: > On Mon, Oct 24, 2016 at 12:12:02PM -0700, Jonathan Richardson wrote: >> From: Jonathan Richardson >> >> Reviewed-by: Ray Jui >> Tested-by: Jonathan Richardson >> Signed-off-by: Scott Branden >> Signed-off-by: Oza Pawandeep >> Signed-off-by: Jonathan Richardson >> --- >> Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt >> >> diff --git a/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt b/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt >> new file mode 100644 >> index 0000000..6462e12 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt >> @@ -0,0 +1,17 @@ >> +Broadcom OTP memory controller >> + >> +Required Properties: >> +- compatible: "brcm,ocotp" for the first generation Broadcom OTPC which is used >> + in Cygnus and supports 32 bit read/write. Use "brcm,ocotp-v2" for the second >> + generation Broadcom OTPC which is used in SoC's such as Stingray and supports >> + 64-bit read/write. > > These should be SoC specific. While I'd guess this block is simple > enough, having the SoC can define what all the bits are. Yes, there is a > binding to define those, but you may not use that. Hi Rob. This block isn't SoC specific. It is used on multiple SoC's. There are older SoC's using v1 that we may upstream drivers for in the future. v1 isn't specific to cygnus/iproc and v2 isn't specific to stingray. > > >> +- reg: Base address of the OTP controller. >> +- brcm,ocotp-size: Amount of memory available, in 32 bit words >> + >> +Example: >> + >> +otp: otp at 0301c800 { >> + compatible = "brcm,ocotp"; >> + reg = <0x0301c800 0x2c>; >> + brcm,ocotp-size = <2048>; >> +}; >> -- >> 1.9.1 >>