* [PATCH] kasan, mm: fix build issue with asmlinkage
@ 2020-11-26 15:00 ` Valdis Klētnieks
0 siblings, 0 replies; 6+ messages in thread
From: Valdis Klētnieks @ 2020-11-26 15:00 UTC (permalink / raw)
To: Russell King - ARM Linux admin, Andrey Ryabinin
Cc: kasan-dev, linux-arm-kernel, linux-kernel
commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
Author: Andrey Konovalov <andreyknvl@google.com>
Date: Tue Nov 24 16:45:08 2020 +1100
kasan: shadow declarations only for software modes
introduces a build failure when it removed an include for linux/pgtable.h
It actually only needs linux/linkage.h
Test builds on both x86_64 and arm build cleanly
Fixes: 2df573d2ca4c ("kasan: shadow declarations only for software modes")
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
---
diff --git a/include/linux/kasan.h b/include/linux/kasan.h
index 83860aa4e89c..5e0655fb2a6f 100644
--- a/include/linux/kasan.h
+++ b/include/linux/kasan.h
@@ -12,6 +12,7 @@ struct task_struct;
#ifdef CONFIG_KASAN
+#include <linux/linkage.h>
#include <asm/kasan.h>
/* kasan_data struct is used in KUnit tests for KASAN expected failures */
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] kasan, mm: fix build issue with asmlinkage
@ 2020-11-26 15:00 ` Valdis Klētnieks
0 siblings, 0 replies; 6+ messages in thread
From: Valdis Klētnieks @ 2020-11-26 15:00 UTC (permalink / raw)
To: Russell King - ARM Linux admin, Andrey Ryabinin
Cc: linux-arm-kernel, kasan-dev, linux-kernel
commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
Author: Andrey Konovalov <andreyknvl@google.com>
Date: Tue Nov 24 16:45:08 2020 +1100
kasan: shadow declarations only for software modes
introduces a build failure when it removed an include for linux/pgtable.h
It actually only needs linux/linkage.h
Test builds on both x86_64 and arm build cleanly
Fixes: 2df573d2ca4c ("kasan: shadow declarations only for software modes")
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
---
diff --git a/include/linux/kasan.h b/include/linux/kasan.h
index 83860aa4e89c..5e0655fb2a6f 100644
--- a/include/linux/kasan.h
+++ b/include/linux/kasan.h
@@ -12,6 +12,7 @@ struct task_struct;
#ifdef CONFIG_KASAN
+#include <linux/linkage.h>
#include <asm/kasan.h>
/* kasan_data struct is used in KUnit tests for KASAN expected failures */
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] kasan, mm: fix build issue with asmlinkage
2020-11-26 15:00 ` Valdis Klētnieks
@ 2020-11-30 9:46 ` Marco Elver
-1 siblings, 0 replies; 6+ messages in thread
From: Marco Elver @ 2020-11-30 9:46 UTC (permalink / raw)
To: Valdis Klētnieks, Andrew Morton, Andrey Konovalov
Cc: Russell King - ARM Linux admin, Andrey Ryabinin, kasan-dev,
Linux ARM, LKML
On Thu, 26 Nov 2020 at 16:00, Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
> commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
> Author: Andrey Konovalov <andreyknvl@google.com>
> Date: Tue Nov 24 16:45:08 2020 +1100
>
> kasan: shadow declarations only for software modes
>
> introduces a build failure when it removed an include for linux/pgtable.h
> It actually only needs linux/linkage.h
>
> Test builds on both x86_64 and arm build cleanly
>
> Fixes: 2df573d2ca4c ("kasan: shadow declarations only for software modes")
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Marco Elver <elver@google.com>
Probably want to add
Link: https://lore.kernel.org/linux-arm-kernel/24105.1606397102@turing-police/
for more context, too.
Thanks,
-- Marco
> ---
> diff --git a/include/linux/kasan.h b/include/linux/kasan.h
> index 83860aa4e89c..5e0655fb2a6f 100644
> --- a/include/linux/kasan.h
> +++ b/include/linux/kasan.h
> @@ -12,6 +12,7 @@ struct task_struct;
>
> #ifdef CONFIG_KASAN
>
> +#include <linux/linkage.h>
> #include <asm/kasan.h>
>
> /* kasan_data struct is used in KUnit tests for KASAN expected failures */
>
>
> --
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/35126.1606402815%40turing-police.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kasan, mm: fix build issue with asmlinkage
@ 2020-11-30 9:46 ` Marco Elver
0 siblings, 0 replies; 6+ messages in thread
From: Marco Elver @ 2020-11-30 9:46 UTC (permalink / raw)
To: Valdis Klētnieks, Andrew Morton, Andrey Konovalov
Cc: Linux ARM, Andrey Ryabinin, Russell King - ARM Linux admin,
kasan-dev, LKML
On Thu, 26 Nov 2020 at 16:00, Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
> commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
> Author: Andrey Konovalov <andreyknvl@google.com>
> Date: Tue Nov 24 16:45:08 2020 +1100
>
> kasan: shadow declarations only for software modes
>
> introduces a build failure when it removed an include for linux/pgtable.h
> It actually only needs linux/linkage.h
>
> Test builds on both x86_64 and arm build cleanly
>
> Fixes: 2df573d2ca4c ("kasan: shadow declarations only for software modes")
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Marco Elver <elver@google.com>
Probably want to add
Link: https://lore.kernel.org/linux-arm-kernel/24105.1606397102@turing-police/
for more context, too.
Thanks,
-- Marco
> ---
> diff --git a/include/linux/kasan.h b/include/linux/kasan.h
> index 83860aa4e89c..5e0655fb2a6f 100644
> --- a/include/linux/kasan.h
> +++ b/include/linux/kasan.h
> @@ -12,6 +12,7 @@ struct task_struct;
>
> #ifdef CONFIG_KASAN
>
> +#include <linux/linkage.h>
> #include <asm/kasan.h>
>
> /* kasan_data struct is used in KUnit tests for KASAN expected failures */
>
>
> --
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/35126.1606402815%40turing-police.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kasan, mm: fix build issue with asmlinkage
2020-11-30 9:46 ` Marco Elver
@ 2020-11-30 15:21 ` Andrey Konovalov
-1 siblings, 0 replies; 6+ messages in thread
From: Andrey Konovalov @ 2020-11-30 15:21 UTC (permalink / raw)
To: Valdis Klētnieks
Cc: Andrew Morton, Russell King - ARM Linux admin, Andrey Ryabinin,
kasan-dev, Linux ARM, LKML, Marco Elver
On Mon, Nov 30, 2020 at 10:46 AM Marco Elver <elver@google.com> wrote:
>
> On Thu, 26 Nov 2020 at 16:00, Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
> > commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
> > Author: Andrey Konovalov <andreyknvl@google.com>
> > Date: Tue Nov 24 16:45:08 2020 +1100
> >
> > kasan: shadow declarations only for software modes
> >
> > introduces a build failure when it removed an include for linux/pgtable.h
> > It actually only needs linux/linkage.h
> >
> > Test builds on both x86_64 and arm build cleanly
> >
> > Fixes: 2df573d2ca4c ("kasan: shadow declarations only for software modes")
> > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
>
> Reviewed-by: Marco Elver <elver@google.com>
>
> Probably want to add
>
> Link: https://lore.kernel.org/linux-arm-kernel/24105.1606397102@turing-police/
>
> for more context, too.
Reviewed-by: Andrey Konovalov <andreyknvl@google.com>
Thank you, Valdis!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kasan, mm: fix build issue with asmlinkage
@ 2020-11-30 15:21 ` Andrey Konovalov
0 siblings, 0 replies; 6+ messages in thread
From: Andrey Konovalov @ 2020-11-30 15:21 UTC (permalink / raw)
To: Valdis Klētnieks
Cc: Marco Elver, Russell King - ARM Linux admin, kasan-dev, LKML,
Andrey Ryabinin, Andrew Morton, Linux ARM
On Mon, Nov 30, 2020 at 10:46 AM Marco Elver <elver@google.com> wrote:
>
> On Thu, 26 Nov 2020 at 16:00, Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
> > commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
> > Author: Andrey Konovalov <andreyknvl@google.com>
> > Date: Tue Nov 24 16:45:08 2020 +1100
> >
> > kasan: shadow declarations only for software modes
> >
> > introduces a build failure when it removed an include for linux/pgtable.h
> > It actually only needs linux/linkage.h
> >
> > Test builds on both x86_64 and arm build cleanly
> >
> > Fixes: 2df573d2ca4c ("kasan: shadow declarations only for software modes")
> > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
>
> Reviewed-by: Marco Elver <elver@google.com>
>
> Probably want to add
>
> Link: https://lore.kernel.org/linux-arm-kernel/24105.1606397102@turing-police/
>
> for more context, too.
Reviewed-by: Andrey Konovalov <andreyknvl@google.com>
Thank you, Valdis!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-30 15:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-26 15:00 [PATCH] kasan, mm: fix build issue with asmlinkage Valdis Klētnieks
2020-11-26 15:00 ` Valdis Klētnieks
2020-11-30 9:46 ` Marco Elver
2020-11-30 9:46 ` Marco Elver
2020-11-30 15:21 ` Andrey Konovalov
2020-11-30 15:21 ` Andrey Konovalov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.