From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: david.hunt@intel.com
Subject: Re: [dpdk-dev] [PATCH v4 1/2] power: fix pstate base frequency handling
Date: Fri, 2 Apr 2021 10:35:32 +0100 [thread overview]
Message-ID: <352a7fee-9373-67a7-4dea-3b133171044c@intel.com> (raw)
In-Reply-To: <20210402092645.258257-1-anatoly.burakov@intel.com>
On 02-Apr-21 10:26 AM, Anatoly Burakov wrote:
> Previous fix for base frequency handling in pstate mode introduced a
> couple of issues:
>
> - When base_frequency file does not exist, it simply bails out because
> of what appears to be accidental addition of FOPEN_OR_ERR_RET. This is
> incorrect, as absence of this file is not fatal and is in fact
> expected on kernel versions earlier than 5.3
> - When base_frequency file does exist, it gets opened, but never gets
> closed, resulting in a resource leak
>
> Both issues also manifest themselves as Coverity defects (dead code, and
> a resource leak), so this fix addresses both.
>
> Fixes: 4db9587bbf72 ("power: check sysfs base frequency")
> Cc: david.hunt@intel.com
>
> Coverity issue: 369693
> Coverity issue: 369694
> Bugzilla ID: 668
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
For some reason git notes got lost on format-patch.
v3:
- Split refactor from bugfixes
v4:
- v3 was erroneously "fixing" handling of base max rather than base
frequency
--
Thanks,
Anatoly
next prev parent reply other threads:[~2021-04-02 9:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 14:15 [dpdk-dev] [PATCH 1/3] power: refactor base frequency detection Anatoly Burakov
2021-03-30 14:15 ` [dpdk-dev] [PATCH 2/3] power: refactor pstate sysfs handling Anatoly Burakov
2021-03-30 14:15 ` [dpdk-dev] [PATCH 3/3] power: do not skip saving original pstate governor Anatoly Burakov
2021-03-30 16:52 ` Burakov, Anatoly
2021-03-30 14:25 ` [dpdk-dev] [PATCH v2 1/3] power: refactor base frequency detection Anatoly Burakov
2021-04-01 15:04 ` [dpdk-dev] [PATCH v2 1/2] power: fix pstate base frequency handling Anatoly Burakov
2021-04-01 15:05 ` [dpdk-dev] [PATCH v2 2/2] power: do not skip saving original pstate governor Anatoly Burakov
2021-04-01 15:06 ` [dpdk-dev] [PATCH v3 1/2] power: fix pstate base frequency handling Anatoly Burakov
2021-04-02 9:26 ` [dpdk-dev] [PATCH v4 " Anatoly Burakov
2021-04-02 9:35 ` Burakov, Anatoly [this message]
2021-04-02 11:12 ` Pattan, Reshma
2021-04-02 9:26 ` [dpdk-dev] [PATCH v4 2/2] power: do not skip saving original pstate governor Anatoly Burakov
2021-04-02 9:34 ` Burakov, Anatoly
2021-04-02 11:12 ` Pattan, Reshma
2021-04-06 8:38 ` Thomas Monjalon
2021-04-01 15:06 ` [dpdk-dev] [PATCH v3 " Anatoly Burakov
2021-03-30 14:25 ` [dpdk-dev] [PATCH v2 2/3] power: refactor pstate sysfs handling Anatoly Burakov
2021-03-30 14:25 ` [dpdk-dev] [PATCH v2 3/3] power: do not skip saving original pstate governor Anatoly Burakov
2021-03-30 16:51 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=352a7fee-9373-67a7-4dea-3b133171044c@intel.com \
--to=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.