From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 138A9AD28; Thu, 16 Mar 2023 20:17:55 +0000 (UTC) Received: by mail-wr1-f51.google.com with SMTP id q16so2661502wrw.2; Thu, 16 Mar 2023 13:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678997874; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qcUGlWscPfoOjQ2/RY+CqDxREFzJPUhNCx1vWMcBYac=; b=ZFCJt4LIFO5SGWn9ik6rwm/ZX4j+oBw2GhsisckUFkKA3eckrfLY3lYSg6cyMii5dg 6lJUEGjHHjrCLqRX2gDtUU3w/M5eT/HVcg/2pBB4cwGRpfmoA6dBFLuiehCEtRukKFHU sniWDefQLaAGhUXBF9nQym0G7ob/ik1uU1QXyFrNig3tyZQqVpdMWZzpV6CVFHqkZNZr bvZla/MKSHwL5/cEluhqZhtr79zLfofrxyl+GC8FPyjRxDBJFj2xBZW3iBaeyWKpPmka RIOhisz+cfvytyfGZg+DKWXXawOXySgLqV7gJt48fPv6Wyraj9nLkeN9j0OEXdViFGmz 0bSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678997874; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qcUGlWscPfoOjQ2/RY+CqDxREFzJPUhNCx1vWMcBYac=; b=cC0sq+jDrlMUWAzbDOaKcJJXhm4aQU5uS0aA6UvrVQ8s9Khldrz6r2zbB0+NsXheos XECiGSn+HtsFMBqiCj7CcO8zcfz37P8v8bbg0F6Rmt8N9hUNF3VtcxwJZWcaO+WB1gLc rkv2boxl0f6PASKw/wjup6bmDQTXul2YiK7WKnT6yTOKl4vNt7sTphJUfeDy4wfLkptJ 4cVOpe3Diss9IyIF3cQpo7GgrsDXcBIbz7hiwb94zNeANHU8opGlPFqP6EXlJiO0JrZZ UJQx2LtctwMezzTrIcbajr46cK3rNeQaZTZToiJ5HGy0HNj0JXFuaVOkZ015lK4Embto XRiQ== X-Gm-Message-State: AO0yUKVkv5zBWHdbkXEz/rfzI96pQhDMEhh5l4kg3mt71/0hteo0YS4m DdWPgLii3RE1n3qPouCBVmbdCYlfdt0= X-Google-Smtp-Source: AK7set95gtQqKGisnnc9p+bce+T2xGH3fsL5Ivj13Q9P9Pwq3tFiJ+B9qtMDaikhN+ERi6hqOOyREw== X-Received: by 2002:a5d:4586:0:b0:2cf:e65a:a5fc with SMTP id p6-20020a5d4586000000b002cfe65aa5fcmr5430408wrq.8.1678997874048; Thu, 16 Mar 2023 13:17:54 -0700 (PDT) Received: from suse.localnet (host-79-35-102-94.retail.telecomitalia.it. [79.35.102.94]) by smtp.gmail.com with ESMTPSA id u8-20020adfdb88000000b002cff06039d7sm271611wri.39.2023.03.16.13.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 13:17:53 -0700 (PDT) From: "Fabio M. De Francesco" To: Khadija Kamran Cc: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] staging: axis-fifo: initialize timeouts in probe only Date: Thu, 16 Mar 2023 21:17:52 +0100 Message-ID: <3531852.LM0AJKV5NW@suse> In-Reply-To: References: <2162728.C4sosBPzcN@suse> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" On gioved=EC 16 marzo 2023 19:35:09 CET Khadija Kamran wrote: > On Thu, Mar 16, 2023 at 05:17:47PM +0100, Fabio M. De Francesco wrote: [snip] > > When you are done with build, install, and final reboot to test if your > > module can "modprobe" or "insmod" (i.e. link with the running custom=20 kernel > > you built, installed and boot), try to compare the output of the follow= ing > > commands: > >=20 > > # uname -a > > Linux suse 6.2.2-1-default #1 SMP PREEMPT_DYNAMIC Thu Mar 9 06:06:13 U= TC > > 2023 (44ca817) x86_64 x86_64 x86_64 GNU/Linux >=20 > The above command works >=20 > > AND > >=20 > > # modinfo >=20 > On running 'modinfo axis-fifo' I get error saying module axis-fifo not > found. I built axis-fifo with your changes and then I ran "make install=20 modules_install" in a QEMU/KVM x86_32 VM that I use on a Linux host for=20 testing my patches (Linux on Linux). tweed32:~ # uname -a Linux tweed32 6.3.0-rc2-x86-32-debug+ #32 SMP PREEMPT_DYNAMIC Thu Mar 16=20 18:09:49 CET 2023 i686 athlon i386 GNU/Linux tweed32:~ # modinfo axis-fifo=20 filename: /lib/modules/6.3.0-rc2-x86-32-debug+/kernel/drivers/staging/ axis-fifo/axis-fifo.ko description: Xilinx AXI-Stream FIFO v4.1 IP core driver author: Jacob Feder license: GPL srcversion: EBF46AD6851EAAE67D1000B alias: of:N*T*Cxlnx,axi-fifo-mm-s-4.1C* alias: of:N*T*Cxlnx,axi-fifo-mm-s-4.1 depends: =20 staging: Y retpoline: Y intree: Y name: axis_fifo vermagic: 6.3.0-rc2-x86-32-debug+ SMP preempt mod_unload modversions = K7=20 parm: read_timeout:ms to wait before blocking read() timing out; = set=20 to -1 for no timeout (long) parm: write_timeout:ms to wait before blocking write() timing out= ;=20 set to -1 for no timeout (long) Do you see the "parm" lines? What's the type of read and write_timeout? =46abio