From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Dominik Csapak <d.csapak@proxmox.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/1] add exit-script option to qemu
Date: Wed, 3 Oct 2018 12:15:04 +0200 [thread overview]
Message-ID: <3531fa12-27e6-62ef-61c7-500857ecc891@redhat.com> (raw)
In-Reply-To: <20181003091344.24496-1-d.csapak@proxmox.com>
Hi Dominik,
On 03/10/2018 11:13, Dominik Csapak wrote:
> this patch aims to execute a script when qemu exits
> so that one can do cleanups when using --daemonize without
> having to use the qmp monitor
>
> for now i have mostly copied the script execution code from
> the launch_script function of net/tap.c as i am not sure
> if it would make sense to refactor that and if it does, where
> to put such a function
I'd rather refactor a 'more of 10 common LOC function'.
Maybe qemu_launch_script() in "qemu/osdep.h"?
Phil.
next prev parent reply other threads:[~2018-10-03 10:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 9:13 [Qemu-devel] [PATCH 0/1] add exit-script option to qemu Dominik Csapak
2018-10-03 9:13 ` [Qemu-devel] [PATCH 1/1] vl.c: call optional script when exiting Dominik Csapak
2018-10-03 10:15 ` Philippe Mathieu-Daudé
2018-10-04 8:11 ` Thomas Huth
2018-10-03 10:15 ` Philippe Mathieu-Daudé [this message]
2018-10-04 13:51 ` [Qemu-devel] [PATCH 0/1] add exit-script option to qemu Daniel P. Berrangé
2018-10-05 6:56 ` Dominik Csapak
2018-10-05 8:38 ` Daniel P. Berrangé
2018-10-05 12:57 ` Dominik Csapak
2018-10-05 13:02 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3531fa12-27e6-62ef-61c7-500857ecc891@redhat.com \
--to=philmd@redhat.com \
--cc=d.csapak@proxmox.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.