From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E4B6C433ED for ; Thu, 13 May 2021 11:31:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26A8C613F7 for ; Thu, 13 May 2021 11:31:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26A8C613F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B68D36ECF8; Thu, 13 May 2021 11:31:01 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E6C66ECF8 for ; Thu, 13 May 2021 11:30:59 +0000 (UTC) IronPort-SDR: SwZPwrEec7dhDHWjNz49rwgLklDgg29AgENHKz/1Nr98Ta/GtbQXrrWlc2CU+fFAOmbxuqVOkW jSGanyj1HGuQ== X-IronPort-AV: E=McAfee;i="6200,9189,9982"; a="199979670" X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="199979670" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 04:30:54 -0700 IronPort-SDR: 57EGYOVmtatTrVf3nn0At3TTZxLYuO4ONAUJex3XCKH2SaqMutNDAesQfTx1ZJ9ZjYD2TzfAaS 8I1Xy7EavGuA== X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="393169619" Received: from jkrzyszt-mobl1.ger.corp.intel.com ([10.213.18.198]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 04:30:53 -0700 From: Janusz Krzysztofik To: intel-gfx@lists.freedesktop.org, Jani Nikula Date: Thu, 13 May 2021 13:30:50 +0200 Message-ID: <3536600.WbyNdk4fJJ@jkrzyszt-mobl1.ger.corp.intel.com> Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <87zgxbzpiu.fsf@intel.com> References: <20210429134450.302912-1-janusz.krzysztofik@linux.intel.com> <87zgxbzpiu.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong name announced on FB driver switching X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Jani, On Mon, 3 May 2021 19:38:17 CEST Jani Nikula wrote: > On Thu, 29 Apr 2021, Janusz Krzysztofik = wrote: > > Commit 7a0f9ef9703d ("drm/i915: Use drm_fb_helper_fill_info") > > effectively changed our FB driver name from "inteldrmfb" to > > "i915drmfb". However, we are still using the old name when kicking out > > a firmware fbdev driver potentially bound to our device. Use the new > > name to avoid confusion. > > > > Note: since the new name is assigned by a DRM fbdev helper called at > > the DRM driver registration time, that name is not available when we > > kick the other driver out early, hence a hardcoded name must be used > > unless the DRM layer exposes a macro for converting a DRM driver name > > to its associated fbdev driver name. > > > > Signed-off-by: Janusz Krzysztofik > = > LGTM, Daniel? > = > Reviewed-by: Jani Nikula Thanks for review. What are next steps? Please note I have no push = permissions. Thanks, Janusz > = > $ dim fixes 7a0f9ef9703d > Fixes: 7a0f9ef9703d ("drm/i915: Use drm_fb_helper_fill_info") > Cc: Noralf Tr=F8nnes > Cc: Alex Deucher > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: intel-gfx@lists.freedesktop.org > Cc: # v5.2+ > = > = > > --- > > drivers/gpu/drm/i915/i915_drv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/ i915_drv.c > > index 785dcf20c77b..46082490dc9a 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -554,7 +554,7 @@ static int i915_driver_hw_probe(struct = drm_i915_private *dev_priv) > > if (ret) > > goto err_perf; > > = > > - ret =3D drm_aperture_remove_conflicting_pci_framebuffers(pdev, = "inteldrmfb"); > > + ret =3D drm_aperture_remove_conflicting_pci_framebuffers(pdev, = "i915drmfb"); > > if (ret) > > goto err_ggtt; > = > = _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx