From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v7 1/2] eal: add uevent monitor for hot plug
Date: Tue, 09 Jan 2018 12:44:43 +0100
Message-ID: <3539603.0DoXzmkF5E@xps>
References: <1509567405-27439-3-git-send-email-jia.guo@intel.com>
 <2803089.mJXnisXhBj@xps>
 <01BA8470C017D6468C8290E4B9C5E1E83B2D13F4@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Mordechay Haimovsky <motih@mellanox.com>, dev@dpdk.org,
 "stephen@networkplumber.org" <stephen@networkplumber.org>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>,
 "shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>, "Wu,
 Jingjing" <jingjing.wu@intel.com>, "Zhang, Helin" <helin.zhang@intel.com>,
 "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Guo, Jia" <jia.guo@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 9F4311B1A7
 for <dev@dpdk.org>; Tue,  9 Jan 2018 12:45:07 +0100 (CET)
In-Reply-To: <01BA8470C017D6468C8290E4B9C5E1E83B2D13F4@shsmsx102.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

09/01/2018 12:39, Guo, Jia:
> So, how can separate the patch into more small patch, use stake or null implement in function. I think we should consider if it is a economic way now, if I could explain more detail in code for you all not very familiar the background? I have sent v8, please check, thanks all. 

The v8 is not split enough.
Please try to address all my comments.