From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQHl7-00051m-6a for qemu-devel@nongnu.org; Thu, 21 Jul 2016 13:27:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQHl3-0004yD-0k for qemu-devel@nongnu.org; Thu, 21 Jul 2016 13:27:40 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:57358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQHl2-0004y8-Nx for qemu-devel@nongnu.org; Thu, 21 Jul 2016 13:27:36 -0400 Date: Thu, 21 Jul 2016 13:27:35 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <353979551.7143571.1469122055548.JavaMail.zimbra@redhat.com> In-Reply-To: <20160721171843.GC11412@thinpad.lan.raisama.net> References: <20160719085432.4572-1-marcandre.lureau@redhat.com> <20160719085432.4572-25-marcandre.lureau@redhat.com> <20160721171843.GC11412@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 24/37] pc: keep gsi reference List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: marcandre lureau , qemu-devel@nongnu.org, "Michael S. Tsirkin" Hi ----- Original Message ----- > On Tue, Jul 19, 2016 at 12:54:19PM +0400, marcandre.lureau@redhat.com wro= te: > > From: Marc-Andr=C3=A9 Lureau > >=20 > > Further cleanup would need to call qemu_free_irq() at the appropriate > > time, but for now this silences ASAN about direct leaks. > >=20 > > Signed-off-by: Marc-Andr=C3=A9 Lureau >=20 > Is there a way to make ASAN happy without having to add a field > to MachineState that we're not going to use for anything? Well, the plan is rather to release it when no longer needed. Would it be f= ine to call qemu_free_irqs() in machine_finalize()? >=20 > > --- > > hw/i386/pc_piix.c | 1 + > > hw/i386/pc_q35.c | 1 + > > include/hw/boards.h | 1 + > > 3 files changed, 3 insertions(+) > >=20 > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > > index a07dc81..b2db274 100644 > > --- a/hw/i386/pc_piix.c > > +++ b/hw/i386/pc_piix.c > > @@ -190,6 +190,7 @@ static void pc_init1(MachineState *machine, > > } else { > > gsi =3D qemu_allocate_irqs(gsi_handler, gsi_state, GSI_NUM_PIN= S); > > } > > + machine->gsi =3D gsi; > > =20 > > if (pcmc->pci_enabled) { > > pci_bus =3D i440fx_init(host_type, > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > > index c5e8367..5dfb14f 100644 > > --- a/hw/i386/pc_q35.c > > +++ b/hw/i386/pc_q35.c > > @@ -158,6 +158,7 @@ static void pc_q35_init(MachineState *machine) > > } else { > > gsi =3D qemu_allocate_irqs(gsi_handler, gsi_state, GSI_NUM_PIN= S); > > } > > + machine->gsi =3D gsi; > > =20 > > /* create pci host bus */ > > q35_host =3D Q35_HOST_DEVICE(qdev_create(NULL, TYPE_Q35_HOST_DEVIC= E)); > > diff --git a/include/hw/boards.h b/include/hw/boards.h > > index e46a744..289ba52 100644 > > --- a/include/hw/boards.h > > +++ b/include/hw/boards.h > > @@ -139,6 +139,7 @@ struct MachineState { > > /*< private >*/ > > Object parent_obj; > > Notifier sysbus_notifier; > > + qemu_irq *gsi; > > =20 > > /*< public >*/ > > =20 > > -- > > 2.9.0 > >=20 > >=20 >=20 > -- > Eduardo >=20