From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36844C676ED for ; Sun, 20 Jan 2019 15:29:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F09222087B for ; Sun, 20 Jan 2019 15:29:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="UQjyP8Me" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726281AbfATP2o (ORCPT ); Sun, 20 Jan 2019 10:28:44 -0500 Received: from esa2.microchip.iphmx.com ([68.232.149.84]:13586 "EHLO esa2.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725910AbfATP2o (ORCPT ); Sun, 20 Jan 2019 10:28:44 -0500 X-IronPort-AV: E=Sophos;i="5.56,499,1539673200"; d="scan'208";a="25548231" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES128-SHA; 20 Jan 2019 08:28:43 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.76.37) with Microsoft SMTP Server (TLS) id 14.3.352.0; Sun, 20 Jan 2019 08:28:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector1-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gXfMB9d3m9ilpWm3ndn7RYQk/dWNul9beq1VL2Rrk2w=; b=UQjyP8Me/aJVoJ6NMtJNOYwuB1qn8kYM9E2rShgEKAEVvCVeNdZ5ysa46jGHJqFgdH6HpBWXXNYNxttq9gA8Db/PYeoTePMgTej+R030dVu175pRlCvsyXkvS5sKLb1MBSpOO94dOLpcS+j+fBBFfJefmwmdiejLobjBDZ+pQZU= Received: from DM5PR11MB1850.namprd11.prod.outlook.com (10.175.92.17) by DM5PR11MB0074.namprd11.prod.outlook.com (10.164.155.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.29; Sun, 20 Jan 2019 15:28:41 +0000 Received: from DM5PR11MB1850.namprd11.prod.outlook.com ([fe80::4125:8d55:234b:a4a1]) by DM5PR11MB1850.namprd11.prod.outlook.com ([fe80::4125:8d55:234b:a4a1%10]) with mapi id 15.20.1537.031; Sun, 20 Jan 2019 15:28:41 +0000 From: To: , CC: , , , , Subject: Re: [PATCH v3 2/2] mtd: spi-nor: cadence-quadspi: Add support for Octal SPI controller Thread-Topic: [PATCH v3 2/2] mtd: spi-nor: cadence-quadspi: Add support for Octal SPI controller Thread-Index: AQHUrYaDrXUj68GKYkqwbPlWtM/dE6W4RZ4AgAAI8IA= Date: Sun, 20 Jan 2019 15:28:41 +0000 Message-ID: <353a011e-920a-ddb3-4eef-e3256555ac93@microchip.com> References: <20190116103027.22657-1-vigneshr@ti.com> <20190116103027.22657-3-vigneshr@ti.com> <6e6f7c3a-4772-1a17-0f5f-547ea9809283@microchip.com> In-Reply-To: <6e6f7c3a-4772-1a17-0f5f-547ea9809283@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR09CA0110.eurprd09.prod.outlook.com (2603:10a6:803:78::33) To DM5PR11MB1850.namprd11.prod.outlook.com (2603:10b6:3:114::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tudor.Ambarus@microchip.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [86.121.188.235] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR11MB0074;6:NC2dR0CVFCMWWla1c9yg/SCAq63N3UYHG8HLSfwFr7qAMZDhR6EpStSlKcZk49DL9/ifv4yTqum8P4s8rhXpoZ+/JV24JtwkgvJZZJr/HHEmwNh43sj0LJ7VHldSdDU3j322zLamfUGilGktb25VrMCA/Ug8PUcv6yjJF8ojtbX+3Mj+UwXeICu+o+jdmkGvY1D9ghpF+XepSoq7NKYAHLrd+HeFPy6I4pRanFYWzsy60YUJuC2Y+wjpgn1fGlU6IjLTV8shOBMCQ4UuVA1m3IggjveexAf7sNajFYnSOXxW3WvKJJY/hV8PF7BVTzKukj3BYC1VrE6u/0ExrcjX5lUw1Dq16yzxVLy4LqUtjB/mKdSzC5hi4VomGG5g85eMjrRMl7iY7XRrxzP3bk626ApIN0a/ON2a8PZeDvjsp42vWlBbS6UFjh8cRaJWVRjxO0mKbmG9MyAakP33imGCew==;5:SSf2anu+QRoTQLUYTn4is4wYeyNOELkBdxZ6Jy1x1r060A2xfICUs84hsfAVzNR0wwrTeEd48yZNRcGWdoXvVbpN15EmPNa280gICeGuVmnU5SzSXAE/XPlyEt1uXKGBZVlLTUQdYcuaqVCc9144gH3Z9fsy5p4aon8eAkYGI4KGIBI9dBmbM4uz+uBs+PumoI/CDjFMSvtqY8GqomcC5A==;7:2JhgGy8H9fUUaRMXEFrRd2F07q+AQFe0+Vv9EwchYYr71xw1rm1dYu6xHurvi+wJtXmrveC7xOSmTmleDv0coCGgauAT+diVcJsRjuxu2Zw7jnw/vC4WBMqgzYRcXqVIWLrsjEL+/MFYkDCp+VUBLw== x-ms-office365-filtering-correlation-id: 484cd0df-2bcf-45ee-55c2-08d67eebf4ea x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(2017052603328)(7153060)(7193020);SRVR:DM5PR11MB0074; x-ms-traffictypediagnostic: DM5PR11MB0074: x-microsoft-antispam-prvs: x-forefront-prvs: 0923977CCA x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(376002)(136003)(396003)(346002)(39850400004)(189003)(199004)(53936002)(7736002)(4326008)(305945005)(72206003)(39060400002)(8936002)(8676002)(2501003)(81156014)(81166006)(14454004)(66066001)(97736004)(6486002)(6436002)(3846002)(6246003)(6512007)(68736007)(229853002)(25786009)(6116002)(478600001)(31696002)(86362001)(256004)(486006)(446003)(476003)(2616005)(54906003)(110136005)(11346002)(71200400001)(71190400001)(99286004)(102836004)(26005)(386003)(53546011)(6506007)(2906002)(76176011)(52116002)(316002)(186003)(105586002)(4744005)(106356001)(36756003)(31686004);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR11MB0074;H:DM5PR11MB1850.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: cqpnR9/R0Iw1DUeOlQV5W9q2GyeTjpfouop0upKzoSW+jHZAF0nBbgqnz2Yd1IIMKnQ+O41hdf71JrkGBHe4seu+lIWMgo3NnVNW6S2p/hZ/6wYHtGKi7fKQH1R3yfOF/p0BK0HD1IA5Cui1z3UM6GiIAIhpOjTZY5oVELbvBC9R+Rfgh/n/DGNEopBP+j+Wxwh77AZlSxUBhER8xxgM6nQk/SVuuEF6H+cCh7SjSmV5ZG51/jj0sLIw92N1TSgMEY4CtV1gJD8cftUv21SKCKXVg/ivRpmXGWESu7gJxPJTd+1dcFsPgRUBksN6LPvxgANtPLic9/u1p3Rd4RyvqFCpJ2wroxWbNvpfiSVgVaHUlajgAUrfuRil/q3ZJ/APoq7NrMRk/nC5eaVDzYTlTF/PqIdOqSaAYzZboJI+hi0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <5903957AF0BB3B43B3CC4DD8CDE1F107@namprd11.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 484cd0df-2bcf-45ee-55c2-08d67eebf4ea X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2019 15:28:39.4822 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0074 X-OriginatorOrg: microchip.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org VmlnbmVzaCwNCg0KT24gMDEvMjAvMjAxOSAwNDo1NiBQTSwgVHVkb3IuQW1iYXJ1c0BtaWNyb2No aXAuY29tIHdyb3RlOg0KPiBMb29rcyBnb29kLg0KDQpvbmUgbW9yZSB0aGluZzogaW4gY3FzcGlf cmVhZF9zZXR1cCgpIEkgc2VlIHRoYXQgdGhlIGR1bW15IGN5Y2xlcyBhcmUgYWRqdXN0ZWQNCmlm IChmX3BkYXRhLT5pbnN0X3dpZHRoICE9IENRU1BJX0lOU1RfVFlQRV9RVUFEKS4NCg0KU2hvdWxk IHlvdSBhZGp1c3QgdGhlIGR1bW15IGN5Y2xlcyBmb3Igb2N0byB0b28/IEkgdHJpZWQgdG8gZmlu ZCBhIGRhdGFzaGVldCBmb3INCnRoZSBjb250cm9sbGVyLCB3aXRob3V0IHN1Y2Nlc3MgdGhvdWdo IC4uLg0KDQp0YQ0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: Re: [PATCH v3 2/2] mtd: spi-nor: cadence-quadspi: Add support for Octal SPI controller Date: Sun, 20 Jan 2019 15:28:41 +0000 Message-ID: <353a011e-920a-ddb3-4eef-e3256555ac93@microchip.com> References: <20190116103027.22657-1-vigneshr@ti.com> <20190116103027.22657-3-vigneshr@ti.com> <6e6f7c3a-4772-1a17-0f5f-547ea9809283@microchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <6e6f7c3a-4772-1a17-0f5f-547ea9809283@microchip.com> Content-Language: en-US Content-ID: <5903957AF0BB3B43B3CC4DD8CDE1F107@namprd11.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: vigneshr@ti.com, bbrezillon@kernel.org Cc: marek.vasut@gmail.com, robh+dt@kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Vignesh, On 01/20/2019 04:56 PM, Tudor.Ambarus@microchip.com wrote: > Looks good. one more thing: in cqspi_read_setup() I see that the dummy cycles are adjusted if (f_pdata->inst_width != CQSPI_INST_TYPE_QUAD). Should you adjust the dummy cycles for octo too? I tried to find a datasheet for the controller, without success though ... ta ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6783C636A2 for ; Sun, 20 Jan 2019 15:28:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F6DE2087B for ; Sun, 20 Jan 2019 15:28:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hVE3Hmxs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="UQjyP8Me" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F6DE2087B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i956UfoG07dprGsEcboC27RVSRrNFVFiEN6Do05BhmY=; b=hVE3HmxsU0Reyt CcGEyYZ7XzXQzPxBrk1GdJcPpyFIZ8Bkufxf9LMKvd5DOSu/gARo/vf4Nzb4XOiIUaqWLJ1XSV3z1 2Cqahq6ApSvpxG5FZpJ5j5G5nEcHWJIDszPKmfs95XWMfweYSvzjnQwwqskw0qRuG4PCR0dj1sfHx w8Il3BOz6KtgFpa6dSh2uT1WgD/SVCcdOP8+kL8cb5EuTO+s9SqilM0jLz2WNax3PkfqKHQHJVyq+ 4C5yUmYBH81KZ0os1aw1U+TaegT5zHACxlr6SvnE4NC1gpESsS0I/VTmiW5As8sHP9x3YKWMb0wac Gc6RAMeIlg3qGCXlNS8Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1glF1j-0001TN-4G; Sun, 20 Jan 2019 15:28:47 +0000 Received: from esa2.microchip.iphmx.com ([68.232.149.84]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1glF1g-0001Sy-9I for linux-mtd@lists.infradead.org; Sun, 20 Jan 2019 15:28:45 +0000 X-IronPort-AV: E=Sophos;i="5.56,499,1539673200"; d="scan'208";a="25548231" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES128-SHA; 20 Jan 2019 08:28:43 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.76.37) with Microsoft SMTP Server (TLS) id 14.3.352.0; Sun, 20 Jan 2019 08:28:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector1-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gXfMB9d3m9ilpWm3ndn7RYQk/dWNul9beq1VL2Rrk2w=; b=UQjyP8Me/aJVoJ6NMtJNOYwuB1qn8kYM9E2rShgEKAEVvCVeNdZ5ysa46jGHJqFgdH6HpBWXXNYNxttq9gA8Db/PYeoTePMgTej+R030dVu175pRlCvsyXkvS5sKLb1MBSpOO94dOLpcS+j+fBBFfJefmwmdiejLobjBDZ+pQZU= Received: from DM5PR11MB1850.namprd11.prod.outlook.com (10.175.92.17) by DM5PR11MB0074.namprd11.prod.outlook.com (10.164.155.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.29; Sun, 20 Jan 2019 15:28:41 +0000 Received: from DM5PR11MB1850.namprd11.prod.outlook.com ([fe80::4125:8d55:234b:a4a1]) by DM5PR11MB1850.namprd11.prod.outlook.com ([fe80::4125:8d55:234b:a4a1%10]) with mapi id 15.20.1537.031; Sun, 20 Jan 2019 15:28:41 +0000 From: To: , Subject: Re: [PATCH v3 2/2] mtd: spi-nor: cadence-quadspi: Add support for Octal SPI controller Thread-Topic: [PATCH v3 2/2] mtd: spi-nor: cadence-quadspi: Add support for Octal SPI controller Thread-Index: AQHUrYaDrXUj68GKYkqwbPlWtM/dE6W4RZ4AgAAI8IA= Date: Sun, 20 Jan 2019 15:28:41 +0000 Message-ID: <353a011e-920a-ddb3-4eef-e3256555ac93@microchip.com> References: <20190116103027.22657-1-vigneshr@ti.com> <20190116103027.22657-3-vigneshr@ti.com> <6e6f7c3a-4772-1a17-0f5f-547ea9809283@microchip.com> In-Reply-To: <6e6f7c3a-4772-1a17-0f5f-547ea9809283@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR09CA0110.eurprd09.prod.outlook.com (2603:10a6:803:78::33) To DM5PR11MB1850.namprd11.prod.outlook.com (2603:10b6:3:114::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tudor.Ambarus@microchip.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [86.121.188.235] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR11MB0074; 6:NC2dR0CVFCMWWla1c9yg/SCAq63N3UYHG8HLSfwFr7qAMZDhR6EpStSlKcZk49DL9/ifv4yTqum8P4s8rhXpoZ+/JV24JtwkgvJZZJr/HHEmwNh43sj0LJ7VHldSdDU3j322zLamfUGilGktb25VrMCA/Ug8PUcv6yjJF8ojtbX+3Mj+UwXeICu+o+jdmkGvY1D9ghpF+XepSoq7NKYAHLrd+HeFPy6I4pRanFYWzsy60YUJuC2Y+wjpgn1fGlU6IjLTV8shOBMCQ4UuVA1m3IggjveexAf7sNajFYnSOXxW3WvKJJY/hV8PF7BVTzKukj3BYC1VrE6u/0ExrcjX5lUw1Dq16yzxVLy4LqUtjB/mKdSzC5hi4VomGG5g85eMjrRMl7iY7XRrxzP3bk626ApIN0a/ON2a8PZeDvjsp42vWlBbS6UFjh8cRaJWVRjxO0mKbmG9MyAakP33imGCew==; 5:SSf2anu+QRoTQLUYTn4is4wYeyNOELkBdxZ6Jy1x1r060A2xfICUs84hsfAVzNR0wwrTeEd48yZNRcGWdoXvVbpN15EmPNa280gICeGuVmnU5SzSXAE/XPlyEt1uXKGBZVlLTUQdYcuaqVCc9144gH3Z9fsy5p4aon8eAkYGI4KGIBI9dBmbM4uz+uBs+PumoI/CDjFMSvtqY8GqomcC5A==; 7:2JhgGy8H9fUUaRMXEFrRd2F07q+AQFe0+Vv9EwchYYr71xw1rm1dYu6xHurvi+wJtXmrveC7xOSmTmleDv0coCGgauAT+diVcJsRjuxu2Zw7jnw/vC4WBMqgzYRcXqVIWLrsjEL+/MFYkDCp+VUBLw== x-ms-office365-filtering-correlation-id: 484cd0df-2bcf-45ee-55c2-08d67eebf4ea x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(2017052603328)(7153060)(7193020); SRVR:DM5PR11MB0074; x-ms-traffictypediagnostic: DM5PR11MB0074: x-microsoft-antispam-prvs: x-forefront-prvs: 0923977CCA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(136003)(396003)(346002)(39850400004)(189003)(199004)(53936002)(7736002)(4326008)(305945005)(72206003)(39060400002)(8936002)(8676002)(2501003)(81156014)(81166006)(14454004)(66066001)(97736004)(6486002)(6436002)(3846002)(6246003)(6512007)(68736007)(229853002)(25786009)(6116002)(478600001)(31696002)(86362001)(256004)(486006)(446003)(476003)(2616005)(54906003)(110136005)(11346002)(71200400001)(71190400001)(99286004)(102836004)(26005)(386003)(53546011)(6506007)(2906002)(76176011)(52116002)(316002)(186003)(105586002)(4744005)(106356001)(36756003)(31686004); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR11MB0074; H:DM5PR11MB1850.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: cqpnR9/R0Iw1DUeOlQV5W9q2GyeTjpfouop0upKzoSW+jHZAF0nBbgqnz2Yd1IIMKnQ+O41hdf71JrkGBHe4seu+lIWMgo3NnVNW6S2p/hZ/6wYHtGKi7fKQH1R3yfOF/p0BK0HD1IA5Cui1z3UM6GiIAIhpOjTZY5oVELbvBC9R+Rfgh/n/DGNEopBP+j+Wxwh77AZlSxUBhER8xxgM6nQk/SVuuEF6H+cCh7SjSmV5ZG51/jj0sLIw92N1TSgMEY4CtV1gJD8cftUv21SKCKXVg/ivRpmXGWESu7gJxPJTd+1dcFsPgRUBksN6LPvxgANtPLic9/u1p3Rd4RyvqFCpJ2wroxWbNvpfiSVgVaHUlajgAUrfuRil/q3ZJ/APoq7NrMRk/nC5eaVDzYTlTF/PqIdOqSaAYzZboJI+hi0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <5903957AF0BB3B43B3CC4DD8CDE1F107@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 484cd0df-2bcf-45ee-55c2-08d67eebf4ea X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2019 15:28:39.4822 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0074 X-OriginatorOrg: microchip.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190120_072844_356720_DCC7458A X-CRM114-Status: UNSURE ( 8.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marek.vasut@gmail.com, robh+dt@kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Vignesh, On 01/20/2019 04:56 PM, Tudor.Ambarus@microchip.com wrote: > Looks good. one more thing: in cqspi_read_setup() I see that the dummy cycles are adjusted if (f_pdata->inst_width != CQSPI_INST_TYPE_QUAD). Should you adjust the dummy cycles for octo too? I tried to find a datasheet for the controller, without success though ... ta ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/