From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 10/27] net/ena: add lrte_timer dependency
	for linking
Date: Mon, 18 Jun 2018 00:37:08 +0200
Message-ID: <3540745.n2F2IE3GfD@xps>
References: <20180607094322.14312-1-mk@semihalf.com>
 <20180607094322.14312-10-mk@semihalf.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Marcin Wojtas <mw@semihalf.com>,
 Guy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>,
 matua@amazon.com
To: Michal Krawczyk <mk@semihalf.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id DE4B77ED7
 for <dev@dpdk.org>; Mon, 18 Jun 2018 00:37:11 +0200 (CEST)
In-Reply-To: <20180607094322.14312-10-mk@semihalf.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

07/06/2018 11:43, Michal Krawczyk:
> ENA PMD is required to use librte_timer. The appropriate depndency must
> be added ifin case the DPDK will be built as shared library.
> 
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> ---
>  drivers/net/ena/Makefile | 1 +
>  mk/rte.app.mk            | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile
> index 43339f3b9..ff9ce315b 100644
> --- a/drivers/net/ena/Makefile
> +++ b/drivers/net/ena/Makefile
> @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES)
>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
>  LDLIBS += -lrte_bus_pci
> +LDLIBS += -lrte_timer
>  
>  include $(RTE_SDK)/mk/rte.lib.mk
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 1e32c83e7..c70bc254e 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -60,6 +60,7 @@ endif
>  
>  _LDLIBS-y += --whole-archive
>  
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer

Why is it added in rte.app.mk? It is already there, few lines below.