From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 892AFC433EF for ; Tue, 19 Oct 2021 10:33:26 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F3E960FD8 for ; Tue, 19 Oct 2021 10:33:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F3E960FD8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 63B1F80F16; Tue, 19 Oct 2021 12:33:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634639602; bh=iPOh0JJwoPU+BtRCwLtT+Shq1PH7UcjZEjZaoLtWEhc=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MsWdeAnYwxQ9sOzpK4YrK/VNiHC+UcY132eVu24kiu+JBHUMYhqc1x9fG6ArgUW8c XcaarmRYcE5naOj3z7/c01innXCtDk9MxxPQylqQcFI32uHSJSDKHKTsToAGNceCCH bIt47PS7JewTKxbOVknOLbFw5Ah/uIDfFPxn+sZPyfJ2N3P65sfDYDxMblcDdJRFIk 6YCyg2UmdLL0lH21Cht9D8IXSCcWFY/fqnZz6tbr1dq65friECE1TLypsQJNUjS+uX Lmgr52kOABYymGAKBlyCJVjmMRnx/LxRQIsjCa4FvTmrEdec5k8PlC0bB0yj9lmgO1 kCyEyAn3T37Jg== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C622E80F5F for ; Tue, 19 Oct 2021 12:33:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634639600; bh=iPOh0JJwoPU+BtRCwLtT+Shq1PH7UcjZEjZaoLtWEhc=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=Xl/EjckPVeQakjm4b70oiZ+CwqhOBQv6LYwL1BOl1qahgcpkCIp2I+z7K/zhwonjd BAIgGlpUFKhRnJzle7hG9iE2oKyYAZK+DpVnFV3AASfaewmTDHV82o2xo/muDgi39p Jl4eIl1pYcOYwMgwq45mVIkmWQo713/F8kmJswHBLXc9yGJxBWzhEH43bGLO1yqgib vft/MO3TPDkKKDwL1KgNHyxY+I0eRP2P8f/UqFxl3Zuko6pK81Kb4JGROaHEH2psBT cABHvmk/VmGwFI3luJHfKr1qcbEuybfiP6ZwGaTqzTogS5tZB24M8EIkLcg1h1ac0j 3qo4Yqpb9Es/g== Received: by janitor.denx.de (Postfix, from userid 108) id 790E2A0237; Tue, 19 Oct 2021 12:33:20 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id A9775A0057; Tue, 19 Oct 2021 12:33:11 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 909CA1E0F1B; Tue, 19 Oct 2021 12:33:11 +0200 (CEST) To: Tom Rini cc: Simon Glass , U-Boot Mailing List , Heinrich Schuchardt , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211018142404.GR7964@bill-the-cat> References: <20211014182257.468649-1-sjg@chromium.org> <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3341802.1634308345@gemini.denx.de> <3496103.1634558337@gemini.denx.de> <20211018133728.GQ7964@bill-the-cat> <3502270.1634566234@gemini.denx.de> <20211018142404.GR7964@bill-the-cat> Comments: In-reply-to Tom Rini message dated "Mon, 18 Oct 2021 10:24:04 -0400." Date: Tue, 19 Oct 2021 12:33:11 +0200 Message-ID: <3546032.1634639591@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Tom, In message <20211018142404.GR7964@bill-the-cat> you wrote: > > > > Perhaps we should just make "+" an illegal character in the variable > > > name, for consistency? > > > > And break backward compatibility? I'd rather see a better > > definition of the syntax of the environment files, plus maybe a more > > powerful parser. > > Are there examples today of scripts that use "+" in the variable names? None that I know of. > That maybe someone wrote a custom an private thing that uses + in the > name isn't the best argument. Someone saying that did would be better. Yes, I know. But then, changing existing APIs is not nice. > Of course yes, if we can just make the parser handle it, without it also > being a tricky nightmare, that's the better solution. Exactly. > > Hm... I can't find it right now but did I not also read about other > > restrictions to variable names, like they must noch begin with '_' > > when using this new tool? > > Any invalid characters need to be clearly documented, if they aren't, > yes. So far, only NUL and '=' were impossible to use in a variable name. > > I feel it is wrong to place new restrictions on something that was > > constant for 21 years, just because our parser cannot parse it... > > Sure. But if it's also the case that for 21 years no one has been using > foo+bar, baz+, etc, in their variable names, maybe we just document > that's not valid and move on? We cannot know what people have been using in their environemnts. Even for those boards that are in mainline, the environment settings used in real life are often totally different. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Save yourself! Reboot in 5 seconds!