From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD71EC433FE for ; Tue, 19 Oct 2021 10:38:37 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72192610E7 for ; Tue, 19 Oct 2021 10:38:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 72192610E7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A4A7F81F74; Tue, 19 Oct 2021 12:38:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634639914; bh=GQPO5IiAyFocuoJURUWlZuwfdc6FrAx2wIHhNPdRw7w=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=yAjGFu2/0ESC0eFTSdOYXSpd4Y+K4R2Z7MXmjjKBX4frucz2ElAHxgiE48A+M7Kdv 9QGUYqBvDF6h7Y/pya5g9OJR3p9v+/z1zzhFwVqgUJjJ5QvGtClWjLQMaHEjJvTalf lfHGZeL3gV0So/UxeaF1RoO9DiVd2WbZfsCCCjEW924gu+H3PClAJhOu+kDEeBeBSv HG9YmNTLNZuaP2xbFtiLdH2N9t4KcilOhVOZmWHqnmAKH+SnJSag0wYz+/v1m/Yvrw 8L9u+ELTOQjZ5FKks2AFBlaPpZ1pkpmFp7JiJZf7Ypakl3eJ4+JuJ+9R8igMKUue/d yrt6GTtPIto0A== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id AE14D81F0D for ; Tue, 19 Oct 2021 12:38:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634639912; bh=GQPO5IiAyFocuoJURUWlZuwfdc6FrAx2wIHhNPdRw7w=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=pymJ6kwY5fNibSVczzEB5DE8dAKXyTkq5pWWwjl1H1V8XduGuHiJV0q/2QpRsIstq LrB9z1AoHs/aWeuz9a/IshS4m6lGayJY6O6lHhI3vT5oEK/9EWamJOlWqv6j67ZClk /bfIkL+l2uGu/WhloNh0KLB5PqiRm1km5z3Shf25otOdgVBmXj5tVPGlAExeGUbKNS YFEJUq86EruSxHR4wMo/KVlb6cARCXtY1HmSr69WKxG+7KL5ZNWYvivSdcJS7rntxJ 2GorIm03TTO5/RnWZCWTPFo7QHmDDvZC3nDNolzSo0J2000PDWtkTvWBDmCqT/Iloy lzjF9FZN82RKQ== Received: by janitor.denx.de (Postfix, from userid 108) id 3200AA0275; Tue, 19 Oct 2021 12:38:32 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id A9221A0057; Tue, 19 Oct 2021 12:38:23 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 571A21E0F1B; Tue, 19 Oct 2021 12:38:23 +0200 (CEST) To: Simon Glass cc: Tom Rini , U-Boot Mailing List , Heinrich Schuchardt , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: References: <20211014182257.468649-1-sjg@chromium.org> <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3341802.1634308345@gemini.denx.de> <3496103.1634558337@gemini.denx.de> <20211018133728.GQ7964@bill-the-cat> <3502270.1634566234@gemini.denx.de> Comments: In-reply-to Simon Glass message dated "Mon, 18 Oct 2021 12:12:16 -0600." Date: Tue, 19 Oct 2021 12:38:23 +0200 Message-ID: <3546170.1634639903@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Simon, In message you wrote: > > > Hm... I can't find it right now but did I not also read about other > > restrictions to variable names, like they must noch begin with '_' > > when using this new tool? > > Yes but I took that out (I think in v6). I'll update the commit message. Why exactly is this now forbidden, too? > > I feel it is wrong to place new restrictions on something that was > > constant for 21 years, just because our parser cannot parse it... > > We need the + thing and perhaps we should ask people to avoid > punctuation, etc? But for now I'm not requiring it in this series, > apart from + Punctuation? Well, we already have ".flags", so at least here we do have a real life use case. I really would like to avoid new restictions of variable names, especially as I cannot see any good reason for it - yes, your awk script cannot handle this situation, but I tend to belive the fix is in a better parser than in placing restrictions on the input data. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Half of the people in the world are below average.