From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6975C433F5 for ; Tue, 19 Oct 2021 10:46:23 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB1F7610E7 for ; Tue, 19 Oct 2021 10:46:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB1F7610E7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 293E782EBD; Tue, 19 Oct 2021 12:46:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634640381; bh=yDtcheXLZMmrQ6m+UcQE/JNmKeBrnd2Z7CaBbtxDPBM=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=yjDM22fHLmChO1+9OFB6l+1CUKe+1mTKYDqn92TWl34ltwG6KEZWaz/q8XCE4RTcf miT1tHYvUqRRo2RPVJwl371vhKkM0/SlttnkRsaQrUyeE1TQY/8RZrNM5TKcjCbkPn HJLb0+HRqmYfRzY4oFPAAWzkCtum10aADm0Om8WuWJILPqJUThf1dteLbsCNm/MBcn pCLh54FGU4kOuXfyUifDYQEKSspDWREqdEpeR3nF3qAV3YyM4Gb/24Ick6RTOwjjs4 vRJIEL64CC/8bqA66yBQIQ1iyEqXzfl33Y+EDL//YgJj43EjQMOONhk6blq2rt1rSy VmOqKhEN31qIQ== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 1961782ECC for ; Tue, 19 Oct 2021 12:46:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634640380; bh=yDtcheXLZMmrQ6m+UcQE/JNmKeBrnd2Z7CaBbtxDPBM=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=cqfI1fKm24Lw119SvxW1yOJ/+99VvogIdIfeK0yeb/kUMVa3T9hyL8lqY/VggVckF AjsfsaDzG5la1SuG3U/GwhBNpXDEuTO8oZoeCub9exxdPLeOV0suRlGx45ZgW6tBKS k1C2Of6Mo6QDZOT8A6qsU4VKMp5i9AjEOtvzyf4ihveScs1PgUF6hHI4QbHBfSoB5b kTodmbkZ66JjqE0EqqAQ/dOWz+CB00hJqBHdRSNU7RgwtnTwKDnIjThH1nB+58c2Zb lvn/+m5K56E5ygTwQ7zm8dNA6JHaC777RSePRcw/cu071K0o/2dIi7tVlP3RUSU3rw GSLC7hldIEfuQ== Received: by janitor.denx.de (Postfix, from userid 108) id 9A1FFA02B9; Tue, 19 Oct 2021 12:46:19 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 9BD50A0057; Tue, 19 Oct 2021 12:46:09 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 84E0E1E0F1B; Tue, 19 Oct 2021 12:46:09 +0200 (CEST) To: Simon Glass cc: U-Boot Mailing List , Heinrich Schuchardt , Tom Rini , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: References: <20211014182257.468649-1-sjg@chromium.org> <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3341802.1634308345@gemini.denx.de> <3496103.1634558337@gemini.denx.de> Comments: In-reply-to Simon Glass message dated "Mon, 18 Oct 2021 12:12:21 -0600." Date: Tue, 19 Oct 2021 12:46:09 +0200 Message-ID: <3546427.1634640369@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Simon, In message you wrote: > > Can we just ban + ? Why? Just because your awk script is a lousy parser? > In the above, foo\+ gives an unknown escape sequence from the C > preprocessor, then the whole line is ignored by the script Really? -> cat foo.c #define A ampersand #define B berta int foo = A \+ B ; -> gcc -E foo.c # 0 "foo.c" # 0 "" # 0 "" # 1 "/usr/include/stdc-predef.h" 1 3 4 # 0 "" 2 # 1 "foo.c" int foo = ampersand \+ berta ; I do not see any such error message? > foo+ = bar produes a variable called "foo+ " in the environment with > the value " bar" so you probably don't want that. This is only because your "parser" is very primitive and sensitive even to minimal white space changes. > My original motivation was the complexity of getting the env you want > using #define > > My current motivation is to complete the CONFIG migration, now in its 8th year. I fully understand your motivation and appreciate your efforts. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Thought for the day: What if there were no hypothetical situations?