From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66C43C4167B for ; Fri, 30 Dec 2022 15:40:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 20EDF10E17D; Fri, 30 Dec 2022 15:40:05 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id E18FB10E17D for ; Fri, 30 Dec 2022 15:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672414802; x=1703950802; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=TIFFIonNfFuuxbjnwg8CcM1HsTMfK/pa2Ssm4mBgVPE=; b=KpHIqsrDzZ+xi0ZuCnzrPaplrmcibFIUT8egOQJE0TNO8DlHRTD0Vx+4 eJn412AKvftE27QGqwGzXbAIONdGptRqMqgPockt41HdqQ4ggszlaU0XU CcbI8xZUPPyy7G4BBCtrZTnNcXq/dGY/RS1EXmL4zE60Ha3OB9mK0Xi4l EPYm5Y109T0l6rQnWEfKkgoYBISUevoDCGqv5Zp8o8CyITftgAZEPjXyP 3kZ5WPDC6O2IWd1MUHWdxTNgZ87yVkA6sQ/M1fTwHG51NMixaX947whrX Dy35VljIsNXKvjuOXvc0+gvoFtmlh1GKUnrV+okLxkcJMNJLY+P+DIwYE Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10576"; a="318919501" X-IronPort-AV: E=Sophos;i="5.96,287,1665471600"; d="scan'208";a="318919501" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Dec 2022 07:40:02 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10576"; a="796256472" X-IronPort-AV: E=Sophos;i="5.96,287,1665471600"; d="scan'208";a="796256472" Received: from ahajda-mobl.ger.corp.intel.com (HELO [10.213.2.40]) ([10.213.2.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Dec 2022 07:39:59 -0800 Message-ID: <354afea4-f909-8352-753d-0f2509d7165b@intel.com> Date: Fri, 30 Dec 2022 16:39:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [PATCH] drm/bridge: sii902x: Allow reset line to be tied to a sleepy GPIO controller Content-Language: en-US To: Wadim Egorov , upstream@lists.phytec.de, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20221228145704.939801-1-w.egorov@phytec.de> From: Andrzej Hajda Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <20221228145704.939801-1-w.egorov@phytec.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: neil.armstrong@linaro.org, jernej.skrabec@gmail.com, jonas@kwiboo.se, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 28.12.2022 15:57, Wadim Egorov wrote: > Switch to gpiod_set_value_cansleep() in sii902x_reset(). > This is relevant if the reset line is tied to a I2C GPIO > controller. > > Signed-off-by: Wadim Egorov Reviewed-by: Andrzej Hajda Regards Andrzej > --- > drivers/gpu/drm/bridge/sii902x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c > index 878fb7d3732b..980611aec2f6 100644 > --- a/drivers/gpu/drm/bridge/sii902x.c > +++ b/drivers/gpu/drm/bridge/sii902x.c > @@ -240,12 +240,12 @@ static void sii902x_reset(struct sii902x *sii902x) > if (!sii902x->reset_gpio) > return; > > - gpiod_set_value(sii902x->reset_gpio, 1); > + gpiod_set_value_cansleep(sii902x->reset_gpio, 1); > > /* The datasheet says treset-min = 100us. Make it 150us to be sure. */ > usleep_range(150, 200); > > - gpiod_set_value(sii902x->reset_gpio, 0); > + gpiod_set_value_cansleep(sii902x->reset_gpio, 0); > } > > static enum drm_connector_status sii902x_detect(struct sii902x *sii902x) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C71AC10F1B for ; Fri, 30 Dec 2022 15:41:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235259AbiL3PlS (ORCPT ); Fri, 30 Dec 2022 10:41:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235358AbiL3Pkc (ORCPT ); Fri, 30 Dec 2022 10:40:32 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70E521C411 for ; Fri, 30 Dec 2022 07:40:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672414802; x=1703950802; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=TIFFIonNfFuuxbjnwg8CcM1HsTMfK/pa2Ssm4mBgVPE=; b=KpHIqsrDzZ+xi0ZuCnzrPaplrmcibFIUT8egOQJE0TNO8DlHRTD0Vx+4 eJn412AKvftE27QGqwGzXbAIONdGptRqMqgPockt41HdqQ4ggszlaU0XU CcbI8xZUPPyy7G4BBCtrZTnNcXq/dGY/RS1EXmL4zE60Ha3OB9mK0Xi4l EPYm5Y109T0l6rQnWEfKkgoYBISUevoDCGqv5Zp8o8CyITftgAZEPjXyP 3kZ5WPDC6O2IWd1MUHWdxTNgZ87yVkA6sQ/M1fTwHG51NMixaX947whrX Dy35VljIsNXKvjuOXvc0+gvoFtmlh1GKUnrV+okLxkcJMNJLY+P+DIwYE Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10576"; a="318919504" X-IronPort-AV: E=Sophos;i="5.96,287,1665471600"; d="scan'208";a="318919504" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Dec 2022 07:40:02 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10576"; a="796256472" X-IronPort-AV: E=Sophos;i="5.96,287,1665471600"; d="scan'208";a="796256472" Received: from ahajda-mobl.ger.corp.intel.com (HELO [10.213.2.40]) ([10.213.2.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Dec 2022 07:39:59 -0800 Message-ID: <354afea4-f909-8352-753d-0f2509d7165b@intel.com> Date: Fri, 30 Dec 2022 16:39:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [PATCH] drm/bridge: sii902x: Allow reset line to be tied to a sleepy GPIO controller Content-Language: en-US To: Wadim Egorov , upstream@lists.phytec.de, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: daniel@ffwll.ch, airlied@gmail.com, jernej.skrabec@gmail.com, jonas@kwiboo.se, Laurent.pinchart@ideasonboard.com, robert.foss@linaro.org, neil.armstrong@linaro.org References: <20221228145704.939801-1-w.egorov@phytec.de> From: Andrzej Hajda Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <20221228145704.939801-1-w.egorov@phytec.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.12.2022 15:57, Wadim Egorov wrote: > Switch to gpiod_set_value_cansleep() in sii902x_reset(). > This is relevant if the reset line is tied to a I2C GPIO > controller. > > Signed-off-by: Wadim Egorov Reviewed-by: Andrzej Hajda Regards Andrzej > --- > drivers/gpu/drm/bridge/sii902x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c > index 878fb7d3732b..980611aec2f6 100644 > --- a/drivers/gpu/drm/bridge/sii902x.c > +++ b/drivers/gpu/drm/bridge/sii902x.c > @@ -240,12 +240,12 @@ static void sii902x_reset(struct sii902x *sii902x) > if (!sii902x->reset_gpio) > return; > > - gpiod_set_value(sii902x->reset_gpio, 1); > + gpiod_set_value_cansleep(sii902x->reset_gpio, 1); > > /* The datasheet says treset-min = 100us. Make it 150us to be sure. */ > usleep_range(150, 200); > > - gpiod_set_value(sii902x->reset_gpio, 0); > + gpiod_set_value_cansleep(sii902x->reset_gpio, 0); > } > > static enum drm_connector_status sii902x_detect(struct sii902x *sii902x)