From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525E0C2BA83 for ; Thu, 13 Feb 2020 16:23:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D0852082F for ; Thu, 13 Feb 2020 16:23:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727992AbgBMQXd (ORCPT ); Thu, 13 Feb 2020 11:23:33 -0500 Received: from ivanoab7.miniserver.com ([37.128.132.42]:48512 "EHLO www.kot-begemot.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727772AbgBMQXd (ORCPT ); Thu, 13 Feb 2020 11:23:33 -0500 Received: from tun252.jain.kot-begemot.co.uk ([192.168.18.6] helo=jain.kot-begemot.co.uk) by www.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2HGw-0000Pf-Tt; Thu, 13 Feb 2020 16:23:27 +0000 Received: from jain.kot-begemot.co.uk ([192.168.3.3]) by jain.kot-begemot.co.uk with esmtp (Exim 4.92) (envelope-from ) id 1j2HGu-0006m0-Mt; Thu, 13 Feb 2020 16:23:26 +0000 Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso To: "Michael S. Tsirkin" , Eric Dumazet Cc: netdev@vger.kernel.org, Jason Wang , virtualization@lists.linux-foundation.org, linux-um@lists.infradead.org References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> <20200211053502-mutt-send-email-mst@kernel.org> <9547228b-aa93-f2b6-6fdc-8d33cde3716a@cambridgegreys.com> <20200213045937-mutt-send-email-mst@kernel.org> <94fb9656-99ee-a001-e428-9d76c3620e61@gmail.com> <20200213105010-mutt-send-email-mst@kernel.org> From: Anton Ivanov Message-ID: <35510da7-08f1-4aa5-c6d6-6bffbccaee0c@cambridgegreys.com> Date: Thu, 13 Feb 2020 16:23:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200213105010-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Clacks-Overhead: GNU Terry Pratchett Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 13/02/2020 15:53, Michael S. Tsirkin wrote: > On Thu, Feb 13, 2020 at 07:44:06AM -0800, Eric Dumazet wrote: >> >> On 2/13/20 2:00 AM, Michael S. Tsirkin wrote: >>> On Wed, Feb 12, 2020 at 05:38:09PM +0000, Anton Ivanov wrote: >>>> >>>> On 11/02/2020 10:37, Michael S. Tsirkin wrote: >>>>> On Tue, Feb 11, 2020 at 07:42:37AM +0000, Anton Ivanov wrote: >>>>>> On 11/02/2020 02:51, Jason Wang wrote: >>>>>>> On 2020/2/11 上午12:55, Anton Ivanov wrote: >>>>>>>> >>>>>>>> On 09/12/2019 10:48, anton.ivanov@cambridgegreys.com wrote: >>>>>>>>> From: Anton Ivanov >>>>>>>>> >>>>>>>>> Some of the frames marked as GSO which arrive at >>>>>>>>> virtio_net_hdr_from_skb() have no GSO_TYPE, no >>>>>>>>> fragments (data_len = 0) and length significantly shorter >>>>>>>>> than the MTU (752 in my experiments). >>>>>>>>> >>>>>>>>> This is observed on raw sockets reading off vEth interfaces >>>>>>>>> in all 4.x and 5.x kernels I tested. >>>>>>>>> >>>>>>>>> These frames are reported as invalid while they are in fact >>>>>>>>> gso-less frames. >>>>>>>>> >>>>>>>>> This patch marks the vnet header as no-GSO for them instead >>>>>>>>> of reporting it as invalid. >>>>>>>>> >>>>>>>>> Signed-off-by: Anton Ivanov >>>>>>>>> --- >>>>>>>>>   include/linux/virtio_net.h | 8 ++++++-- >>>>>>>>>   1 file changed, 6 insertions(+), 2 deletions(-) >>>>>>>>> >>>>>>>>> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h >>>>>>>>> index 0d1fe9297ac6..d90d5cff1b9a 100644 >>>>>>>>> --- a/include/linux/virtio_net.h >>>>>>>>> +++ b/include/linux/virtio_net.h >>>>>>>>> @@ -112,8 +112,12 @@ static inline int >>>>>>>>> virtio_net_hdr_from_skb(const struct sk_buff *skb, >>>>>>>>>               hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV4; >>>>>>>>>           else if (sinfo->gso_type & SKB_GSO_TCPV6) >>>>>>>>>               hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV6; >>>>>>>>> -        else >>>>>>>>> -            return -EINVAL; >>>>>>>>> +        else { >>>>>>>>> +            if (skb->data_len == 0) >>>>>>>>> +                hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE; >>>>>>>>> +            else >>>>>>>>> +                return -EINVAL; >>>>>>>>> +        } >>>>>>>>>           if (sinfo->gso_type & SKB_GSO_TCP_ECN) >>>>>>>>>               hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; >>>>>>>>>       } else >>>>>>>>> >>>>>>>> ping. >>>>>>>> >>>>>>> Do you mean gso_size is set but gso_type is not? Looks like a bug >>>>>>> elsewhere. >>>>>>> >>>>>>> Thanks >>>>>>> >>>>>>> >>>>>> Yes. >>>>>> >>>>>> I could not trace it where it is coming from. >>>>>> >>>>>> I see it when doing recvmmsg on raw sockets in the UML vector network >>>>>> drivers. >>>>>> >>>>> I think we need to find the culprit and fix it there, lots of other things >>>>> can break otherwise. >>>>> Just printing out skb->dev->name should do the trick, no? >>>> The printk in virtio_net_hdr_from_skb says NULL. >>>> >>>> That is probably normal for a locally originated frame. >>>> >>>> I cannot reproduce this with network traffic by the way - it happens only if the traffic is locally originated on the host. >>>> >>>> A, >>> OK so is it code in __tcp_transmit_skb that sets gso_size to non-null >>> when gso_type is 0? >>> >> Correct way to determine if a packet is a gso one is by looking at gso_size. >> Then only it is legal looking at gso_type >> >> >> static inline bool skb_is_gso(const struct sk_buff *skb) >> { >> return skb_shinfo(skb)->gso_size; >> } >> >> /* Note: Should be called only if skb_is_gso(skb) is true */ >> static inline bool skb_is_gso_v6(const struct sk_buff *skb) >> ... >> >> >> There is absolutely no relation between GSO and skb->data_len, skb can be linearized >> for various orthogonal reasons. > The reported problem is that virtio gets a packet where gso_size > is !0 but gso_type is 0. > > It currently drops these on the assumption that it's some type > of a gso packet it does not know how to handle. > > > So you are saying if skb_is_gso we can still have gso_type set to 0, > and that's an expected configuration? > > So the patch should just be: > > > - if (skb_is_gso(skb)) { > + if (skb_is_gso(skb) && sinfo->gso_type) { > Yes, provided that skb_is_gso(skb) and sinfo->gso_type == 0 is a valid state. I agree with Jason, there may be something wrong going on here and we need to find the source which creates these packets. A. > > ? > > > _______________________________________________ > linux-um mailing list > linux-um@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-um -- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ivanoab7.miniserver.com ([37.128.132.42] helo=www.kot-begemot.co.uk) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2HH1-00027I-Gf for linux-um@lists.infradead.org; Thu, 13 Feb 2020 16:23:33 +0000 Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> <20200211053502-mutt-send-email-mst@kernel.org> <9547228b-aa93-f2b6-6fdc-8d33cde3716a@cambridgegreys.com> <20200213045937-mutt-send-email-mst@kernel.org> <94fb9656-99ee-a001-e428-9d76c3620e61@gmail.com> <20200213105010-mutt-send-email-mst@kernel.org> From: Anton Ivanov Message-ID: <35510da7-08f1-4aa5-c6d6-6bffbccaee0c@cambridgegreys.com> Date: Thu, 13 Feb 2020 16:23:24 +0000 MIME-Version: 1.0 In-Reply-To: <20200213105010-mutt-send-email-mst@kernel.org> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: "Michael S. Tsirkin" , Eric Dumazet Cc: netdev@vger.kernel.org, Jason Wang , linux-um@lists.infradead.org, virtualization@lists.linux-foundation.org Ck9uIDEzLzAyLzIwMjAgMTU6NTMsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90ZToKPiBPbiBUaHUs IEZlYiAxMywgMjAyMCBhdCAwNzo0NDowNkFNIC0wODAwLCBFcmljIER1bWF6ZXQgd3JvdGU6Cj4+ Cj4+IE9uIDIvMTMvMjAgMjowMCBBTSwgTWljaGFlbCBTLiBUc2lya2luIHdyb3RlOgo+Pj4gT24g V2VkLCBGZWIgMTIsIDIwMjAgYXQgMDU6Mzg6MDlQTSArMDAwMCwgQW50b24gSXZhbm92IHdyb3Rl Ogo+Pj4+Cj4+Pj4gT24gMTEvMDIvMjAyMCAxMDozNywgTWljaGFlbCBTLiBUc2lya2luIHdyb3Rl Ogo+Pj4+PiBPbiBUdWUsIEZlYiAxMSwgMjAyMCBhdCAwNzo0MjozN0FNICswMDAwLCBBbnRvbiBJ dmFub3Ygd3JvdGU6Cj4+Pj4+PiBPbiAxMS8wMi8yMDIwIDAyOjUxLCBKYXNvbiBXYW5nIHdyb3Rl Ogo+Pj4+Pj4+IE9uIDIwMjAvMi8xMSDkuIrljYgxMjo1NSwgQW50b24gSXZhbm92IHdyb3RlOgo+ Pj4+Pj4+Pgo+Pj4+Pj4+PiBPbiAwOS8xMi8yMDE5IDEwOjQ4LCBhbnRvbi5pdmFub3ZAY2FtYnJp ZGdlZ3JleXMuY29tIHdyb3RlOgo+Pj4+Pj4+Pj4gRnJvbTogQW50b24gSXZhbm92IDxhbnRvbi5p dmFub3ZAY2FtYnJpZGdlZ3JleXMuY29tPgo+Pj4+Pj4+Pj4KPj4+Pj4+Pj4+IFNvbWUgb2YgdGhl IGZyYW1lcyBtYXJrZWQgYXMgR1NPIHdoaWNoIGFycml2ZSBhdAo+Pj4+Pj4+Pj4gdmlydGlvX25l dF9oZHJfZnJvbV9za2IoKSBoYXZlIG5vIEdTT19UWVBFLCBubwo+Pj4+Pj4+Pj4gZnJhZ21lbnRz IChkYXRhX2xlbiA9IDApIGFuZCBsZW5ndGggc2lnbmlmaWNhbnRseSBzaG9ydGVyCj4+Pj4+Pj4+ PiB0aGFuIHRoZSBNVFUgKDc1MiBpbiBteSBleHBlcmltZW50cykuCj4+Pj4+Pj4+Pgo+Pj4+Pj4+ Pj4gVGhpcyBpcyBvYnNlcnZlZCBvbiByYXcgc29ja2V0cyByZWFkaW5nIG9mZiB2RXRoIGludGVy ZmFjZXMKPj4+Pj4+Pj4+IGluIGFsbCA0LnggYW5kIDUueCBrZXJuZWxzIEkgdGVzdGVkLgo+Pj4+ Pj4+Pj4KPj4+Pj4+Pj4+IFRoZXNlIGZyYW1lcyBhcmUgcmVwb3J0ZWQgYXMgaW52YWxpZCB3aGls ZSB0aGV5IGFyZSBpbiBmYWN0Cj4+Pj4+Pj4+PiBnc28tbGVzcyBmcmFtZXMuCj4+Pj4+Pj4+Pgo+ Pj4+Pj4+Pj4gVGhpcyBwYXRjaCBtYXJrcyB0aGUgdm5ldCBoZWFkZXIgYXMgbm8tR1NPIGZvciB0 aGVtIGluc3RlYWQKPj4+Pj4+Pj4+IG9mIHJlcG9ydGluZyBpdCBhcyBpbnZhbGlkLgo+Pj4+Pj4+ Pj4KPj4+Pj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEFudG9uIEl2YW5vdiA8YW50b24uaXZhbm92QGNh bWJyaWRnZWdyZXlzLmNvbT4KPj4+Pj4+Pj4+IC0tLQo+Pj4+Pj4+Pj4gICDCoCBpbmNsdWRlL2xp bnV4L3ZpcnRpb19uZXQuaCB8IDggKysrKysrLS0KPj4+Pj4+Pj4+ICAgwqAgMSBmaWxlIGNoYW5n ZWQsIDYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4+Pj4+Pj4+Cj4+Pj4+Pj4+PiBk aWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC92aXJ0aW9fbmV0LmggYi9pbmNsdWRlL2xpbnV4L3Zp cnRpb19uZXQuaAo+Pj4+Pj4+Pj4gaW5kZXggMGQxZmU5Mjk3YWM2Li5kOTBkNWNmZjFiOWEgMTAw NjQ0Cj4+Pj4+Pj4+PiAtLS0gYS9pbmNsdWRlL2xpbnV4L3ZpcnRpb19uZXQuaAo+Pj4+Pj4+Pj4g KysrIGIvaW5jbHVkZS9saW51eC92aXJ0aW9fbmV0LmgKPj4+Pj4+Pj4+IEBAIC0xMTIsOCArMTEy LDEyIEBAIHN0YXRpYyBpbmxpbmUgaW50Cj4+Pj4+Pj4+PiB2aXJ0aW9fbmV0X2hkcl9mcm9tX3Nr Yihjb25zdCBzdHJ1Y3Qgc2tfYnVmZiAqc2tiLAo+Pj4+Pj4+Pj4gICDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBoZHItPmdzb190eXBlID0gVklSVElPX05FVF9IRFJfR1NPX1RDUFY0Owo+Pj4+ Pj4+Pj4gICDCoMKgwqDCoMKgwqDCoMKgwqAgZWxzZSBpZiAoc2luZm8tPmdzb190eXBlICYgU0tC X0dTT19UQ1BWNikKPj4+Pj4+Pj4+ICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyLT5n c29fdHlwZSA9IFZJUlRJT19ORVRfSERSX0dTT19UQ1BWNjsKPj4+Pj4+Pj4+IC3CoMKgwqDCoMKg wqDCoCBlbHNlCj4+Pj4+Pj4+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVJTlZB TDsKPj4+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBlbHNlIHsKPj4+Pj4+Pj4+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIGlmIChza2ItPmRhdGFfbGVuID09IDApCj4+Pj4+Pj4+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIGhkci0+Z3NvX3R5cGUgPSBWSVJUSU9fTkVUX0hEUl9HU09f Tk9ORTsKPj4+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGVsc2UKPj4+Pj4+Pj4+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4+Pj4+Pj4+PiAr wqDCoMKgwqDCoMKgwqAgfQo+Pj4+Pj4+Pj4gICDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKHNpbmZv LT5nc29fdHlwZSAmIFNLQl9HU09fVENQX0VDTikKPj4+Pj4+Pj4+ICAgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgaGRyLT5nc29fdHlwZSB8PSBWSVJUSU9fTkVUX0hEUl9HU09fRUNOOwo+Pj4+ Pj4+Pj4gICDCoMKgwqDCoMKgIH0gZWxzZQo+Pj4+Pj4+Pj4KPj4+Pj4+Pj4gcGluZy4KPj4+Pj4+ Pj4KPj4+Pj4+PiBEbyB5b3UgbWVhbiBnc29fc2l6ZSBpcyBzZXQgYnV0IGdzb190eXBlIGlzIG5v dD8gTG9va3MgbGlrZSBhIGJ1Zwo+Pj4+Pj4+IGVsc2V3aGVyZS4KPj4+Pj4+Pgo+Pj4+Pj4+IFRo YW5rcwo+Pj4+Pj4+Cj4+Pj4+Pj4KPj4+Pj4+IFllcy4KPj4+Pj4+Cj4+Pj4+PiBJIGNvdWxkIG5v dCB0cmFjZSBpdCB3aGVyZSBpdCBpcyBjb21pbmcgZnJvbS4KPj4+Pj4+Cj4+Pj4+PiBJIHNlZSBp dCB3aGVuIGRvaW5nIHJlY3ZtbXNnIG9uIHJhdyBzb2NrZXRzIGluIHRoZSBVTUwgdmVjdG9yIG5l dHdvcmsKPj4+Pj4+IGRyaXZlcnMuCj4+Pj4+Pgo+Pj4+PiBJIHRoaW5rIHdlIG5lZWQgdG8gZmlu ZCB0aGUgY3VscHJpdCBhbmQgZml4IGl0IHRoZXJlLCBsb3RzIG9mIG90aGVyIHRoaW5ncwo+Pj4+ PiBjYW4gYnJlYWsgb3RoZXJ3aXNlLgo+Pj4+PiBKdXN0IHByaW50aW5nIG91dCBza2ItPmRldi0+ bmFtZSBzaG91bGQgZG8gdGhlIHRyaWNrLCBubz8KPj4+PiBUaGUgcHJpbnRrIGluIHZpcnRpb19u ZXRfaGRyX2Zyb21fc2tiIHNheXMgTlVMTC4KPj4+Pgo+Pj4+IFRoYXQgaXMgcHJvYmFibHkgbm9y bWFsIGZvciBhIGxvY2FsbHkgb3JpZ2luYXRlZCBmcmFtZS4KPj4+Pgo+Pj4+IEkgY2Fubm90IHJl cHJvZHVjZSB0aGlzIHdpdGggbmV0d29yayB0cmFmZmljIGJ5IHRoZSB3YXkgLSBpdCBoYXBwZW5z IG9ubHkgaWYgdGhlIHRyYWZmaWMgaXMgbG9jYWxseSBvcmlnaW5hdGVkIG9uIHRoZSBob3N0Lgo+ Pj4+Cj4+Pj4gQSwKPj4+IE9LIHNvIGlzIGl0IGNvZGUgaW4gX190Y3BfdHJhbnNtaXRfc2tiIHRo YXQgc2V0cyBnc29fc2l6ZSB0byBub24tbnVsbAo+Pj4gd2hlbiBnc29fdHlwZSBpcyAwPwo+Pj4K Pj4gQ29ycmVjdCB3YXkgdG8gZGV0ZXJtaW5lIGlmIGEgcGFja2V0IGlzIGEgZ3NvIG9uZSBpcyBi eSBsb29raW5nIGF0IGdzb19zaXplLgo+PiBUaGVuIG9ubHkgaXQgaXMgbGVnYWwgbG9va2luZyBh dCBnc29fdHlwZQo+Pgo+Pgo+PiBzdGF0aWMgaW5saW5lIGJvb2wgc2tiX2lzX2dzbyhjb25zdCBz dHJ1Y3Qgc2tfYnVmZiAqc2tiKQo+PiB7Cj4+ICAgICAgcmV0dXJuIHNrYl9zaGluZm8oc2tiKS0+ Z3NvX3NpemU7Cj4+IH0KPj4KPj4gLyogTm90ZTogU2hvdWxkIGJlIGNhbGxlZCBvbmx5IGlmIHNr Yl9pc19nc28oc2tiKSBpcyB0cnVlICovCj4+IHN0YXRpYyBpbmxpbmUgYm9vbCBza2JfaXNfZ3Nv X3Y2KGNvbnN0IHN0cnVjdCBza19idWZmICpza2IpCj4+IC4uLgo+Pgo+Pgo+PiBUaGVyZSBpcyBh YnNvbHV0ZWx5IG5vIHJlbGF0aW9uIGJldHdlZW4gR1NPIGFuZCBza2ItPmRhdGFfbGVuLCBza2Ig Y2FuIGJlIGxpbmVhcml6ZWQKPj4gZm9yIHZhcmlvdXMgb3J0aG9nb25hbCByZWFzb25zLgo+IFRo ZSByZXBvcnRlZCBwcm9ibGVtIGlzIHRoYXQgdmlydGlvIGdldHMgYSBwYWNrZXQgd2hlcmUgZ3Nv X3NpemUKPiBpcyAhMCBidXQgZ3NvX3R5cGUgaXMgMC4KPgo+IEl0IGN1cnJlbnRseSBkcm9wcyB0 aGVzZSBvbiB0aGUgYXNzdW1wdGlvbiB0aGF0IGl0J3Mgc29tZSB0eXBlCj4gb2YgYSBnc28gcGFj a2V0IGl0IGRvZXMgbm90IGtub3cgaG93IHRvIGhhbmRsZS4KPgo+Cj4gU28geW91IGFyZSBzYXlp bmcgaWYgc2tiX2lzX2dzbyB3ZSBjYW4gc3RpbGwgaGF2ZSBnc29fdHlwZSBzZXQgdG8gMCwKPiBh bmQgdGhhdCdzIGFuIGV4cGVjdGVkIGNvbmZpZ3VyYXRpb24/Cj4KPiBTbyB0aGUgcGF0Y2ggc2hv dWxkIGp1c3QgYmU6Cj4KPgo+IC0gICAgICAgIGlmIChza2JfaXNfZ3NvKHNrYikpIHsKPiArICAg ICAgICBpZiAoc2tiX2lzX2dzbyhza2IpICYmIHNpbmZvLT5nc29fdHlwZSkgewo+ClllcywgcHJv dmlkZWQgdGhhdCBza2JfaXNfZ3NvKHNrYikgYW5kIHNpbmZvLT5nc29fdHlwZSA9PSAwIGlzIGEg dmFsaWQgc3RhdGUuCgpJIGFncmVlIHdpdGggSmFzb24sIHRoZXJlIG1heSBiZSBzb21ldGhpbmcg d3JvbmcgZ29pbmcgb24gaGVyZSBhbmQgd2UgbmVlZCB0byBmaW5kIHRoZSBzb3VyY2Ugd2hpY2gg Y3JlYXRlcyB0aGVzZSBwYWNrZXRzLgoKQS4KCj4KPiA/Cj4KPgo+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gbGludXgtdW0gbWFpbGluZyBsaXN0Cj4g bGludXgtdW1AbGlzdHMuaW5mcmFkZWFkLm9yZwo+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtdW0KCi0tIApBbnRvbiBSLiBJdmFub3YKQ2FtYnJpZGdl Z3JleXMgTGltaXRlZC4gUmVnaXN0ZXJlZCBpbiBFbmdsYW5kLiBDb21wYW55IE51bWJlciAxMDI3 MzY2MQpodHRwczovL3d3dy5jYW1icmlkZ2VncmV5cy5jb20vCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtdW0gbWFpbGluZyBsaXN0CmxpbnV4 LXVtQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC11bQo=