From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A72C433B4 for ; Mon, 26 Apr 2021 01:10:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A9DD61163 for ; Mon, 26 Apr 2021 01:10:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231567AbhDZBKy (ORCPT ); Sun, 25 Apr 2021 21:10:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231403AbhDZBKu (ORCPT ); Sun, 25 Apr 2021 21:10:50 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00A65C061574 for ; Sun, 25 Apr 2021 18:10:10 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id kb13-20020a17090ae7cdb02901503d67f0beso6853842pjb.0 for ; Sun, 25 Apr 2021 18:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=pTKzBHp5j0vCgxSh4c7wshNFuD9LEJ9YRB/12kbwjnM=; b=T+oBdu+wmEg5aKOemx/tinBpUPPzwyvupn4p2rlKf2qpdonjPewcz4t7qRn9D3FtbT 5ndwvc/f/kQ3+5+5nu1WDGdnoyWuR+slQ9yF4UFlQ2CyPlfbDIHBePZc+ot6VDYftXHc Uc/YwAvXc+vTliKH91KpJotokdDciNI2rIAE6JIlhwlL8i5z6uJqYVxn3+ylhUFcxG15 YTaULgFULEQQteoxvPa/Av4Bb/2CHBh+dNFzphrM1GNI+9s4cVVTnd/D4DZjAnL85n8/ F6t59KGA87z1cZQ14gogFvPNy+ni3BflKrzstuPrtvT/yvCZLaay0ZoHGKbcNO7Gk//2 oOLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=pTKzBHp5j0vCgxSh4c7wshNFuD9LEJ9YRB/12kbwjnM=; b=U4z8IMbyhNWzpDcEFPDwqr2Lgp9HfHpvr86ol7GGAFWxmH0omKt4mAuhOPWK9qJ9gA ksuIByrtUxfMvitZClqOjkVFROqX3gr9GnYC80nB4wSaT822hksmWXm+/HA8bHd9ZxSq n3kqUZk1qP0dmtu79V9W4EvofvM/Ri6vTELNmutnqo8Lj+BRg0g3Yo28/HvZpqykmRGO MdbU+JcyAX6DuXf2OMaLtNnXQ4LD/epg8SlqjqQK6aR1N14TCv1MD7tVsZT5juliGuuT oyLi+rNE5Ls5ARoATqpMPVdNGcGREaGEEuG+sZcEXeIZxBKVp2K5YPZTHpSVu/H71VbP +bpg== X-Gm-Message-State: AOAM533NlH8cV6JIw8YmR+L2TGKtKMrMtIrQNiyOMQ+sK8Be3QXmDJD6 OC84EUA+7XNW7AksVvNup5l/BQ== X-Google-Smtp-Source: ABdhPJzbbtMa5X50t8cJdluFStqkvCSKNnlki6qQdnTAcBXLg2hkN/nNxgDELvuQ8+Oz2PLjmVhY3Q== X-Received: by 2002:a17:902:b703:b029:eb:59c3:a9b0 with SMTP id d3-20020a170902b703b02900eb59c3a9b0mr15462567pls.45.1619399409395; Sun, 25 Apr 2021 18:10:09 -0700 (PDT) Received: from [2620:15c:17:3:f93a:1c09:9070:93a7] ([2620:15c:17:3:f93a:1c09:9070:93a7]) by smtp.gmail.com with ESMTPSA id ga21sm10649060pjb.5.2021.04.25.18.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Apr 2021 18:10:08 -0700 (PDT) Date: Sun, 25 Apr 2021 18:10:07 -0700 (PDT) From: David Rientjes To: Oliver Glitta cc: cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/slub: use stackdepot to save stack trace in objects In-Reply-To: <20210414163434.4376-1-glittao@gmail.com> Message-ID: <3558629b-2ae3-7c8a-f121-c3413aa8fb30@google.com> References: <20210414163434.4376-1-glittao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Apr 2021, glittao@gmail.com wrote: > From: Oliver Glitta > > Many stack traces are similar so there are many similar arrays. > Stackdepot saves each unique stack only once. > > Replace field addrs in struct track with depot_stack_handle_t handle. > Use stackdepot to save stack trace. > > The benefits are smaller memory overhead and possibility to aggregate > per-cache statistics in the future using the stackdepot handle > instead of matching stacks manually. > > Signed-off-by: Oliver Glitta Acked-by: David Rientjes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5554AC433ED for ; Mon, 26 Apr 2021 01:10:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F036B61163 for ; Mon, 26 Apr 2021 01:10:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F036B61163 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 64CC76B0070; Sun, 25 Apr 2021 21:10:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FE006B0071; Sun, 25 Apr 2021 21:10:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49D5A6B0072; Sun, 25 Apr 2021 21:10:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 2B3286B0070 for ; Sun, 25 Apr 2021 21:10:11 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D6DA41F06 for ; Mon, 26 Apr 2021 01:10:10 +0000 (UTC) X-FDA: 78072736980.24.5D8055F Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf14.hostedemail.com (Postfix) with ESMTP id 7BC74C0007C9 for ; Mon, 26 Apr 2021 01:09:56 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id t2-20020a17090a0242b0290155433387beso1375950pje.1 for ; Sun, 25 Apr 2021 18:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=pTKzBHp5j0vCgxSh4c7wshNFuD9LEJ9YRB/12kbwjnM=; b=T+oBdu+wmEg5aKOemx/tinBpUPPzwyvupn4p2rlKf2qpdonjPewcz4t7qRn9D3FtbT 5ndwvc/f/kQ3+5+5nu1WDGdnoyWuR+slQ9yF4UFlQ2CyPlfbDIHBePZc+ot6VDYftXHc Uc/YwAvXc+vTliKH91KpJotokdDciNI2rIAE6JIlhwlL8i5z6uJqYVxn3+ylhUFcxG15 YTaULgFULEQQteoxvPa/Av4Bb/2CHBh+dNFzphrM1GNI+9s4cVVTnd/D4DZjAnL85n8/ F6t59KGA87z1cZQ14gogFvPNy+ni3BflKrzstuPrtvT/yvCZLaay0ZoHGKbcNO7Gk//2 oOLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=pTKzBHp5j0vCgxSh4c7wshNFuD9LEJ9YRB/12kbwjnM=; b=qLsSPOHxUJvTMwpJXRXBKLzy2LwhnEZeTbWRvlFRPl7byPa2uQwvT+/E7MiOf6Yc/2 72rM7aeBWb38xOU9fxhZqhcQtZf66Vr22i36xT0ZGfIyQnHrxhucwrgIB6UBA66ZLisI +MSy8ObhniA6FNi6Si6ofDKPEwPh58zf0etzPdzt/d4f6EQHfr9nS3K334ZRtRKSUT3v 8JAYmVfxbzwkO/03/CgfevEcQrpb8y/AhgzbxqSUGudVgzL1IpQ0gQ03Z1tdZd+W1g2A V8sZhjrXcEw+oUgvUVSPSNvehWWfJTV1E+PCPLVlfAaLYsbNcl6ghqud2X4kPOov3amu fTgw== X-Gm-Message-State: AOAM53256nwVft2hiH3+TeZ/auQCSfM21d70Iri1Dbws7X0Z6URiAzAW Ih9iLFEzn7mppb225lqqcGaTFw== X-Google-Smtp-Source: ABdhPJzbbtMa5X50t8cJdluFStqkvCSKNnlki6qQdnTAcBXLg2hkN/nNxgDELvuQ8+Oz2PLjmVhY3Q== X-Received: by 2002:a17:902:b703:b029:eb:59c3:a9b0 with SMTP id d3-20020a170902b703b02900eb59c3a9b0mr15462567pls.45.1619399409395; Sun, 25 Apr 2021 18:10:09 -0700 (PDT) Received: from [2620:15c:17:3:f93a:1c09:9070:93a7] ([2620:15c:17:3:f93a:1c09:9070:93a7]) by smtp.gmail.com with ESMTPSA id ga21sm10649060pjb.5.2021.04.25.18.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Apr 2021 18:10:08 -0700 (PDT) Date: Sun, 25 Apr 2021 18:10:07 -0700 (PDT) From: David Rientjes To: Oliver Glitta cc: cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/slub: use stackdepot to save stack trace in objects In-Reply-To: <20210414163434.4376-1-glittao@gmail.com> Message-ID: <3558629b-2ae3-7c8a-f121-c3413aa8fb30@google.com> References: <20210414163434.4376-1-glittao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: d3ds9dbaacaddfkm7zmz1fffqrz8fcwo X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7BC74C0007C9 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=mail-pj1-f54.google.com; client-ip=209.85.216.54 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619399396-501358 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 14 Apr 2021, glittao@gmail.com wrote: > From: Oliver Glitta > > Many stack traces are similar so there are many similar arrays. > Stackdepot saves each unique stack only once. > > Replace field addrs in struct track with depot_stack_handle_t handle. > Use stackdepot to save stack trace. > > The benefits are smaller memory overhead and possibility to aggregate > per-cache statistics in the future using the stackdepot handle > instead of matching stacks manually. > > Signed-off-by: Oliver Glitta Acked-by: David Rientjes