From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A4D26E3D6 for ; Thu, 12 Aug 2021 12:00:58 +0000 (UTC) From: Janusz Krzysztofik Date: Thu, 12 Aug 2021 14:00:54 +0200 Message-ID: <3558678.MHq7AAxBmi@jkrzyszt-mobl1.ger.corp.intel.com> In-Reply-To: <20210812090738.GB27582@zkempczy-mobl2> References: <20210812090032.117930-1-janusz.krzysztofik@linux.intel.com> <20210812090738.GB27582@zkempczy-mobl2> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [igt-dev] [PATCH i-g-t] lib/intel_memory_region: Constify info structures List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Zbigniew =?utf-8?B?S2VtcGN6ecWEc2tp?= Cc: igt-dev@lists.freedesktop.org List-ID: On czwartek, 12 sierpnia 2021 11:07:38 CEST Zbigniew Kempczy=C5=84ski wrote: > On Thu, Aug 12, 2021 at 11:00:32AM +0200, Janusz Krzysztofik wrote: > > Functions which extract information from drm_i915_query_memory_regions > > structures passed via their pointer as an argument don't modify those > > structures, let them accept that content declared as constant. > >=20 > > Signed-off-by: Janusz Krzysztofik >=20 > Looks safe:=20 >=20 > Reviewed-by: Zbigniew Kempczy=C5=84ski Thanks Zbyszek, pushed. Janusz >=20 > -- > Zbigniew > > --- > > lib/i915/intel_memory_region.c | 12 ++++++------ > > lib/i915/intel_memory_region.h | 12 ++++++------ > > 2 files changed, 12 insertions(+), 12 deletions(-) > >=20 > > diff --git a/lib/i915/intel_memory_region.c b/lib/i915/intel_memory_reg= ion.c > > index 72e337af3..3de405493 100644 > > --- a/lib/i915/intel_memory_region.c > > +++ b/lib/i915/intel_memory_region.c > > @@ -309,7 +309,7 @@ char *memregion_dynamic_subtest_name(struct igt_col= lection *set) > > * > > * Outputs memory regions and their sizes. > > */ > > -void intel_dump_gpu_meminfo(struct drm_i915_query_memory_regions *info) > > +void intel_dump_gpu_meminfo(const struct drm_i915_query_memory_regions= *info) > > { > > int i; > > =20 > > @@ -336,7 +336,7 @@ void intel_dump_gpu_meminfo(struct drm_i915_query_m= emory_regions *info) > > * > > * Returns: number of regions for type @memory_class > > */ > > -uint32_t gpu_meminfo_region_count(struct drm_i915_query_memory_regions= *info, > > +uint32_t gpu_meminfo_region_count(const struct drm_i915_query_memory_r= egions *info, > > uint16_t memory_class) > > { > > uint32_t num =3D 0; > > @@ -359,7 +359,7 @@ uint32_t gpu_meminfo_region_count(struct drm_i915_q= uery_memory_regions *info, > > * Returns: total size of all regions which are type @memory_class, -1= when the > > * size of at least one region is unknown > > */ > > -uint64_t gpu_meminfo_region_total_size(struct drm_i915_query_memory_re= gions *info, > > +uint64_t gpu_meminfo_region_total_size(const struct drm_i915_query_mem= ory_regions *info, > > uint16_t memory_class) > > { > > uint64_t total =3D 0; > > @@ -386,7 +386,7 @@ uint64_t gpu_meminfo_region_total_size(struct drm_i= 915_query_memory_regions *inf > > * Returns: available size of all regions which are type @memory_class= , -1 when > > * the size of at least one region cannot be estimated > > */ > > -uint64_t gpu_meminfo_region_total_available(struct drm_i915_query_memo= ry_regions *info, > > +uint64_t gpu_meminfo_region_total_available(const struct drm_i915_quer= y_memory_regions *info, > > uint16_t memory_class) > > { > > uint64_t avail =3D 0; > > @@ -414,7 +414,7 @@ uint64_t gpu_meminfo_region_total_available(struct = drm_i915_query_memory_regions > > * Returns: available size of @memory_instance which type is @memory_c= lass, -1 > > * when the size is unknown > > */ > > -uint64_t gpu_meminfo_region_size(struct drm_i915_query_memory_regions = *info, > > +uint64_t gpu_meminfo_region_size(const struct drm_i915_query_memory_re= gions *info, > > uint16_t memory_class, > > uint16_t memory_instance) > > { > > @@ -439,7 +439,7 @@ uint64_t gpu_meminfo_region_size(struct drm_i915_qu= ery_memory_regions *info, > > * Returns: available size of @memory_instance region which type is > > * @memory_class, -1 when the size cannot be estimated > > */ > > -uint64_t gpu_meminfo_region_available(struct drm_i915_query_memory_reg= ions *info, > > +uint64_t gpu_meminfo_region_available(const struct drm_i915_query_memo= ry_regions *info, > > uint16_t memory_class, > > uint16_t memory_instance) > > { > > diff --git a/lib/i915/intel_memory_region.h b/lib/i915/intel_memory_reg= ion.h > > index 8cd18ea0e..70b74944b 100644 > > --- a/lib/i915/intel_memory_region.h > > +++ b/lib/i915/intel_memory_region.h > > @@ -113,19 +113,19 @@ __get_memory_region_set(struct drm_i915_query_mem= ory_regions *regions, > > =20 > > char *memregion_dynamic_subtest_name(struct igt_collection *set); > > =20 > > -void intel_dump_gpu_meminfo(struct drm_i915_query_memory_regions *info= ); > > +void intel_dump_gpu_meminfo(const struct drm_i915_query_memory_regions= *info); > > =20 > > -uint32_t gpu_meminfo_region_count(struct drm_i915_query_memory_regions= *info, > > +uint32_t gpu_meminfo_region_count(const struct drm_i915_query_memory_r= egions *info, > > uint16_t region_class); > > -uint64_t gpu_meminfo_region_total_size(struct drm_i915_query_memory_re= gions *info, > > +uint64_t gpu_meminfo_region_total_size(const struct drm_i915_query_mem= ory_regions *info, > > uint16_t region_class); > > -uint64_t gpu_meminfo_region_total_available(struct drm_i915_query_memo= ry_regions *info, > > +uint64_t gpu_meminfo_region_total_available(const struct drm_i915_quer= y_memory_regions *info, > > uint16_t region_type); > > =20 > > -uint64_t gpu_meminfo_region_size(struct drm_i915_query_memory_regions = *info, > > +uint64_t gpu_meminfo_region_size(const struct drm_i915_query_memory_re= gions *info, > > uint16_t memory_class, > > uint16_t memory_instance); > > -uint64_t gpu_meminfo_region_available(struct drm_i915_query_memory_reg= ions *info, > > +uint64_t gpu_meminfo_region_available(const struct drm_i915_query_memo= ry_regions *info, > > uint16_t memory_class, > > uint16_t memory_instance); > > =20 >=20