From: Hans de Goede <hdegoede@redhat.com>
To: "Luke D. Jones" <luke@ljones.dev>
Cc: corentin.chary@gmail.com, acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Remove GA14/15 quirks to acpi/video_detect
Date: Fri, 21 May 2021 12:24:13 +0200 [thread overview]
Message-ID: <3559f449-7d43-bf6f-0047-3138fd303db8@redhat.com> (raw)
In-Reply-To: <20210419074915.393433-1-luke@ljones.dev>
Hi Luke,
On 4/19/21 9:49 AM, Luke D. Jones wrote:
> Revert two commits to allow a patch to acpi/video_detect to correctly
> set the backlight control as native.
>
> Luke D. Jones (2):
> Revert "platform/x86: asus-nb-wmi: Drop duplicate DMI quirk
> structures"
> Revert "platform/x86: asus-nb-wmi: add support for ASUS ROG Zephyrus
> G14 and G15"
Thank you, since the matching drivers/acpi/video_detect.c have been merged
by Rafael, I've added these to my review-hans branch now.
But there is one problem, these miss a:
Signed-off-by: Luke D. Jones <luke@ljones.dev>
In their commit message, I assume this was an oversight, so I've added
this. If you can let me know if this is ok, then I can push these to
for-next.
I've also rewritten the commit messages to explain why things are being
reverted, see:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Regards,
Hans
next prev parent reply other threads:[~2021-05-21 10:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 7:49 [PATCH 0/2] Remove GA14/15 quirks to acpi/video_detect Luke D. Jones
2021-04-19 7:49 ` [PATCH 1/2] Revert "platform/x86: asus-nb-wmi: Drop duplicate DMI quirk structures" Luke D. Jones
2021-04-19 7:49 ` [PATCH 2/2] Revert "platform/x86: asus-nb-wmi: add support for ASUS ROG Zephyrus G14 and G15" Luke D. Jones
2021-04-19 8:00 ` [PATCH 0/2] Remove GA14/15 quirks to acpi/video_detect Hans de Goede
[not found] ` <M0XSRQ.41V51K2O2UAK@ljones.dev>
2021-04-19 8:16 ` Hans de Goede
2021-05-21 10:24 ` Hans de Goede [this message]
2021-05-21 10:36 ` Luke Jones
[not found] ` <HEDGTQ.IHJJLIVNVMJ21@ljones.dev>
2021-05-21 16:58 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3559f449-7d43-bf6f-0047-3138fd303db8@redhat.com \
--to=hdegoede@redhat.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.